Skip to content

Disabling mem2reg by default #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

AlexeySotkin
Copy link
Contributor

Translator is not supposed to optimize code.
Also mem2reg complicates debugger's work.

Signed-off-by: Alexey Sotkin [email protected]

Translator is not supposed to optimize code.
Also mem2reg complicates debugger's work.

Signed-off-by: Alexey Sotkin <[email protected]>
@AlexeySotkin AlexeySotkin requested a review from bader July 19, 2019 14:52
@bader
Copy link
Contributor

bader commented Jul 19, 2019

Note: I've asked @AGindinson to pull all patches from the translator repo here: #347.
Please, sync with him and decide if this PR still needed.

@AGindinson
Copy link
Contributor

Note: I've asked @AGindinson to pull all patches from the translator repo here: #347.
Please, sync with him and decide if this PR still needed.

@bader, this PR and #347 are the only commits that were made to Translator since the last pulldown. Maybe proceeding with both could be faster?

@bader
Copy link
Contributor

bader commented Jul 19, 2019

Note: I've asked @AGindinson to pull all patches from the translator repo here: #347.
Please, sync with him and decide if this PR still needed.

@bader, this PR and #347 are the only commits that were made to Translator since the last pulldown. Maybe proceeding with both could be faster?

There should be no difference then and I prefer to stick with the regular process.
Please, make sure that there is no patches committed to SPIR-V translator in SYCL repo, which are not committed to Khronos repository yet.

@AGindinson
Copy link
Contributor

@AlexeySotkin I've created #351 that combines our PR's so that the usual procedure is carried out. I believe this PR may be closed

@bader bader closed this Jul 19, 2019
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants