[SYCL][FPGA] [WIP]Do not propagate the attributes from device functions to a kernel #3601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a kernel Attributes that should not be propagated from device functions to a kernel to match with new SYCL 2020 spec. 1. scheduler_target_fmax_mhz 2. kernel_args_restrict 3. no_global_work_offset This patch also updates codegen and sema tests of scheduler-target-fmax-mhz attribute to pass sycl2020 flag to show the support and match with new FE test formats. Signed-off-by: Soumi Manna <[email protected]>
smanna12
changed the title
There was a problem hiding this comment.
General question: what about older SYCL modes? Should these still propagate in those cases?
No, it will not propagate to older SYCL modes with the current change. I was not sure whether we will keep the functionality with old mode.
-sycl-std=2020: no propagation
-sycl-std=2017: propagation
If we want to keep old functionality, then we need to add this check based on SYCL mode inside SemaSYCL.cpp file where we are currently handling the propagation mechanism.
Any thought?
smanna12
added a commit
to smanna12/llvm
that referenced
this pull request
Apr 27, 2021
This patch
1. updates CodeGen tests for disable_loop_pipelining and initiation_interval attributes.
2. rewrites Sema and CodeGen tests for scheduler-target-fmax-mhz attribute according to
FE test guidelines and also separates AST and diagnostic parts for scheduler-target-fmax-mhz
attribute to avoid unrelated changes on intel#3601.
Signed-off-by: Soumi Manna <[email protected]>
smanna12
changed the title
bader
pushed a commit
that referenced
this pull request
Apr 28, 2021
This patch
1. updates CodeGen tests for disable_loop_pipelining and initiation_interval attributes.
2. rewrites Sema and CodeGen tests for scheduler-target-fmax-mhz attribute according to
FE test guidelines and also separates AST and diagnostic parts for scheduler-target-fmax-mhz
attribute to avoid unrelated changes on #3601.
Signed-off-by: Soumi Manna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes that should not be propagated from device functions to a kernel to match with new SYCL 2020 spec.
This patch also updates codegen and sema tests of
scheduler-target-fmax-mhz attribute to pass sycl2020 flag
and match with new FE test formats.
I will address other attributes in a separate PR.
Signed-off-by: Soumi Manna [email protected]