Skip to content

[SYCL] Add DPC++ RT support for SYCL2020 spec constants' default values #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dm-vodopyanov
Copy link
Contributor

This patch introduces the support of default values for SYCL2020
specialization constants in DPC++ runtime.

This patch introduces the support of default values for SYCL2020
specialization constants in DPC++ runtime.
@alexbatashev alexbatashev requested a review from vmaksimo May 7, 2021 10:14
@alexbatashev alexbatashev marked this pull request as ready for review May 7, 2021 10:15
@alexbatashev alexbatashev requested review from smaslov-intel and a team as code owners May 7, 2021 10:15
@alexbatashev
Copy link
Contributor

@intel/llvm-reviewers-runtime friendly ping

Copy link
Contributor Author

@dm-vodopyanov dm-vodopyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but being the submitter of the PR, I can't press the approve button.

Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dm-vodopyanov
Copy link
Contributor Author

Failures in Jenkins/Precommit are not related to this patch and look flaky, created trackers and re-started the job:

  • (Linux) ESIMD/private_memory/pm_access_1.cpp
  • (Windows) Reduction/reduction_nd_ext_half.cpp

@bader
Copy link
Contributor

bader commented May 11, 2021

Failures in Jenkins/Precommit are not related to this patch and look flaky, created trackers and re-started the job

It should be

Failures in Jenkins/Precommit are not related to this patch and look flaky, created trackers, disabled failing tests and re-started the job

@alexbatashev
Copy link
Contributor

@smaslov-intel friendly ping

@romanovvlad romanovvlad merged commit 07b2796 into intel:sycl May 12, 2021
@dm-vodopyanov dm-vodopyanov deleted the private/dvodopya/spec-const-w-default-values branch February 10, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants