-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL] Add DPC++ RT support for SYCL2020 spec constants' default values #3667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Add DPC++ RT support for SYCL2020 spec constants' default values #3667
Conversation
This patch introduces the support of default values for SYCL2020 specialization constants in DPC++ runtime.
@intel/llvm-reviewers-runtime friendly ping |
Co-authored-by: Dmitry Vodopyanov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but being the submitter of the PR, I can't press the approve button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Failures in Jenkins/Precommit are not related to this patch and look flaky, created trackers and re-started the job:
|
It should be
|
@smaslov-intel friendly ping |
This patch introduces the support of default values for SYCL2020
specialization constants in DPC++ runtime.