Skip to content

[SYCL] Fix free function queries for host device #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexbatashev
Copy link
Contributor

@alexbatashev alexbatashev commented Aug 18, 2021

#4090 moved free function queries to a different namespace. Host device implementation actually relies on integration header to extract information about free function queries and set the appropriate values.

AaronBallman
AaronBallman previously approved these changes Aug 18, 2021
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a better commit message wouldn't make me sad.

Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@alexbatashev
Copy link
Contributor Author

The failing test seems to be unrelated to this PR and affects other PRs as well. I created a tracker and a PR to disable this test: #4368

@romanovvlad romanovvlad merged commit 65436fb into intel:sycl Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants