Skip to content

[SYCL] Remove ONEAPI/INTEL namespaces #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 27, 2021
Merged

[SYCL] Remove ONEAPI/INTEL namespaces #4488

merged 7 commits into from
Sep 27, 2021

Conversation

maximdimakov
Copy link
Contributor

ONEAPI/INTEL namespaces are deprecated in SYCL 2020
This patch depends on tests : intel/llvm-test-suite#442

@maximdimakov maximdimakov mentioned this pull request Sep 3, 2021
Merged
AaronBallman
AaronBallman previously approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE bits look good to me, but there should be a release note about the removal.

kbobrovs
kbobrovs previously approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESIMD part LGTM

@maximdimakov maximdimakov dismissed stale reviews from kbobrovs and AaronBallman via e467164 September 14, 2021 13:36
@maximdimakov
Copy link
Contributor Author

Jenkins/precommit is failing due to old versions of oneDPL headers. There is a permission from oneDPL team to merge this patch with failing tests.
@dm-vodopyanov @AaronBallman @kbobrovs @romanovvlad could you, please, review?

@maximdimakov
Copy link
Contributor Author

@AaronBallman, @kbobrovs could you, please, approve?

AaronBallman
AaronBallman approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with a reminder about the release note request.

@romanovvlad romanovvlad merged commit 007f6b2 into intel:sycl Sep 27, 2021
kbobrovs
kbobrovs reviewed Sep 27, 2021
View reviewed changes
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESIMD LGTM

@maximdimakov maximdimakov deleted the depr_transition branch March 24, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbobrovs kbobrovs kbobrovs left review comments

@alexbatashev alexbatashev alexbatashev approved these changes

@AaronBallman AaronBallman AaronBallman approved these changes

@romanovvlad romanovvlad romanovvlad approved these changes

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

@DenisBakhvalov DenisBakhvalov Awaiting requested review from DenisBakhvalov

@kychendev kychendev Awaiting requested review from kychendev

@MrSidims MrSidims Awaiting requested review from MrSidims

@Pennycook Pennycook Awaiting requested review from Pennycook

@smaslov-intel smaslov-intel Awaiting requested review from smaslov-intel

@elizabethandrews elizabethandrews Awaiting requested review from elizabethandrews

@premanandrao premanandrao Awaiting requested review from premanandrao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maximdimakov @alexbatashev @AaronBallman @romanovvlad @kbobrovs