Skip to content

[SYCL] Enable Dead Argument Elimination for NVPTX backend #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 5, 2021
Merged

[SYCL] Enable Dead Argument Elimination for NVPTX backend #4617

merged 8 commits into from
Oct 5, 2021

Conversation

joeatodd
Copy link
Contributor

This addresses #2359 for NVPTX backend only. Changes are to:

  • Detect NVPTX kernels for DAE (using nvvm.annotations metadata)
  • Update the metadata with new function signatures as required
  • Renaming some metadata, variables & files to reflect the fact that SYCL DAE is no longer SPIR specific
  • Updating tests to reflect the expectation that -fenable-sycl-dae flag should be passed through for nvptx targets

AGindinson
AGindinson reviewed Sep 22, 2021
View reviewed changes
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The driver changes are minor and LGTM - holding off the approval until other components are reviewed & formatting issues are settled.

bader
bader previously approved these changes Sep 22, 2021
View reviewed changes
@joeatodd
Copy link
Contributor Author

@bader, ping, I think I've addressed the formatting issues & the naming issue :)

AlexeySachkov
AlexeySachkov previously approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPIR -> SYCL renaming in files owned by me LGTM (sycl-post-link)

@bader bader linked an issue Oct 3, 2021 that may be closed by this pull request
[SYCL] Enable Dead Kernel Argument Elimination for non-SPIR target #2359
Closed
@bader bader added the cuda CUDA back-end label Oct 5, 2021
@bader bader merged commit 6b3c20f into intel:sycl Oct 5, 2021
@masterleinad masterleinad mentioned this pull request Oct 5, 2021
Merged
@joeatodd joeatodd deleted the nvptx-dae branch December 7, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@hchilama hchilama Awaiting requested review from hchilama

@kbobrovs kbobrovs Awaiting requested review from kbobrovs

@mlychkov mlychkov Awaiting requested review from mlychkov

@AGindinson AGindinson Awaiting requested review from AGindinson

Assignees
No one assigned
Labels
cuda CUDA back-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SYCL] Enable Dead Kernel Argument Elimination for non-SPIR target
5 participants
@joeatodd @bader @AlexeySachkov @AGindinson @mdtoguchi