From 98a69977894a0ba9fdbe37bd161a0089fc5a52a7 Mon Sep 17 00:00:00 2001 From: vladimirlaz Date: Tue, 23 Nov 2021 12:36:01 +0300 Subject: [PATCH 1/5] Use teams to assign code ownership --- .github/CODEOWNERS | 119 ++++++++++++++++----------------------------- 1 file changed, 43 insertions(+), 76 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index de93fc390a02d..0bce19e7c07a5 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,110 +1,77 @@ * @bader # Front-end compiler -clang/ @premanandrao @elizabethandrews @smanna12 - -# Driver -clang/**/Driver @mdtoguchi @AGindinson @hchilama +clang/ @dpcpp-cfe-reviewers # LLVM-SPIRV translator -llvm-spirv/ @AlexeySotkin @AlexeySachkov +llvm-spirv/ @intel/dpcpp-spirv-reviewers # OpenCL deps -opencl/ @pvchupin @vladimirlaz +opencl/ @intel/llvm-reviewers-runtime # OpenCL "offline" compiler -opencl/opencl-aot/ @dm-vodopyanov @AlexeySachkov @romanovvlad +opencl/opencl-aot/ @intel/dpcpp-tools-reviewers # Device library -libdevice/ @vzakhari @jinge90 +libdevice/ @intel/llvm-reviewers-runtime # DPC++ runtime library sycl/ @intel/llvm-reviewers-runtime # Documentation -sycl/ReleaseNotes.md @pvchupin @tfzhu -sycl/doc/ @pvchupin @bader +sycl/ReleaseNotes.md @dpcpp-doc-reviewers +sycl/doc/ @dpcpp-doc-reviewers sycl/doc/extensions/ @intel/dpcpp-specification-reviewers -sycl/doc/extensions/SPIRV/ @AlexeySotkin @bashbaug @mbelicki - -# Sub-groups -sycl/include/CL/sycl/detail/spirv.hpp @Pennycook @AlexeySachkov -sycl/include/sycl/ext/intel/group_algorithm.hpp @Pennycook @AlexeySachkov -sycl/include/sycl/ext/intel/sub_group.hpp @Pennycook @AlexeySachkov -sycl/include/sycl/ext/intel/sub_group_host.hpp @Pennycook @AlexeySachkov +sycl/doc/extensions/SPIRV/ @intel/dpcpp-spirv-reviewers # PI API -sycl/include/CL/sycl/detail/pi.def @smaslov-intel -sycl/include/CL/sycl/detail/pi.h @smaslov-intel -sycl/include/CL/sycl/detail/pi.hpp @smaslov-intel -sycl/include/CL/sycl/detail/pi* @smaslov-intel -sycl/plugins/ @smaslov-intel -sycl/source/detail/pi.cpp @smaslov-intel -sycl/source/detail/plugin.hpp @smaslov-intel -sycl/source/detail/posix_pi.cpp @smaslov-intel -sycl/source/detail/windows_pi.cpp @smaslov-intel +sycl/include/CL/sycl/detail/pi.def @intel/dpcpp-pi-reviewers +sycl/include/CL/sycl/detail/pi.h @intel/dpcpp-pi-reviewers +sycl/include/CL/sycl/detail/pi.hpp @intel/dpcpp-pi-reviewers +sycl/include/CL/sycl/detail/pi* @intel/dpcpp-pi-reviewers +sycl/plugins/ @intel/dpcpp-pi-reviewers +sycl/source/detail/pi.cpp @intel/dpcpp-pi-reviewers +sycl/source/detail/plugin.hpp @intel/dpcpp-pi-reviewers +sycl/source/detail/posix_pi.cpp @intel/dpcpp-pi-reviewers +sycl/source/detail/windows_pi.cpp @intel/dpcpp-pi-reviewers # ESIMD CPU emulator plug-in -sycl/plugins/esimd_cpu/ @kbobrovs @smaslov-intel +sycl/plugins/esimd_cpu/ @inteldpcpp-esimd-reviewers # CUDA plugin sycl/plugins/cuda/ @intel/llvm-reviewers-cuda -# Stream -sycl/include/CL/sycl/detail/stream_impl.hpp @againull -sycl/include/CL/sycl/stream.hpp @againull -sycl/source/detail/stream_impl.cpp @againull -sycl/source/stream.cpp @againull - -# FPGA extensions -sycl/include/sycl/ext/intel/fpga_device_selector.hpp @MrSidims -sycl/include/sycl/ext/intel/fpga_extensions.hpp @MrSidims -sycl/include/sycl/ext/intel/fpga_reg.hpp @MrSidims -sycl/include/sycl/ext/intel/pipes.hpp @MrSidims -sycl/include/CL/sycl/pipes.hpp @MrSidims - -# Reduction extension -sycl/include/sycl/ext/intel/reduction.hpp @v-klochkov - -# Function pointers -sycl/include/sycl/ext/intel/function_pointer.hpp @AlexeySachkov -sycl/source/function_pointer.cpp @AlexeySachkov - -# Half Type -sycl/include/CL/sycl/half_type.hpp @AlexeySachkov -sycl/source/half_type.cpp @AlexeySachkov - # XPTI instrumentation utilities -xpti/ @tovinkere @andykaylor @alexbatashev -xptifw/ @tovinkere @andykaylor @alexbatashev +xpti/ @tovinkere @intel/llvm-reviewers-runtime +xptifw/ @tovinkere @intel/llvm-reviewers-runtime # DPC++ tools -llvm/**/append-file/ @mdtoguchi @AGindinson -llvm/**/file-table-tform/ @mlychkov @AlexeySachkov @kbobrovs -llvm/**/llvm-foreach/ @AlexeySachkov @Fznamznon -llvm/**/llvm-no-spir-kernel/ @AGindinson @AlexeySachkov -llvm/**/sycl-post-link/ @mlychkov @AlexeySachkov @kbobrovs -llvm/include/llvm/Support/PropertySetIO.h @mlychkov @AlexeySachkov @kbobrovs -llvm/lib/Support/PropertySetIO.cpp @mlychkov @AlexeySachkov @kbobrovs -llvm/unittests/Support/PropertySetIOTest.cpp @mlychkov @AlexeySachkov @kbobrovs -llvm/include/llvm/Support/SimpleTable.h @mlychkov @AlexeySachkov @kbobrovs -llvm/lib/Support/SimpleTable.cpp @mlychkov @AlexeySachkov @kbobrovs -llvm/unittests/Support/SimpleTableTest.cpp @mlychkov @AlexeySachkov @kbobrovs -llvm/lib/Support/Base64.cpp @mlychkov @AlexeySachkov @kbobrovs +llvm/**/append-file/ @intel/dpcpp-tools-reviewers +llvm/**/file-table-tform/ @intel/dpcpp-tools-reviewers +llvm/**/llvm-foreach/ @intel/dpcpp-tools-reviewers +llvm/**/llvm-no-spir-kernel/ @intel/dpcpp-tools-reviewers +llvm/**/sycl-post-link/ @intel/dpcpp-tools-reviewers +llvm/include/llvm/Support/PropertySetIO.h @intel/dpcpp-tools-reviewers +llvm/lib/Support/PropertySetIO.cpp @intel/dpcpp-tools-reviewers +llvm/unittests/Support/PropertySetIOTest.cpp @intel/dpcpp-tools-reviewers +llvm/include/llvm/Support/SimpleTable.h @intel/dpcpp-tools-reviewers +llvm/lib/Support/SimpleTable.cpp @intel/dpcpp-tools-reviewers +llvm/unittests/Support/SimpleTableTest.cpp @intel/dpcpp-tools-reviewers +llvm/lib/Support/Base64.cpp @intel/dpcpp-tools-reviewers # Clang offload tools -clang/tools/clang-offload-bundler/ @mlychkov @sndmitriev @AlexeySachkov -clang/tools/clang-offload-wrapper/ @mlychkov @sndmitriev @AlexeySachkov @kbobrovs -clang/tools/clang-offload-deps/ @sndmitriev @mlychkov @AlexeySachkov -clang/tools/clang-offload-extract/ @sndmitriev @mlychkov @AlexeySachkov +clang/tools/clang-offload-bundler/ @intel/dpcpp-tools-reviewers +clang/tools/clang-offload-wrapper/ @intel/dpcpp-tools-reviewers +clang/tools/clang-offload-deps/ @intel/dpcpp-tools-reviewers +clang/tools/clang-offload-extract/ @intel/dpcpp-tools-reviewers # Explicit SIMD -SYCLLowerIR/ @kbobrovs @sndmitriev @kychendev @v-klochkov -esimd/ @kbobrovs @v-klochkov @kychendev -sycl/include/sycl/ext/intel/experimental/esimd.hpp @kbobrovs @v-klochkov @kychendev -sycl/doc/extensions/ExplicitSIMD/ @kbobrovs @v-klochkov @kychendev +SYCLLowerIR/ @inteldpcpp-esimd-reviewers +esimd/ @kbobrovs @inteldpcpp-esimd-reviewers +sycl/include/sycl/ext/intel/experimental/esimd.hpp @inteldpcpp-esimd-reviewers +sycl/doc/extensions/ExplicitSIMD/ @inteldpcpp-esimd-reviewers # ITT annotations -llvm/lib/Transforms/Instrumentation/SPIRITTAnnotations.cpp @MrSidims @vzakhari -llvm/include/llvm/Transforms/Instrumentation/SPIRITTAnnotations.h @MrSidims @vzakhari -llvm/test/Transforms/SPIRITTAnnotations/* @MrSidims @vzakhari +llvm/lib/Transforms/Instrumentation/SPIRITTAnnotations.cpp @intel/dpcpp-tools-reviewers +llvm/include/llvm/Transforms/Instrumentation/SPIRITTAnnotations.h @intel/dpcpp-tools-reviewers +llvm/test/Transforms/SPIRITTAnnotations/* @intel/dpcpp-tools-reviewers From 15e1b492d1a75da0a93bf647d02af5ea311da98a Mon Sep 17 00:00:00 2001 From: vladimirlaz Date: Tue, 23 Nov 2021 13:01:08 +0300 Subject: [PATCH 2/5] Apply suggestions from code review Co-authored-by: Alexey Bader --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 0bce19e7c07a5..9e2c6e738163d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -19,7 +19,7 @@ libdevice/ @intel/llvm-reviewers-runtime sycl/ @intel/llvm-reviewers-runtime # Documentation -sycl/ReleaseNotes.md @dpcpp-doc-reviewers +sycl/ReleaseNotes.md @intel/dpcpp-doc-reviewers sycl/doc/ @dpcpp-doc-reviewers sycl/doc/extensions/ @intel/dpcpp-specification-reviewers sycl/doc/extensions/SPIRV/ @intel/dpcpp-spirv-reviewers @@ -66,7 +66,7 @@ clang/tools/clang-offload-deps/ @intel/dpcpp-tools-reviewers clang/tools/clang-offload-extract/ @intel/dpcpp-tools-reviewers # Explicit SIMD -SYCLLowerIR/ @inteldpcpp-esimd-reviewers +SYCLLowerIR/ @intel/dpcpp-esimd-reviewers esimd/ @kbobrovs @inteldpcpp-esimd-reviewers sycl/include/sycl/ext/intel/experimental/esimd.hpp @inteldpcpp-esimd-reviewers sycl/doc/extensions/ExplicitSIMD/ @inteldpcpp-esimd-reviewers From 409d0342abf2130671edf0f192a22a1fa6a47c77 Mon Sep 17 00:00:00 2001 From: vladimirlaz Date: Tue, 23 Nov 2021 13:20:45 +0300 Subject: [PATCH 3/5] Apply reveiw comments --- .github/CODEOWNERS | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 9e2c6e738163d..f552e44c2d1de 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,7 +1,7 @@ * @bader # Front-end compiler -clang/ @dpcpp-cfe-reviewers +clang/ @intel/dpcpp-cfe-reviewers # LLVM-SPIRV translator llvm-spirv/ @intel/dpcpp-spirv-reviewers @@ -20,7 +20,7 @@ sycl/ @intel/llvm-reviewers-runtime # Documentation sycl/ReleaseNotes.md @intel/dpcpp-doc-reviewers -sycl/doc/ @dpcpp-doc-reviewers +sycl/doc/ @intel/dpcpp-doc-reviewers sycl/doc/extensions/ @intel/dpcpp-specification-reviewers sycl/doc/extensions/SPIRV/ @intel/dpcpp-spirv-reviewers @@ -36,7 +36,7 @@ sycl/source/detail/posix_pi.cpp @intel/dpcpp-pi-reviewers sycl/source/detail/windows_pi.cpp @intel/dpcpp-pi-reviewers # ESIMD CPU emulator plug-in -sycl/plugins/esimd_cpu/ @inteldpcpp-esimd-reviewers +sycl/plugins/esimd_cpu/ @intel/dpcpp-esimd-reviewers # CUDA plugin sycl/plugins/cuda/ @intel/llvm-reviewers-cuda @@ -67,9 +67,9 @@ clang/tools/clang-offload-extract/ @intel/dpcpp-tools-reviewers # Explicit SIMD SYCLLowerIR/ @intel/dpcpp-esimd-reviewers -esimd/ @kbobrovs @inteldpcpp-esimd-reviewers -sycl/include/sycl/ext/intel/experimental/esimd.hpp @inteldpcpp-esimd-reviewers -sycl/doc/extensions/ExplicitSIMD/ @inteldpcpp-esimd-reviewers +esimd/ @kbobrovs @intel/dpcpp-esimd-reviewers +sycl/include/sycl/ext/intel/experimental/esimd.hpp @intel/dpcpp-esimd-reviewers +sycl/doc/extensions/ExplicitSIMD/ @intel/dpcpp-esimd-reviewers # ITT annotations llvm/lib/Transforms/Instrumentation/SPIRITTAnnotations.cpp @intel/dpcpp-tools-reviewers From 7a0f66164c7d04fb7b7b9cb8600d68098562ba20 Mon Sep 17 00:00:00 2001 From: vladimirlaz Date: Tue, 30 Nov 2021 10:50:50 +0300 Subject: [PATCH 4/5] Apply offline review comments --- .github/CODEOWNERS | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index f552e44c2d1de..5e40a74d4851a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -3,6 +3,9 @@ # Front-end compiler clang/ @intel/dpcpp-cfe-reviewers +# Clang driver +clang/**/Driver @intel/dpcpp-clang-driver-reviewers + # LLVM-SPIRV translator llvm-spirv/ @intel/dpcpp-spirv-reviewers @@ -21,19 +24,12 @@ sycl/ @intel/llvm-reviewers-runtime # Documentation sycl/ReleaseNotes.md @intel/dpcpp-doc-reviewers sycl/doc/ @intel/dpcpp-doc-reviewers +sycl/doc/design/ @intel/dpcpp-specification-reviewers sycl/doc/extensions/ @intel/dpcpp-specification-reviewers -sycl/doc/extensions/SPIRV/ @intel/dpcpp-spirv-reviewers - -# PI API -sycl/include/CL/sycl/detail/pi.def @intel/dpcpp-pi-reviewers -sycl/include/CL/sycl/detail/pi.h @intel/dpcpp-pi-reviewers -sycl/include/CL/sycl/detail/pi.hpp @intel/dpcpp-pi-reviewers -sycl/include/CL/sycl/detail/pi* @intel/dpcpp-pi-reviewers -sycl/plugins/ @intel/dpcpp-pi-reviewers -sycl/source/detail/pi.cpp @intel/dpcpp-pi-reviewers -sycl/source/detail/plugin.hpp @intel/dpcpp-pi-reviewers -sycl/source/detail/posix_pi.cpp @intel/dpcpp-pi-reviewers -sycl/source/detail/windows_pi.cpp @intel/dpcpp-pi-reviewers +sycl/doc/extensions/SPIRV/ @intel/dpcpp-spirv-doc-reviewers + +# Level Zero plugin +sycl/sycl/plugins/level_zero @intel/dpcpp-l0-pi-reviewers # ESIMD CPU emulator plug-in sycl/plugins/esimd_cpu/ @intel/dpcpp-esimd-reviewers From 947cca34b8621e3f5627bff456fe576fce9fdee2 Mon Sep 17 00:00:00 2001 From: Vladimir Lazarev Date: Mon, 27 Dec 2021 18:15:30 +0300 Subject: [PATCH 5/5] Apply review comments --- .github/CODEOWNERS | 23 ++--------------------- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 5e40a74d4851a..77ff3430829c3 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -42,32 +42,13 @@ xpti/ @tovinkere @intel/llvm-reviewers-runtime xptifw/ @tovinkere @intel/llvm-reviewers-runtime # DPC++ tools -llvm/**/append-file/ @intel/dpcpp-tools-reviewers -llvm/**/file-table-tform/ @intel/dpcpp-tools-reviewers -llvm/**/llvm-foreach/ @intel/dpcpp-tools-reviewers -llvm/**/llvm-no-spir-kernel/ @intel/dpcpp-tools-reviewers -llvm/**/sycl-post-link/ @intel/dpcpp-tools-reviewers -llvm/include/llvm/Support/PropertySetIO.h @intel/dpcpp-tools-reviewers -llvm/lib/Support/PropertySetIO.cpp @intel/dpcpp-tools-reviewers -llvm/unittests/Support/PropertySetIOTest.cpp @intel/dpcpp-tools-reviewers -llvm/include/llvm/Support/SimpleTable.h @intel/dpcpp-tools-reviewers -llvm/lib/Support/SimpleTable.cpp @intel/dpcpp-tools-reviewers -llvm/unittests/Support/SimpleTableTest.cpp @intel/dpcpp-tools-reviewers -llvm/lib/Support/Base64.cpp @intel/dpcpp-tools-reviewers +llvm/ @intel/dpcpp-tools-reviewers # Clang offload tools -clang/tools/clang-offload-bundler/ @intel/dpcpp-tools-reviewers -clang/tools/clang-offload-wrapper/ @intel/dpcpp-tools-reviewers -clang/tools/clang-offload-deps/ @intel/dpcpp-tools-reviewers -clang/tools/clang-offload-extract/ @intel/dpcpp-tools-reviewers +clang/tools/clang-offload-*/ @intel/dpcpp-tools-reviewers # Explicit SIMD SYCLLowerIR/ @intel/dpcpp-esimd-reviewers esimd/ @kbobrovs @intel/dpcpp-esimd-reviewers sycl/include/sycl/ext/intel/experimental/esimd.hpp @intel/dpcpp-esimd-reviewers sycl/doc/extensions/ExplicitSIMD/ @intel/dpcpp-esimd-reviewers - -# ITT annotations -llvm/lib/Transforms/Instrumentation/SPIRITTAnnotations.cpp @intel/dpcpp-tools-reviewers -llvm/include/llvm/Transforms/Instrumentation/SPIRITTAnnotations.h @intel/dpcpp-tools-reviewers -llvm/test/Transforms/SPIRITTAnnotations/* @intel/dpcpp-tools-reviewers