[SYCL][HIP] Remove arch requirement for running lit tests #5253
Conversation
|
@bader I've updated it wherever I could including in So there might be some things to update in the CI in your side. If it's easier to test I can also split this patch into unwiring the flag and actually removing it. So we could run the CI with the flag but using the hardcoded path internally, then remove the flag from the CI, then remove the flag from the script. Just let me know. |
|
@bader I'm unsure where the test failure is on here is coming from but I don't really think this patch could cause it, could we try re-running the CI? |
https://github.com/intel/llvm/runs/4773548691?check_suite_focus=true - this looks suspicious, it might be that your change exposed a bug in the test. To re-run the tests, I suggest pulling latest changes from the |
This flag was introduced before all the tests that run code were moved to the `llvm-test-suite` repository. The tests left in this repository are only compiler tests so the offload architecture can simply be hardcoded as the tests don't depend on what hardware is available. This simplifies building and running the tests for hip.
Co-authored-by: Alexey Bader <[email protected]>
|
Rebased on top of the SYCL branch. Although now it's failing because it removes the buildbot flag, I'm not sure how these were run last time, they might need to be run manually. |
The failure is expected GitHub Actions (GHA) runs workflow twice when GHA scripts are changed: one run uses old workflow scripts and another run uses new workflow scripts. |
…/llvm into refactor_existing_workflows * 'refactor_existing_workflows' of github.com:alexbatashev/llvm: (2051 commits) [SYCL][L0] Honor property::queue::enable_profiling (intel#5543) [SYCL][CI] Enable sccache on Windows (intel#5589) [SYCL][Doc] Move internal design docs (intel#5556) [sycl-post-link] Initialize the integer Value variable (intel#5585) [CI] Fix nightly builds (intel#5584) [SYCL][L0] Fix use of copy-engines in L0 interop queue (intel#5579) Update OpenCL headers tag to dcd5bed (intel#5575) [SYCL] Fix warning for InOrderQueueSyncCheck unit test build (intel#5577) [SYCL][HIP] Remove arch requirement for running lit tests (intel#5253) [SYCL][L0] Fix timestamp calculation (in ns) (intel#5555) [SYCL] Fix sync of host task vs kernel for in-order queue (intel#5551) [sycl-post-link] Add a check for device globals with device_image_scope (intel#5517) [SYCL] Fix SYCL Kernel Body Check (intel#5546) [SYCL] Add support for SYCL 2020 in class group (intel#5447) Fix tests after 1c729d7 Use align attribute for kernel pointer arg alignment Fix tests after 18834dc Mark pointer-typed kernel arguments as ABI aligned [CI] Add experimental Windows build to GitHub Actions nightly (intel#5560) [sycl-post-link][NFC] Address clang-tidy concerns in the sycl-post-link (intel#5552) Fix lit test after changes in Clang Improve backward compatibility for DISubRange ...
This flag was introduced before all the tests that run code were moved
to the
llvm-test-suiterepository. The tests left in this repositoryare only compiler tests so the offload architecture can simply be
hardcoded as the tests don't depend on what hardware is available.
This simplifies building and running the tests for hip.