From 4adac8b99d5ee14094205da3c46092e597acd948 Mon Sep 17 00:00:00 2001 From: Greg Lueck Date: Thu, 10 Feb 2022 17:05:29 -0500 Subject: [PATCH 1/3] [SYCL][Doc] Move internal design docs Move all the internal design documents to a separate directory. This declutters the "sycl/doc" directory, making it easier to find the end-user documentation. It also moves several documents out of "sycl/doc/extensions" which were not actually extension specifications. We decided that the "sycl/doc/dev" directory should hold BKMs (best known methods) for developers, so rename it accordingly. --- sycl/ReleaseNotes.md | 20 +++++------ sycl/doc/FAQ.md | 4 +-- sycl/doc/GetStartedGuide.md | 6 ++-- sycl/doc/conf.py | 26 ++++++++++++-- .../{ => development-bkms}/ABIPolicyGuide.md | 2 +- .../{dev => development-bkms}/DockerBKMs.md | 0 .../SYCL_EXT_INTEL_ESIMD/README.md | 2 +- .../supported/C-CXX-StandardLibrary.rst | 4 +-- sycl/doc/images/missing_sycl_dll.png | Bin sycl/doc/index.rst | 34 +++++++++--------- sycl/doc/{ => internal-design}/Assert.md | 4 +-- .../CompileTimeProperties.md | 8 ++--- .../CompilerAndRuntimeDesign.md | 2 +- .../doc/{ => internal-design}/DeviceGlobal.md | 6 ++-- .../DeviceLibExtensions.rst | 2 +- .../GlobalObjectsInRuntime.md | 0 .../{ => internal-design}/ITTAnnotations.md | 0 .../KernelParameterPassing.md | 0 .../KernelProgramCache.md | 4 +-- .../LinkedAllocations.md | 0 .../Multi-source-compilation-flow.png | Bin .../OptionalDeviceFeatures.md | 2 +- .../{ => internal-design}/PluginInterface.md | 8 ++--- .../Reduction_status.md | 2 +- .../SYCLInstrumentationUsingXPTI.md | 0 .../SYCLPipesLoweringToSPIRV.rst | 0 .../{ => internal-design}/SharedLibraries.md | 0 .../SpecializationConstants.md | 2 +- .../fpga_io_pipes_design.rst | 2 +- .../images/Compiler-HLD.svg | 0 .../images/DeviceCodeSplit.svg | 0 .../images/DeviceLinkAOTAndWrap.svg | 0 .../images/DeviceLinkAndWrap.svg | 0 .../images/DevicePTXProcessing.svg | 0 .../images/LD-preload-shared-libraries.svg | 0 .../images/ODR-shared-libraries.svg | 0 .../images/PluginDiscovery.svg | 0 .../images/RuntimeArchitecture.svg | 0 .../images/SplitCompileAndLink.svg | 0 .../images/assert-fallback-graph.svg | 0 .../images/plugin-lifetime.jpg | Bin sycl/source/detail/context_impl.hpp | 2 +- .../program_manager/program_manager.hpp | 2 +- sycl/test/abi/pi_level_zero_symbol_check.dump | 2 +- sycl/test/abi/pi_opencl_symbol_check.dump | 2 +- sycl/test/abi/sycl_symbols_linux.dump | 2 +- sycl/test/abi/sycl_symbols_windows.dump | 2 +- sycl/tools/abi_check.py | 6 ++-- 48 files changed, 89 insertions(+), 69 deletions(-) rename sycl/doc/{ => development-bkms}/ABIPolicyGuide.md (99%) rename sycl/doc/{dev => development-bkms}/DockerBKMs.md (100%) mode change 100755 => 100644 sycl/doc/images/missing_sycl_dll.png rename sycl/doc/{ => internal-design}/Assert.md (98%) rename sycl/doc/{ => internal-design}/CompileTimeProperties.md (99%) rename sycl/doc/{ => internal-design}/CompilerAndRuntimeDesign.md (99%) rename sycl/doc/{ => internal-design}/DeviceGlobal.md (99%) rename sycl/doc/{extensions/C-CXX-StandardLibrary => internal-design}/DeviceLibExtensions.rst (99%) rename sycl/doc/{ => internal-design}/GlobalObjectsInRuntime.md (100%) rename sycl/doc/{ => internal-design}/ITTAnnotations.md (100%) rename sycl/doc/{ => internal-design}/KernelParameterPassing.md (100%) mode change 100755 => 100644 rename sycl/doc/{ => internal-design}/KernelProgramCache.md (99%) rename sycl/doc/{ => internal-design}/LinkedAllocations.md (100%) rename sycl/doc/{ => internal-design}/Multi-source-compilation-flow.png (100%) rename sycl/doc/{ => internal-design}/OptionalDeviceFeatures.md (99%) rename sycl/doc/{ => internal-design}/PluginInterface.md (97%) rename sycl/doc/{extensions/Reduction => internal-design}/Reduction_status.md (98%) rename sycl/doc/{ => internal-design}/SYCLInstrumentationUsingXPTI.md (100%) rename sycl/doc/{extensions/DataFlowPipes => internal-design}/SYCLPipesLoweringToSPIRV.rst (100%) rename sycl/doc/{ => internal-design}/SharedLibraries.md (100%) mode change 100755 => 100644 rename sycl/doc/{ => internal-design}/SpecializationConstants.md (99%) rename sycl/doc/{extensions => internal-design}/fpga_io_pipes_design.rst (96%) rename sycl/doc/{ => internal-design}/images/Compiler-HLD.svg (100%) rename sycl/doc/{ => internal-design}/images/DeviceCodeSplit.svg (100%) mode change 100755 => 100644 rename sycl/doc/{ => internal-design}/images/DeviceLinkAOTAndWrap.svg (100%) rename sycl/doc/{ => internal-design}/images/DeviceLinkAndWrap.svg (100%) rename sycl/doc/{ => internal-design}/images/DevicePTXProcessing.svg (100%) rename sycl/doc/{ => internal-design}/images/LD-preload-shared-libraries.svg (100%) mode change 100755 => 100644 rename sycl/doc/{ => internal-design}/images/ODR-shared-libraries.svg (100%) mode change 100755 => 100644 rename sycl/doc/{ => internal-design}/images/PluginDiscovery.svg (100%) rename sycl/doc/{ => internal-design}/images/RuntimeArchitecture.svg (100%) rename sycl/doc/{ => internal-design}/images/SplitCompileAndLink.svg (100%) rename sycl/doc/{ => internal-design}/images/assert-fallback-graph.svg (100%) rename sycl/doc/{ => internal-design}/images/plugin-lifetime.jpg (100%) diff --git a/sycl/ReleaseNotes.md b/sycl/ReleaseNotes.md index b1419b07fd7a9..5780eb3139c2c 100644 --- a/sycl/ReleaseNotes.md +++ b/sycl/ReleaseNotes.md @@ -15,18 +15,18 @@ Release notes for commit range 4fc5ebe..bd68232 - Added support for SYCL 2020 exceptions [5c0f748][eef07606][5af8c43d] - Added support for [SYCL_EXT_INTEL_BF16_CONVERSION extension](doc/extensions/experimental/SYCL_EXT_INTEL_BF16_CONVERSION.asciidoc) [8075463] - - Added support for fallback implementation of [assert feature](doc/Assert.md) + - Added support for fallback implementation of [assert feature](doc/internal-design/Assert.md) [56c9ec4] - Added support SYCL 2020 `sycl::logical_and` and `sycl::logical_or` operators [6c077a0] ### Documentation - - Added design document for [optional kernel features](doc/OptionalDeviceFeatures.md) + - Added design document for [optional kernel features](doc/internal-design/OptionalDeviceFeatures.md) [88cfe16] - Added [SYCL_INTEL_bf16_conversion extension document](doc/extensions/experimental/SYCL_EXT_INTEL_BF16_CONVERSION.asciidoc) [9f8cc3af] - Align [SYCL_EXT_ONEAPI_GROUP_MASK extension](doc/extensions/supported/SYCL_EXT_ONEAPI_SUB_GROUP_MASK.asciidoc) with SYCL 2020 specification [a06bd1fb] - - Added [documentation](doc/SYCLInstrumentationUsingXPTI.md) of XPTI related + - Added [documentation](doc/internal-design/SYCLInstrumentationUsingXPTI.md) of XPTI related tracing in SYCL [1308fe7b] - Align `SYCL_EXT_ONEAPI_LOCAL_MEMORY` extension [document](doc/extensions/supported/SYCL_EXT_ONEAPI_LOCAL_MEMORY.asciidoc) with SYCL 2020 @@ -1104,7 +1104,7 @@ Release notes for commit range c9d50752..5d7e0925 - The SYCL library doesn't guarantee stable API/ABI, so applications compiled with older version of the SYCL library may not work with new one. The workaround is to rebuild the application. - [ABI policy guide](doc/ABIPolicyGuide.md) + [ABI policy guide](doc/development-bkms/ABIPolicyGuide.md) - Using `cl::sycl::program` API to refer to a kernel defined in another translation unit leads to undefined behavior - Linkage errors with the following message: @@ -1243,7 +1243,7 @@ Release notes for commit range 5976ff0..1fc0e4f - The SYCL library doesn't guarantee stable API/ABI, so applications compiled with older version of the SYCL library may not work with new one. The workaround is to rebuild the application. - [ABI policy guide](doc/ABIPolicyGuide.md) + [ABI policy guide](doc/development-bkms/ABIPolicyGuide.md) - Using `cl::sycl::program` API to refer to a kernel defined in another translation unit leads to undefined behavior - Linkage errors with the following message: @@ -1431,7 +1431,7 @@ Release notes for the commit range 75b3dc2..5976ff0 - The SYCL library doesn't guarantee stable API/ABI, so applications compiled with older version of the SYCL library may not work with new one. The workaround is to rebuild the application. - [ABI policy guide](doc/ABIPolicyGuide.md) + [ABI policy guide](doc/development-bkms/ABIPolicyGuide.md) - Using `cl::sycl::program` API to refer to a kernel defined in another translation unit leads to undefined behavior - Linkage errors with the following message: @@ -1585,7 +1585,7 @@ Release notes for the commit range ba404be..24726df - The SYCL library doesn't guarantee stable API/ABI, so applications compiled with older version of the SYCL library may not work with new one. The workaround is to rebuild the application. - [ABI policy guide](doc/ABIPolicyGuide.md) + [ABI policy guide](doc/development-bkms/ABIPolicyGuide.md) - Using `cl::sycl::program` API to refer to a kernel defined in another translation unit leads to undefined behavior - Linkage errors with the following message: @@ -1661,7 +1661,7 @@ Release notes for the commit range ba404be..67d3d9e - Updated prerequisites in GetStartedGuide(doc/GetStartedGuide.md) [5d0d034] - Published a [proposal](doc/extensions/KernelRHSAttributes/SYCL_INTEL_attribute_style.asciidoc) for function-type attributes (right-sided) for kernel attributes [5d5351b] - - The [compiler and runtime design doc](doc/CompilerAndRuntimeDesign.md) has + - The [compiler and runtime design doc](doc/internal-design/CompilerAndRuntimeDesign.md) has been updated to describe the CUDA target and reflect changed action graphs [91b597b] [212a26c] - [ExtendedAtomics documentation](doc/extensions/ExtendedAtomics/README.md) @@ -1673,7 +1673,7 @@ Release notes for the commit range ba404be..67d3d9e - Published [device_specific_kernel_queries](doc/extensions/DeviceSpecificKernelQueries/SYCL_INTEL_device_specific_kernel_queries.asciidoc) extension which rephrases work group queries as device-specific kernel queries [4c07ff8] - - Added more information about the [plugin interface (PI)](doc/PluginInterface.md) + - Added more information about the [plugin interface (PI)](doc/internal-design/PluginInterface.md) [0614e9a] - [Contribution guidelines](../CONTRIBUTING.md) were simplified, now sign-off line is not required [7886fd8] @@ -1736,7 +1736,7 @@ Release notes for the commit range ba404be..67d3d9e - The SYCL library doesn't guarantee stable API/ABI, so applications compiled with older version of the SYCL library may not work with new one. The workaround is to rebuild the application. - [ABI policy guide](doc/ABIPolicyGuide.md) + [ABI policy guide](doc/development-bkms/ABIPolicyGuide.md) - Using `cl::sycl::program` API to refer to a kernel defined in another translation unit leads to undefined behavior - Linkage errors with the following message: diff --git a/sycl/doc/FAQ.md b/sycl/doc/FAQ.md index 3d0bdab941b4a..864deb56ce593 100644 --- a/sycl/doc/FAQ.md +++ b/sycl/doc/FAQ.md @@ -58,7 +58,7 @@ compiler command-line interface in general, please refer to the To learn more about the concepts behind this flow, and the DPC++ Compiler internals as such, we welcome you to study our [DPC++ Compiler and Runtime architecture design]( -CompilerAndRuntimeDesign.md) document. +internal-design/CompilerAndRuntimeDesign.md) document. ## Using applications built with DPC++ @@ -150,7 +150,7 @@ debugging tools of your choice for the host device code. Furthermore, developers can extend capabilities of the DPC++ Runtime to non-OpenCL devices by writing correspondent plugins. To learn more, please -check out our [Plugin Interface Guide](PluginInterface.md). +check out our [Plugin Interface Guide](internal-design/PluginInterface.md). ### Q: DPC++ applications hang on Intel GPUs while working well on other devices **A:** One of the common reasons is Intel GPUs feature called "hang check". diff --git a/sycl/doc/GetStartedGuide.md b/sycl/doc/GetStartedGuide.md index 4d383b1962035..b974415d9fd9f 100644 --- a/sycl/doc/GetStartedGuide.md +++ b/sycl/doc/GetStartedGuide.md @@ -54,7 +54,7 @@ docker run --name sycl_build -it -v /local/workspace/dir/:/src ghcr.io/intel/llv ``` This command will start a terminal session, from which you can proceed with the -instructions below. See [Docker BKMs](dev/DockerBKMs.md) for more info on Docker +instructions below. See [Docker BKMs](development-bkms/DockerBKMs.md) for more info on Docker commands. ### Create DPC++ workspace @@ -434,7 +434,7 @@ command: ### Obtain prerequisites for ahead of time (AOT) compilation -[Ahead of time compilation](CompilerAndRuntimeDesign.md#ahead-of-time-aot-compilation) +[Ahead of time compilation](internal-design/CompilerAndRuntimeDesign.md#ahead-of-time-aot-compilation) requires ahead of time compiler available in `PATH`. There is AOT compiler for each device type: @@ -660,7 +660,7 @@ clang++ -fsycl -fsycl-targets=spir64_gen,spir64_x86_64 simple-sycl-app.cpp -o si Additionally, user can pass specific options of AOT compiler to the DPC++ compiler using ```-Xsycl-target-backend``` option, see -[Device code formats](CompilerAndRuntimeDesign.md#device-code-formats) for +[Device code formats](internal-design/CompilerAndRuntimeDesign.md#device-code-formats) for more. To find available options, execute: ```ocloc compile --help``` for GPU, diff --git a/sycl/doc/conf.py b/sycl/doc/conf.py index c976900bda320..7f35116b543a0 100644 --- a/sycl/doc/conf.py +++ b/sycl/doc/conf.py @@ -46,13 +46,33 @@ # The suffix of source filenames. source_suffix = ['.rst', '.md'] -# Extensions are mostly in asciidoc which has poor support in Sphinx -exclude_patterns = ['extensions/*'] +exclude_patterns = [ + # Extensions are mostly in asciidoc which has poor support in Sphinx. + 'extensions/*', + + # Sphinx complains about syntax errors in these files. + 'internal-design/DeviceLibExtensions.rst', + 'internal-design/SYCLPipesLoweringToSPIRV.rst', + 'internal-design/fpga_io_pipes_design.rst', + 'internal-design/Reduction_status.md' +] suppress_warnings = [ 'misc.highlighting_failure' ] def on_missing_reference(app, env, node, contnode): - new_target = "https://github.com/intel/llvm/tree/sycl/sycl/doc/" + node['reftarget'] + # Get the directory that contains the *source* file of the link. These + # files are always relative to the directory containing "conf.py" + # (/sycl/doc). For example, the file "sycl/doc/internal-design/foo.md" + # will have a directory "internal-design". + refdoc_components = node['refdoc'].split('/') + dirs = '/'.join(refdoc_components[:-1]) + if dirs: dirs += '/' + + # A missing reference usually occurs when the target file of the link is + # not processed by Sphinx. Compensate by creating a link that goes to the + # file's location in the GitHub repo. + new_target = "https://github.com/intel/llvm/tree/sycl/sycl/doc/" + dirs + \ + node['reftarget'] newnode = nodes.reference('', '', internal=False, refuri=new_target) newnode.append(contnode) diff --git a/sycl/doc/ABIPolicyGuide.md b/sycl/doc/development-bkms/ABIPolicyGuide.md similarity index 99% rename from sycl/doc/ABIPolicyGuide.md rename to sycl/doc/development-bkms/ABIPolicyGuide.md index a4212e764a8fb..10de2440d2138 100644 --- a/sycl/doc/ABIPolicyGuide.md +++ b/sycl/doc/development-bkms/ABIPolicyGuide.md @@ -118,4 +118,4 @@ Whenever you need to change the existing ABI, please, follow these steps: 1. If there is a need to add a new field in `sycl::handler` or/and `sycl::detail::CG` classes it can be done without breaking ABI using the approach described in the comment at the beggining of - [cg.hpp](../include/CL/sycl/detail/cg.hpp) + [cg.hpp](../../include/CL/sycl/detail/cg.hpp) diff --git a/sycl/doc/dev/DockerBKMs.md b/sycl/doc/development-bkms/DockerBKMs.md similarity index 100% rename from sycl/doc/dev/DockerBKMs.md rename to sycl/doc/development-bkms/DockerBKMs.md diff --git a/sycl/doc/extensions/experimental/SYCL_EXT_INTEL_ESIMD/README.md b/sycl/doc/extensions/experimental/SYCL_EXT_INTEL_ESIMD/README.md index 7459efdcb02b4..f6a5e46367e25 100644 --- a/sycl/doc/extensions/experimental/SYCL_EXT_INTEL_ESIMD/README.md +++ b/sycl/doc/extensions/experimental/SYCL_EXT_INTEL_ESIMD/README.md @@ -81,7 +81,7 @@ extension. ##### Features not supported with ESIMD extension: - The [C and C++ Standard libraries support](../supported/C-CXX-StandardLibrary.rst) -- The [Device library extensions](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/C-CXX-StandardLibrary/DeviceLibExtensions.rst) +- The [Device library extensions](../../../internal-design/DeviceLibExtensions.rst) - Host device ##### Unsupported standard SYCL APIs: diff --git a/sycl/doc/extensions/supported/C-CXX-StandardLibrary.rst b/sycl/doc/extensions/supported/C-CXX-StandardLibrary.rst index eb8ecf8b026ab..6666eb6bc536b 100644 --- a/sycl/doc/extensions/supported/C-CXX-StandardLibrary.rst +++ b/sycl/doc/extensions/supported/C-CXX-StandardLibrary.rst @@ -238,8 +238,8 @@ Device compiler Device compiler is free to implement these `__devicelib_*` functions. In order to indicate support for a particular set of functions, underlying runtime have to support the corresponding OpenCL (PI) -extension. See ``DeviceLibExtensions.rst`` for a list of supported -functions and corresponding extensions. +extension. See ``../../internal-design/DeviceLibExtensions.rst`` for +a list of supported functions and corresponding extensions. Fallback implementation ======================= diff --git a/sycl/doc/images/missing_sycl_dll.png b/sycl/doc/images/missing_sycl_dll.png old mode 100755 new mode 100644 diff --git a/sycl/doc/index.rst b/sycl/doc/index.rst index 844e0c1c3be7b..12a60c82307c1 100644 --- a/sycl/doc/index.rst +++ b/sycl/doc/index.rst @@ -16,6 +16,7 @@ Using oneAPI DPC++ for Application Development FAQ User API Reference EnvironmentVariables + MultiTileCardWithLevelZero Developing oneAPI DPC++ Compiler -------------------------------- @@ -26,22 +27,20 @@ Developing oneAPI DPC++ Compiler API Reference Clang Documentation Clang API Reference - CompilerAndRuntimeDesign - KernelParameterPassing - PluginInterface - ABIPolicyGuide - SpecializationConstants - KernelProgramCache - GlobalObjectsInRuntime - LinkedAllocations - Assert - SharedLibraries - MultiTileCardWithLevelZero - OptionalDeviceFeatures - SYCLInstrumentationUsingXPTI - ITTAnnotations - DeviceGlobal - CompileTimeProperties + internal-design/CompilerAndRuntimeDesign + internal-design/KernelParameterPassing + internal-design/PluginInterface + internal-design/SpecializationConstants + internal-design/KernelProgramCache + internal-design/GlobalObjectsInRuntime + internal-design/LinkedAllocations + internal-design/Assert + internal-design/SharedLibraries + internal-design/OptionalDeviceFeatures + internal-design/SYCLInstrumentationUsingXPTI + internal-design/ITTAnnotations + internal-design/DeviceGlobal + internal-design/CompileTimeProperties Development BKMs ~~~~~~~~~~~~~~~~ @@ -49,4 +48,5 @@ Development BKMs .. toctree:: :maxdepth: 1 - dev/DockerBKMs + development-bkms/DockerBKMs + development-bkms/ABIPolicyGuide diff --git a/sycl/doc/Assert.md b/sycl/doc/internal-design/Assert.md similarity index 98% rename from sycl/doc/Assert.md rename to sycl/doc/internal-design/Assert.md index b3dd985fc0e28..22d701d0c3268 100644 --- a/sycl/doc/Assert.md +++ b/sycl/doc/internal-design/Assert.md @@ -41,7 +41,7 @@ int main() { In this use-case every work-item with even index along 0 dimension will trigger assertion failure. Assertion failure should trigger a call to `std::abort()` at host as described in -[extension](extensions/Assert/SYCL_INTEL_ASSERT.asciidoc). +[extension](../extensions/supported/SYCL_EXT_ONEAPI_ASSERT.asciidoc). Even though multiple failures of the same or different assertions can happen in multiple work-items, implementation is required to deliver at least one assertion. The assertion failure message is printed to `stderr` by DPCPP @@ -81,7 +81,7 @@ practical cases. ## How it works? `assert(expr)` macro ends up in call to `__devicelib_assert_fail`. This function -is part of [Device library extension](extensions/C-CXX-StandardLibrary/DeviceLibExtensions.rst#cl_intel_devicelib_cassert). +is part of [Device library extension](DeviceLibExtensions.rst#cl_intel_devicelib_cassert). The format of the assert message is unspecified, but it will always include the text of the failing expression, the values of the standard macros `__FILE__` and diff --git a/sycl/doc/CompileTimeProperties.md b/sycl/doc/internal-design/CompileTimeProperties.md similarity index 99% rename from sycl/doc/CompileTimeProperties.md rename to sycl/doc/internal-design/CompileTimeProperties.md index 7a09ca35a454e..e516730e80104 100644 --- a/sycl/doc/CompileTimeProperties.md +++ b/sycl/doc/internal-design/CompileTimeProperties.md @@ -6,7 +6,7 @@ specifying properties which are known at compile time. This extension is not itself a feature, but rather a building block that can be incorporated into other features. -[1]: +[1]: <../extensions/proposed/SYCL_EXT_ONEAPI_PROPERTIES.asciidoc> There are a number of situations where we plan to use compile-time constant properties, but this design document does not attempt to address them all. @@ -40,7 +40,7 @@ One use for compile-time properties is with types that are used exclusively for declaring global variables. One such example is the [SYCL\_EXT\_ONEAPI\_DEVICE\_GLOBAL][2] extension: -[2]: +[2]: <../extensions/proposed/SYCL_EXT_ONEAPI_DEVICE_GLOBAL.asciidoc> ``` namespace sycl::ext::oneapi { @@ -148,7 +148,7 @@ kernel arguments. For example, the [SYCL\_ONEAPI\_accessor\_properties][6] extension could be redesigned to use compile-time properties. Such a redesign might look like: -[6]: +[6]: <../extensions/supported/SYCL_EXT_ONEAPI_ACCESSOR_PROPERTIES.asciidoc> ``` namespace sycl { @@ -274,7 +274,7 @@ the [SYCL\_EXT\_ONEAPI\_PROPERTIES][8] extension. There are two ways the application can specify these properties. The first is by passing a `property_list` parameter to the function that submits the kernel: -[8]: +[8]: <../extensions/proposed/SYCL_EXT_ONEAPI_PROPERTIES.asciidoc> ``` namespace sycl { diff --git a/sycl/doc/CompilerAndRuntimeDesign.md b/sycl/doc/internal-design/CompilerAndRuntimeDesign.md similarity index 99% rename from sycl/doc/CompilerAndRuntimeDesign.md rename to sycl/doc/internal-design/CompilerAndRuntimeDesign.md index 5971d3fb80f38..7ae691ed92f90 100644 --- a/sycl/doc/CompilerAndRuntimeDesign.md +++ b/sycl/doc/internal-design/CompilerAndRuntimeDesign.md @@ -951,4 +951,4 @@ with any other address space (including default). ## DPC++ Language extensions to SYCL -List of language extensions can be found at [extensions](extensions) +List of language extensions can be found at [extensions](../extensions) diff --git a/sycl/doc/DeviceGlobal.md b/sycl/doc/internal-design/DeviceGlobal.md similarity index 99% rename from sycl/doc/DeviceGlobal.md rename to sycl/doc/internal-design/DeviceGlobal.md index 3d3f1a7baf4f8..81638e401e3d6 100644 --- a/sycl/doc/DeviceGlobal.md +++ b/sycl/doc/internal-design/DeviceGlobal.md @@ -4,7 +4,7 @@ This document describes the implementation design for the DPC++ extension [SYCL\_EXT\_ONEAPI\_DEVICE\_GLOBAL][1], which allows applications to declare global variables in device code. -[1]: +[1]: <../extensions/proposed/SYCL_EXT_ONEAPI_DEVICE_GLOBAL.asciidoc> ## Requirements @@ -403,7 +403,7 @@ has the `implement_in_csr` property). See the [SPV\_INTEL\_global\_variable\_decorations][6] SPIR-V extension for details about all of these decorations. -[6]: +[6]: <../extensions/DeviceGlobal/SPV_INTEL_global_variable_decorations.asciidoc> The `sycl-post-link` tool also create a "SYCL/device globals" property set for each device code module that contains at least one device global variable. @@ -614,7 +614,7 @@ The OpenCL backend has a proposed extension which can be easily used to implement these PI interfaces. This DPC++ design depends upon implementation of that OpenCL extension. -[10]: +[10]: <../extensions/DeviceGlobal/cl_intel_global_variable_access.asciidoc> The CUDA backend has existing APIs `cudaMemcpyToSymbol()` and `cudaMemcpyFromSymbol()` which can be used to implement these PI interfaces. diff --git a/sycl/doc/extensions/C-CXX-StandardLibrary/DeviceLibExtensions.rst b/sycl/doc/internal-design/DeviceLibExtensions.rst similarity index 99% rename from sycl/doc/extensions/C-CXX-StandardLibrary/DeviceLibExtensions.rst rename to sycl/doc/internal-design/DeviceLibExtensions.rst index 500aab981c39e..97c233a5b49c0 100644 --- a/sycl/doc/extensions/C-CXX-StandardLibrary/DeviceLibExtensions.rst +++ b/sycl/doc/internal-design/DeviceLibExtensions.rst @@ -48,7 +48,7 @@ Invoking `__devicelib_assert_read` after a kernel doesn't imply the kernel has assertion failed. See also: assert_extension_. -.. _assert_extension: ../supported/SYCL_EXT_ONEAPI_ASSERT.asciidoc) +.. _assert_extension: ../extensions/supported/SYCL_EXT_ONEAPI_ASSERT.asciidoc) cl_intel_devicelib_math ========================== diff --git a/sycl/doc/GlobalObjectsInRuntime.md b/sycl/doc/internal-design/GlobalObjectsInRuntime.md similarity index 100% rename from sycl/doc/GlobalObjectsInRuntime.md rename to sycl/doc/internal-design/GlobalObjectsInRuntime.md diff --git a/sycl/doc/ITTAnnotations.md b/sycl/doc/internal-design/ITTAnnotations.md similarity index 100% rename from sycl/doc/ITTAnnotations.md rename to sycl/doc/internal-design/ITTAnnotations.md diff --git a/sycl/doc/KernelParameterPassing.md b/sycl/doc/internal-design/KernelParameterPassing.md old mode 100755 new mode 100644 similarity index 100% rename from sycl/doc/KernelParameterPassing.md rename to sycl/doc/internal-design/KernelParameterPassing.md diff --git a/sycl/doc/KernelProgramCache.md b/sycl/doc/internal-design/KernelProgramCache.md similarity index 99% rename from sycl/doc/KernelProgramCache.md rename to sycl/doc/internal-design/KernelProgramCache.md index f0799f624c16f..e84f17361b828 100644 --- a/sycl/doc/KernelProgramCache.md +++ b/sycl/doc/internal-design/KernelProgramCache.md @@ -184,7 +184,7 @@ three sources of build options: ## Cache configuration The environment variables which affect cache behavior are described in -[EnvironmentVariables.md](https://github.com/intel/llvm/blob/sycl/sycl/doc/EnvironmentVariables.md). +[EnvironmentVariables.md](../EnvironmentVariables.md). ## Implementation details @@ -343,7 +343,7 @@ The device code image are stored on file system using structure below: - `` - root directory storing cache files, that depends on environment variables (see SYCL_CACHE_DIR description in the - [EnvironmentVariables.md](EnvironmentVariables.md)); + [EnvironmentVariables.md](../EnvironmentVariables.md)); - `` - hash out of device information used to identify target device; - `` - hash made out of device image used as input for the diff --git a/sycl/doc/LinkedAllocations.md b/sycl/doc/internal-design/LinkedAllocations.md similarity index 100% rename from sycl/doc/LinkedAllocations.md rename to sycl/doc/internal-design/LinkedAllocations.md diff --git a/sycl/doc/Multi-source-compilation-flow.png b/sycl/doc/internal-design/Multi-source-compilation-flow.png similarity index 100% rename from sycl/doc/Multi-source-compilation-flow.png rename to sycl/doc/internal-design/Multi-source-compilation-flow.png diff --git a/sycl/doc/OptionalDeviceFeatures.md b/sycl/doc/internal-design/OptionalDeviceFeatures.md similarity index 99% rename from sycl/doc/OptionalDeviceFeatures.md rename to sycl/doc/internal-design/OptionalDeviceFeatures.md index da7b1003a832f..787d2bb9994ce 100644 --- a/sycl/doc/OptionalDeviceFeatures.md +++ b/sycl/doc/internal-design/OptionalDeviceFeatures.md @@ -266,7 +266,7 @@ non-FPGA users may want to use the `device_global` property [`device_image_scope`][5], which requires even non-FPGA users to have precise control over the way kernels are bundled into device images. -[5]: +[5]: <../extensions/proposed/SYCL_EXT_ONEAPI_DEVICE_GLOBAL.asciidoc#properties-for-device-global-variables> The new definition of `-fsycl-device-code-split` is as follows: diff --git a/sycl/doc/PluginInterface.md b/sycl/doc/internal-design/PluginInterface.md similarity index 97% rename from sycl/doc/PluginInterface.md rename to sycl/doc/internal-design/PluginInterface.md index e1781081e0159..769475794b344 100644 --- a/sycl/doc/PluginInterface.md +++ b/sycl/doc/internal-design/PluginInterface.md @@ -72,9 +72,9 @@ SYCL_PI_TRACE=-1 lists all PI Traces above and more debug messages. #### Plugin binary interface Plugins should implement all the Interface APIs required for the PI Version -it supports. There is [pi.def](../include/CL/sycl/detail/pi.def)/ -[pi.h](../include/CL/sycl/detail/pi.h) file listing all PI API names that can be -called by the specific version of Plugin Interface. +it supports. There is [pi.def](../../include/CL/sycl/detail/pi.def)/ +[pi.h](../../include/CL/sycl/detail/pi.h) file listing all PI API names that +can be called by the specific version of Plugin Interface. It exports a function - "piPluginInit" that returns the plugin details and function pointer table containing the list of pointers to implemented Interface Functions defined in pi.h. @@ -149,7 +149,7 @@ into - **Interoperability API** which allows interoperability with underlying runtimes such as OpenCL. -See [pi.h](../include/CL/sycl/detail/pi.h) header for the full list and +See [pi.h](../../include/CL/sycl/detail/pi.h) header for the full list and descriptions of PI APIs. ### The Core OpenCL-based PI APIs diff --git a/sycl/doc/extensions/Reduction/Reduction_status.md b/sycl/doc/internal-design/Reduction_status.md similarity index 98% rename from sycl/doc/extensions/Reduction/Reduction_status.md rename to sycl/doc/internal-design/Reduction_status.md index 03efb8a23232e..9b0b8b46c3f1a 100644 --- a/sycl/doc/extensions/Reduction/Reduction_status.md +++ b/sycl/doc/internal-design/Reduction_status.md @@ -8,7 +8,7 @@ There are 2 specifications of the reduction feature and both are still actual: -* `sycl::ext::oneapi::reduction` is described in [this document](../deprecated/SYCL_EXT_ONEAPI_ND_RANGE_REDUCTIONS.md). This extension is deprecated, and was created as part of a pathfinding/prototyping work before it was added to SYCL 2020 standard. +* `sycl::ext::oneapi::reduction` is described in [this document](../extensions/deprecated/SYCL_EXT_ONEAPI_ND_RANGE_REDUCTIONS.md). This extension is deprecated, and was created as part of a pathfinding/prototyping work before it was added to SYCL 2020 standard. * `sycl::reduction` is described in [SYCL 2020 standard](https://www.khronos.org/registry/SYCL/specs/sycl-2020/html/sycl-2020.html#sec:reduction). diff --git a/sycl/doc/SYCLInstrumentationUsingXPTI.md b/sycl/doc/internal-design/SYCLInstrumentationUsingXPTI.md similarity index 100% rename from sycl/doc/SYCLInstrumentationUsingXPTI.md rename to sycl/doc/internal-design/SYCLInstrumentationUsingXPTI.md diff --git a/sycl/doc/extensions/DataFlowPipes/SYCLPipesLoweringToSPIRV.rst b/sycl/doc/internal-design/SYCLPipesLoweringToSPIRV.rst similarity index 100% rename from sycl/doc/extensions/DataFlowPipes/SYCLPipesLoweringToSPIRV.rst rename to sycl/doc/internal-design/SYCLPipesLoweringToSPIRV.rst diff --git a/sycl/doc/SharedLibraries.md b/sycl/doc/internal-design/SharedLibraries.md old mode 100755 new mode 100644 similarity index 100% rename from sycl/doc/SharedLibraries.md rename to sycl/doc/internal-design/SharedLibraries.md diff --git a/sycl/doc/SpecializationConstants.md b/sycl/doc/internal-design/SpecializationConstants.md similarity index 99% rename from sycl/doc/SpecializationConstants.md rename to sycl/doc/internal-design/SpecializationConstants.md index 9fdd9fd067f57..795abf57557c6 100644 --- a/sycl/doc/SpecializationConstants.md +++ b/sycl/doc/internal-design/SpecializationConstants.md @@ -1,7 +1,7 @@ # Specialization constants DPC++ implements this [proposal](https://github.com/codeplaysoftware/standards-proposals/blob/master/spec-constant/index.md) -with some restrictions. See this [document](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/SpecConstants/README.md) for more details. +with some restrictions. See this [document](../extensions/experimental/SYCL_EXT_ONEAPI_SPEC_CONSTANTS.md) for more details. ## Requirements: diff --git a/sycl/doc/extensions/fpga_io_pipes_design.rst b/sycl/doc/internal-design/fpga_io_pipes_design.rst similarity index 96% rename from sycl/doc/extensions/fpga_io_pipes_design.rst rename to sycl/doc/internal-design/fpga_io_pipes_design.rst index d562eeb44896e..264061c516e98 100644 --- a/sycl/doc/extensions/fpga_io_pipes_design.rst +++ b/sycl/doc/internal-design/fpga_io_pipes_design.rst @@ -22,7 +22,7 @@ Requirements Links ----- -.. _Spec: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/supported/SYCL_EXT_INTEL_DATAFLOW_PIPES.asciidoc +.. _Spec: ../extensions/supported/SYCL_EXT_INTEL_DATAFLOW_PIPES.asciidoc .. _Interesting comment from Ronan: https://github.com/intel/llvm/pull/635#discussion_r325851766 Summary diff --git a/sycl/doc/images/Compiler-HLD.svg b/sycl/doc/internal-design/images/Compiler-HLD.svg similarity index 100% rename from sycl/doc/images/Compiler-HLD.svg rename to sycl/doc/internal-design/images/Compiler-HLD.svg diff --git a/sycl/doc/images/DeviceCodeSplit.svg b/sycl/doc/internal-design/images/DeviceCodeSplit.svg old mode 100755 new mode 100644 similarity index 100% rename from sycl/doc/images/DeviceCodeSplit.svg rename to sycl/doc/internal-design/images/DeviceCodeSplit.svg diff --git a/sycl/doc/images/DeviceLinkAOTAndWrap.svg b/sycl/doc/internal-design/images/DeviceLinkAOTAndWrap.svg similarity index 100% rename from sycl/doc/images/DeviceLinkAOTAndWrap.svg rename to sycl/doc/internal-design/images/DeviceLinkAOTAndWrap.svg diff --git a/sycl/doc/images/DeviceLinkAndWrap.svg b/sycl/doc/internal-design/images/DeviceLinkAndWrap.svg similarity index 100% rename from sycl/doc/images/DeviceLinkAndWrap.svg rename to sycl/doc/internal-design/images/DeviceLinkAndWrap.svg diff --git a/sycl/doc/images/DevicePTXProcessing.svg b/sycl/doc/internal-design/images/DevicePTXProcessing.svg similarity index 100% rename from sycl/doc/images/DevicePTXProcessing.svg rename to sycl/doc/internal-design/images/DevicePTXProcessing.svg diff --git a/sycl/doc/images/LD-preload-shared-libraries.svg b/sycl/doc/internal-design/images/LD-preload-shared-libraries.svg old mode 100755 new mode 100644 similarity index 100% rename from sycl/doc/images/LD-preload-shared-libraries.svg rename to sycl/doc/internal-design/images/LD-preload-shared-libraries.svg diff --git a/sycl/doc/images/ODR-shared-libraries.svg b/sycl/doc/internal-design/images/ODR-shared-libraries.svg old mode 100755 new mode 100644 similarity index 100% rename from sycl/doc/images/ODR-shared-libraries.svg rename to sycl/doc/internal-design/images/ODR-shared-libraries.svg diff --git a/sycl/doc/images/PluginDiscovery.svg b/sycl/doc/internal-design/images/PluginDiscovery.svg similarity index 100% rename from sycl/doc/images/PluginDiscovery.svg rename to sycl/doc/internal-design/images/PluginDiscovery.svg diff --git a/sycl/doc/images/RuntimeArchitecture.svg b/sycl/doc/internal-design/images/RuntimeArchitecture.svg similarity index 100% rename from sycl/doc/images/RuntimeArchitecture.svg rename to sycl/doc/internal-design/images/RuntimeArchitecture.svg diff --git a/sycl/doc/images/SplitCompileAndLink.svg b/sycl/doc/internal-design/images/SplitCompileAndLink.svg similarity index 100% rename from sycl/doc/images/SplitCompileAndLink.svg rename to sycl/doc/internal-design/images/SplitCompileAndLink.svg diff --git a/sycl/doc/images/assert-fallback-graph.svg b/sycl/doc/internal-design/images/assert-fallback-graph.svg similarity index 100% rename from sycl/doc/images/assert-fallback-graph.svg rename to sycl/doc/internal-design/images/assert-fallback-graph.svg diff --git a/sycl/doc/images/plugin-lifetime.jpg b/sycl/doc/internal-design/images/plugin-lifetime.jpg similarity index 100% rename from sycl/doc/images/plugin-lifetime.jpg rename to sycl/doc/internal-design/images/plugin-lifetime.jpg diff --git a/sycl/source/detail/context_impl.hpp b/sycl/source/detail/context_impl.hpp index 722d2c0789d03..abbbaa37c13fc 100644 --- a/sycl/source/detail/context_impl.hpp +++ b/sycl/source/detail/context_impl.hpp @@ -148,7 +148,7 @@ class context_impl { /// cl_intel_devicelib_complex -> # /// etc. /// - /// See `doc/extensions/C-CXX-StandardLibrary/DeviceLibExtensions.rst' for + /// See `doc/internal-design/DeviceLibExtensions.rst' for /// more details. /// /// \returns a map with device library programs. diff --git a/sycl/source/detail/program_manager/program_manager.hpp b/sycl/source/detail/program_manager/program_manager.hpp index fbcc3bd8cb448..df2c0ff994575 100644 --- a/sycl/source/detail/program_manager/program_manager.hpp +++ b/sycl/source/detail/program_manager/program_manager.hpp @@ -46,7 +46,7 @@ class context; namespace detail { // This value must be the same as in libdevice/device_itt.h. -// See sycl/doc/extensions/ITTAnnotations/ITTAnnotations.rst for more info. +// See sycl/doc/internal-design/ITTAnnotations.md for more info. static constexpr uint32_t inline ITTSpecConstId = 0xFF747469; class context_impl; diff --git a/sycl/test/abi/pi_level_zero_symbol_check.dump b/sycl/test/abi/pi_level_zero_symbol_check.dump index fd8e328cba540..a499c00d3e8cb 100644 --- a/sycl/test/abi/pi_level_zero_symbol_check.dump +++ b/sycl/test/abi/pi_level_zero_symbol_check.dump @@ -1,6 +1,6 @@ ################################################################################ # This file is automatically generated by abi_check.py tool. -# DO NOT EDIT IT MANUALLY. Refer to sycl/docs/ABIPolicyGuide.md for more info. +# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for more info. ################################################################################ # RUN: env LLVM_BIN_PATH=%llvm_build_bin_dir python %sycl_tools_src_dir/abi_check.py --mode check_symbols --reference %s %sycl_libs_dir/libpi_level_zero.so diff --git a/sycl/test/abi/pi_opencl_symbol_check.dump b/sycl/test/abi/pi_opencl_symbol_check.dump index caf4f72b48adb..a2ce0c9d571f6 100644 --- a/sycl/test/abi/pi_opencl_symbol_check.dump +++ b/sycl/test/abi/pi_opencl_symbol_check.dump @@ -1,6 +1,6 @@ ################################################################################ # This file is automatically generated by abi_check.py tool. -# DO NOT EDIT IT MANUALLY. Refer to sycl/docs/ABIPolicyGuide.md for more info. +# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for more info. ################################################################################ # RUN: env LLVM_BIN_PATH=%llvm_build_bin_dir python %sycl_tools_src_dir/abi_check.py --mode check_symbols --reference %s %sycl_libs_dir/libpi_opencl.so diff --git a/sycl/test/abi/sycl_symbols_linux.dump b/sycl/test/abi/sycl_symbols_linux.dump index 2681453647fb6..0e3f73450f091 100644 --- a/sycl/test/abi/sycl_symbols_linux.dump +++ b/sycl/test/abi/sycl_symbols_linux.dump @@ -1,6 +1,6 @@ ################################################################################ # This file is automatically generated by abi_check.py tool. -# DO NOT EDIT IT MANUALLY. Refer to sycl/docs/ABIPolicyGuide.md for more info. +# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for more info. ################################################################################ # RUN: env LLVM_BIN_PATH=%llvm_build_bin_dir python %sycl_tools_src_dir/abi_check.py --mode check_symbols --reference %s %sycl_libs_dir/libsycl.so diff --git a/sycl/test/abi/sycl_symbols_windows.dump b/sycl/test/abi/sycl_symbols_windows.dump index 2359db7857240..1367ba000281d 100644 --- a/sycl/test/abi/sycl_symbols_windows.dump +++ b/sycl/test/abi/sycl_symbols_windows.dump @@ -1,6 +1,6 @@ ################################################################################ # This file is automatically generated by abi_check.py tool. -# DO NOT EDIT IT MANUALLY. Refer to sycl/docs/ABIPolicyGuide.md for more info. +# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for more info. ################################################################################ # RUN: env LLVM_BIN_PATH=%llvm_build_bin_dir python %sycl_tools_src_dir/abi_check.py --mode check_symbols --reference %s %llvm_build_bin_dir/sycl.dll diff --git a/sycl/tools/abi_check.py b/sycl/tools/abi_check.py index 2ed9fdb363202..d473af84baf0b 100644 --- a/sycl/tools/abi_check.py +++ b/sycl/tools/abi_check.py @@ -58,7 +58,7 @@ def dump_symbols(target_path, output): with open(output, "w") as out: out.write("################################################################################") out.write("\n# This file is automatically generated by abi_check.py tool.") - out.write("\n# DO NOT EDIT IT MANUALLY. Refer to sycl/docs/ABIPolicyGuide.md for more info.") + out.write("\n# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for more info.") out.write("\n################################################################################") out.write("\n\n# RUN: env LLVM_BIN_PATH=%llvm_build_bin_dir python") out.write(" %sycl_tools_src_dir/abi_check.py --mode check_symbols") @@ -109,7 +109,7 @@ def check_symbols(ref_path, target_path): if missing_symbols: correct_return = False print(("There are missing symbols in the new library. It is a breaking " - "change. Refer to sycl/doc/ABIPolicyGuide.md for further instructions. " + "change. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for further instructions. " "Do not forget to update ABI version according to the policy.")) print('The following symbols are missing from the new object file:\n') print("\n".join(missing_symbols)) @@ -117,7 +117,7 @@ def check_symbols(ref_path, target_path): if new_symbols: correct_return = False print(("There are new symbols in the new library. It is a non-breaking " - "change. Refer to sycl/doc/ABIPolicyGuide.md for further instructions.")) + "change. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for further instructions.")) print('The following symbols are new to the object file:\n') print("\n".join(new_symbols)) From b00236cb4ca9286225e3626ff2854a4b16123d5c Mon Sep 17 00:00:00 2001 From: Greg Lueck Date: Tue, 15 Feb 2022 09:22:03 -0500 Subject: [PATCH 2/3] Rename doc subdirectories Rename these two subdirectories based on review feedback. --- sycl/ReleaseNotes.md | 20 +++++------ sycl/doc/FAQ.md | 4 +-- sycl/doc/GetStartedGuide.md | 6 ++-- sycl/doc/conf.py | 12 +++---- .../doc/{internal-design => design}/Assert.md | 0 .../CompileTimeProperties.md | 0 .../CompilerAndRuntimeDesign.md | 0 .../DeviceGlobal.md | 0 .../DeviceLibExtensions.rst | 0 .../GlobalObjectsInRuntime.md | 0 .../ITTAnnotations.md | 0 .../KernelParameterPassing.md | 0 .../KernelProgramCache.md | 0 .../LinkedAllocations.md | 0 .../Multi-source-compilation-flow.png | Bin .../OptionalDeviceFeatures.md | 0 .../PluginInterface.md | 0 .../Reduction_status.md | 0 .../SYCLInstrumentationUsingXPTI.md | 0 .../SYCLPipesLoweringToSPIRV.rst | 0 .../SharedLibraries.md | 0 .../SpecializationConstants.md | 0 .../fpga_io_pipes_design.rst | 0 .../images/Compiler-HLD.svg | 0 .../images/DeviceCodeSplit.svg | 0 .../images/DeviceLinkAOTAndWrap.svg | 0 .../images/DeviceLinkAndWrap.svg | 0 .../images/DevicePTXProcessing.svg | 0 .../images/LD-preload-shared-libraries.svg | 0 .../images/ODR-shared-libraries.svg | 0 .../images/PluginDiscovery.svg | 0 .../images/RuntimeArchitecture.svg | 0 .../images/SplitCompileAndLink.svg | 0 .../images/assert-fallback-graph.svg | 0 .../images/plugin-lifetime.jpg | Bin .../ABIPolicyGuide.md | 0 .../DockerBKMs.md | 0 .../SYCL_EXT_INTEL_ESIMD/README.md | 2 +- .../supported/C-CXX-StandardLibrary.rst | 2 +- sycl/doc/index.rst | 32 +++++++++--------- sycl/source/detail/context_impl.hpp | 2 +- .../program_manager/program_manager.hpp | 2 +- sycl/test/abi/pi_level_zero_symbol_check.dump | 2 +- sycl/test/abi/pi_opencl_symbol_check.dump | 2 +- sycl/test/abi/sycl_symbols_linux.dump | 2 +- sycl/test/abi/sycl_symbols_windows.dump | 2 +- sycl/tools/abi_check.py | 6 ++-- 47 files changed, 48 insertions(+), 48 deletions(-) rename sycl/doc/{internal-design => design}/Assert.md (100%) rename sycl/doc/{internal-design => design}/CompileTimeProperties.md (100%) rename sycl/doc/{internal-design => design}/CompilerAndRuntimeDesign.md (100%) rename sycl/doc/{internal-design => design}/DeviceGlobal.md (100%) rename sycl/doc/{internal-design => design}/DeviceLibExtensions.rst (100%) rename sycl/doc/{internal-design => design}/GlobalObjectsInRuntime.md (100%) rename sycl/doc/{internal-design => design}/ITTAnnotations.md (100%) rename sycl/doc/{internal-design => design}/KernelParameterPassing.md (100%) rename sycl/doc/{internal-design => design}/KernelProgramCache.md (100%) rename sycl/doc/{internal-design => design}/LinkedAllocations.md (100%) rename sycl/doc/{internal-design => design}/Multi-source-compilation-flow.png (100%) rename sycl/doc/{internal-design => design}/OptionalDeviceFeatures.md (100%) rename sycl/doc/{internal-design => design}/PluginInterface.md (100%) rename sycl/doc/{internal-design => design}/Reduction_status.md (100%) rename sycl/doc/{internal-design => design}/SYCLInstrumentationUsingXPTI.md (100%) rename sycl/doc/{internal-design => design}/SYCLPipesLoweringToSPIRV.rst (100%) rename sycl/doc/{internal-design => design}/SharedLibraries.md (100%) rename sycl/doc/{internal-design => design}/SpecializationConstants.md (100%) rename sycl/doc/{internal-design => design}/fpga_io_pipes_design.rst (100%) rename sycl/doc/{internal-design => design}/images/Compiler-HLD.svg (100%) rename sycl/doc/{internal-design => design}/images/DeviceCodeSplit.svg (100%) rename sycl/doc/{internal-design => design}/images/DeviceLinkAOTAndWrap.svg (100%) rename sycl/doc/{internal-design => design}/images/DeviceLinkAndWrap.svg (100%) rename sycl/doc/{internal-design => design}/images/DevicePTXProcessing.svg (100%) rename sycl/doc/{internal-design => design}/images/LD-preload-shared-libraries.svg (100%) rename sycl/doc/{internal-design => design}/images/ODR-shared-libraries.svg (100%) rename sycl/doc/{internal-design => design}/images/PluginDiscovery.svg (100%) rename sycl/doc/{internal-design => design}/images/RuntimeArchitecture.svg (100%) rename sycl/doc/{internal-design => design}/images/SplitCompileAndLink.svg (100%) rename sycl/doc/{internal-design => design}/images/assert-fallback-graph.svg (100%) rename sycl/doc/{internal-design => design}/images/plugin-lifetime.jpg (100%) rename sycl/doc/{development-bkms => developer}/ABIPolicyGuide.md (100%) rename sycl/doc/{development-bkms => developer}/DockerBKMs.md (100%) diff --git a/sycl/ReleaseNotes.md b/sycl/ReleaseNotes.md index 5780eb3139c2c..edd4211b33531 100644 --- a/sycl/ReleaseNotes.md +++ b/sycl/ReleaseNotes.md @@ -15,18 +15,18 @@ Release notes for commit range 4fc5ebe..bd68232 - Added support for SYCL 2020 exceptions [5c0f748][eef07606][5af8c43d] - Added support for [SYCL_EXT_INTEL_BF16_CONVERSION extension](doc/extensions/experimental/SYCL_EXT_INTEL_BF16_CONVERSION.asciidoc) [8075463] - - Added support for fallback implementation of [assert feature](doc/internal-design/Assert.md) + - Added support for fallback implementation of [assert feature](doc/design/Assert.md) [56c9ec4] - Added support SYCL 2020 `sycl::logical_and` and `sycl::logical_or` operators [6c077a0] ### Documentation - - Added design document for [optional kernel features](doc/internal-design/OptionalDeviceFeatures.md) + - Added design document for [optional kernel features](doc/design/OptionalDeviceFeatures.md) [88cfe16] - Added [SYCL_INTEL_bf16_conversion extension document](doc/extensions/experimental/SYCL_EXT_INTEL_BF16_CONVERSION.asciidoc) [9f8cc3af] - Align [SYCL_EXT_ONEAPI_GROUP_MASK extension](doc/extensions/supported/SYCL_EXT_ONEAPI_SUB_GROUP_MASK.asciidoc) with SYCL 2020 specification [a06bd1fb] - - Added [documentation](doc/internal-design/SYCLInstrumentationUsingXPTI.md) of XPTI related + - Added [documentation](doc/design/SYCLInstrumentationUsingXPTI.md) of XPTI related tracing in SYCL [1308fe7b] - Align `SYCL_EXT_ONEAPI_LOCAL_MEMORY` extension [document](doc/extensions/supported/SYCL_EXT_ONEAPI_LOCAL_MEMORY.asciidoc) with SYCL 2020 @@ -1104,7 +1104,7 @@ Release notes for commit range c9d50752..5d7e0925 - The SYCL library doesn't guarantee stable API/ABI, so applications compiled with older version of the SYCL library may not work with new one. The workaround is to rebuild the application. - [ABI policy guide](doc/development-bkms/ABIPolicyGuide.md) + [ABI policy guide](doc/developer/ABIPolicyGuide.md) - Using `cl::sycl::program` API to refer to a kernel defined in another translation unit leads to undefined behavior - Linkage errors with the following message: @@ -1243,7 +1243,7 @@ Release notes for commit range 5976ff0..1fc0e4f - The SYCL library doesn't guarantee stable API/ABI, so applications compiled with older version of the SYCL library may not work with new one. The workaround is to rebuild the application. - [ABI policy guide](doc/development-bkms/ABIPolicyGuide.md) + [ABI policy guide](doc/developer/ABIPolicyGuide.md) - Using `cl::sycl::program` API to refer to a kernel defined in another translation unit leads to undefined behavior - Linkage errors with the following message: @@ -1431,7 +1431,7 @@ Release notes for the commit range 75b3dc2..5976ff0 - The SYCL library doesn't guarantee stable API/ABI, so applications compiled with older version of the SYCL library may not work with new one. The workaround is to rebuild the application. - [ABI policy guide](doc/development-bkms/ABIPolicyGuide.md) + [ABI policy guide](doc/developer/ABIPolicyGuide.md) - Using `cl::sycl::program` API to refer to a kernel defined in another translation unit leads to undefined behavior - Linkage errors with the following message: @@ -1585,7 +1585,7 @@ Release notes for the commit range ba404be..24726df - The SYCL library doesn't guarantee stable API/ABI, so applications compiled with older version of the SYCL library may not work with new one. The workaround is to rebuild the application. - [ABI policy guide](doc/development-bkms/ABIPolicyGuide.md) + [ABI policy guide](doc/developer/ABIPolicyGuide.md) - Using `cl::sycl::program` API to refer to a kernel defined in another translation unit leads to undefined behavior - Linkage errors with the following message: @@ -1661,7 +1661,7 @@ Release notes for the commit range ba404be..67d3d9e - Updated prerequisites in GetStartedGuide(doc/GetStartedGuide.md) [5d0d034] - Published a [proposal](doc/extensions/KernelRHSAttributes/SYCL_INTEL_attribute_style.asciidoc) for function-type attributes (right-sided) for kernel attributes [5d5351b] - - The [compiler and runtime design doc](doc/internal-design/CompilerAndRuntimeDesign.md) has + - The [compiler and runtime design doc](doc/design/CompilerAndRuntimeDesign.md) has been updated to describe the CUDA target and reflect changed action graphs [91b597b] [212a26c] - [ExtendedAtomics documentation](doc/extensions/ExtendedAtomics/README.md) @@ -1673,7 +1673,7 @@ Release notes for the commit range ba404be..67d3d9e - Published [device_specific_kernel_queries](doc/extensions/DeviceSpecificKernelQueries/SYCL_INTEL_device_specific_kernel_queries.asciidoc) extension which rephrases work group queries as device-specific kernel queries [4c07ff8] - - Added more information about the [plugin interface (PI)](doc/internal-design/PluginInterface.md) + - Added more information about the [plugin interface (PI)](doc/design/PluginInterface.md) [0614e9a] - [Contribution guidelines](../CONTRIBUTING.md) were simplified, now sign-off line is not required [7886fd8] @@ -1736,7 +1736,7 @@ Release notes for the commit range ba404be..67d3d9e - The SYCL library doesn't guarantee stable API/ABI, so applications compiled with older version of the SYCL library may not work with new one. The workaround is to rebuild the application. - [ABI policy guide](doc/development-bkms/ABIPolicyGuide.md) + [ABI policy guide](doc/developer/ABIPolicyGuide.md) - Using `cl::sycl::program` API to refer to a kernel defined in another translation unit leads to undefined behavior - Linkage errors with the following message: diff --git a/sycl/doc/FAQ.md b/sycl/doc/FAQ.md index 864deb56ce593..5032533d75a60 100644 --- a/sycl/doc/FAQ.md +++ b/sycl/doc/FAQ.md @@ -58,7 +58,7 @@ compiler command-line interface in general, please refer to the To learn more about the concepts behind this flow, and the DPC++ Compiler internals as such, we welcome you to study our [DPC++ Compiler and Runtime architecture design]( -internal-design/CompilerAndRuntimeDesign.md) document. +design/CompilerAndRuntimeDesign.md) document. ## Using applications built with DPC++ @@ -150,7 +150,7 @@ debugging tools of your choice for the host device code. Furthermore, developers can extend capabilities of the DPC++ Runtime to non-OpenCL devices by writing correspondent plugins. To learn more, please -check out our [Plugin Interface Guide](internal-design/PluginInterface.md). +check out our [Plugin Interface Guide](design/PluginInterface.md). ### Q: DPC++ applications hang on Intel GPUs while working well on other devices **A:** One of the common reasons is Intel GPUs feature called "hang check". diff --git a/sycl/doc/GetStartedGuide.md b/sycl/doc/GetStartedGuide.md index b974415d9fd9f..1cadc62e25e3e 100644 --- a/sycl/doc/GetStartedGuide.md +++ b/sycl/doc/GetStartedGuide.md @@ -54,7 +54,7 @@ docker run --name sycl_build -it -v /local/workspace/dir/:/src ghcr.io/intel/llv ``` This command will start a terminal session, from which you can proceed with the -instructions below. See [Docker BKMs](development-bkms/DockerBKMs.md) for more info on Docker +instructions below. See [Docker BKMs](developer/DockerBKMs.md) for more info on Docker commands. ### Create DPC++ workspace @@ -434,7 +434,7 @@ command: ### Obtain prerequisites for ahead of time (AOT) compilation -[Ahead of time compilation](internal-design/CompilerAndRuntimeDesign.md#ahead-of-time-aot-compilation) +[Ahead of time compilation](design/CompilerAndRuntimeDesign.md#ahead-of-time-aot-compilation) requires ahead of time compiler available in `PATH`. There is AOT compiler for each device type: @@ -660,7 +660,7 @@ clang++ -fsycl -fsycl-targets=spir64_gen,spir64_x86_64 simple-sycl-app.cpp -o si Additionally, user can pass specific options of AOT compiler to the DPC++ compiler using ```-Xsycl-target-backend``` option, see -[Device code formats](internal-design/CompilerAndRuntimeDesign.md#device-code-formats) for +[Device code formats](design/CompilerAndRuntimeDesign.md#device-code-formats) for more. To find available options, execute: ```ocloc compile --help``` for GPU, diff --git a/sycl/doc/conf.py b/sycl/doc/conf.py index 7f35116b543a0..5aa9c9efece98 100644 --- a/sycl/doc/conf.py +++ b/sycl/doc/conf.py @@ -51,10 +51,10 @@ 'extensions/*', # Sphinx complains about syntax errors in these files. - 'internal-design/DeviceLibExtensions.rst', - 'internal-design/SYCLPipesLoweringToSPIRV.rst', - 'internal-design/fpga_io_pipes_design.rst', - 'internal-design/Reduction_status.md' + 'design/DeviceLibExtensions.rst', + 'design/SYCLPipesLoweringToSPIRV.rst', + 'design/fpga_io_pipes_design.rst', + 'design/Reduction_status.md' ] suppress_warnings = [ 'misc.highlighting_failure' ] @@ -62,8 +62,8 @@ def on_missing_reference(app, env, node, contnode): # Get the directory that contains the *source* file of the link. These # files are always relative to the directory containing "conf.py" - # (/sycl/doc). For example, the file "sycl/doc/internal-design/foo.md" - # will have a directory "internal-design". + # (/sycl/doc). For example, the file "sycl/doc/design/foo.md" will + # have a directory "design". refdoc_components = node['refdoc'].split('/') dirs = '/'.join(refdoc_components[:-1]) if dirs: dirs += '/' diff --git a/sycl/doc/internal-design/Assert.md b/sycl/doc/design/Assert.md similarity index 100% rename from sycl/doc/internal-design/Assert.md rename to sycl/doc/design/Assert.md diff --git a/sycl/doc/internal-design/CompileTimeProperties.md b/sycl/doc/design/CompileTimeProperties.md similarity index 100% rename from sycl/doc/internal-design/CompileTimeProperties.md rename to sycl/doc/design/CompileTimeProperties.md diff --git a/sycl/doc/internal-design/CompilerAndRuntimeDesign.md b/sycl/doc/design/CompilerAndRuntimeDesign.md similarity index 100% rename from sycl/doc/internal-design/CompilerAndRuntimeDesign.md rename to sycl/doc/design/CompilerAndRuntimeDesign.md diff --git a/sycl/doc/internal-design/DeviceGlobal.md b/sycl/doc/design/DeviceGlobal.md similarity index 100% rename from sycl/doc/internal-design/DeviceGlobal.md rename to sycl/doc/design/DeviceGlobal.md diff --git a/sycl/doc/internal-design/DeviceLibExtensions.rst b/sycl/doc/design/DeviceLibExtensions.rst similarity index 100% rename from sycl/doc/internal-design/DeviceLibExtensions.rst rename to sycl/doc/design/DeviceLibExtensions.rst diff --git a/sycl/doc/internal-design/GlobalObjectsInRuntime.md b/sycl/doc/design/GlobalObjectsInRuntime.md similarity index 100% rename from sycl/doc/internal-design/GlobalObjectsInRuntime.md rename to sycl/doc/design/GlobalObjectsInRuntime.md diff --git a/sycl/doc/internal-design/ITTAnnotations.md b/sycl/doc/design/ITTAnnotations.md similarity index 100% rename from sycl/doc/internal-design/ITTAnnotations.md rename to sycl/doc/design/ITTAnnotations.md diff --git a/sycl/doc/internal-design/KernelParameterPassing.md b/sycl/doc/design/KernelParameterPassing.md similarity index 100% rename from sycl/doc/internal-design/KernelParameterPassing.md rename to sycl/doc/design/KernelParameterPassing.md diff --git a/sycl/doc/internal-design/KernelProgramCache.md b/sycl/doc/design/KernelProgramCache.md similarity index 100% rename from sycl/doc/internal-design/KernelProgramCache.md rename to sycl/doc/design/KernelProgramCache.md diff --git a/sycl/doc/internal-design/LinkedAllocations.md b/sycl/doc/design/LinkedAllocations.md similarity index 100% rename from sycl/doc/internal-design/LinkedAllocations.md rename to sycl/doc/design/LinkedAllocations.md diff --git a/sycl/doc/internal-design/Multi-source-compilation-flow.png b/sycl/doc/design/Multi-source-compilation-flow.png similarity index 100% rename from sycl/doc/internal-design/Multi-source-compilation-flow.png rename to sycl/doc/design/Multi-source-compilation-flow.png diff --git a/sycl/doc/internal-design/OptionalDeviceFeatures.md b/sycl/doc/design/OptionalDeviceFeatures.md similarity index 100% rename from sycl/doc/internal-design/OptionalDeviceFeatures.md rename to sycl/doc/design/OptionalDeviceFeatures.md diff --git a/sycl/doc/internal-design/PluginInterface.md b/sycl/doc/design/PluginInterface.md similarity index 100% rename from sycl/doc/internal-design/PluginInterface.md rename to sycl/doc/design/PluginInterface.md diff --git a/sycl/doc/internal-design/Reduction_status.md b/sycl/doc/design/Reduction_status.md similarity index 100% rename from sycl/doc/internal-design/Reduction_status.md rename to sycl/doc/design/Reduction_status.md diff --git a/sycl/doc/internal-design/SYCLInstrumentationUsingXPTI.md b/sycl/doc/design/SYCLInstrumentationUsingXPTI.md similarity index 100% rename from sycl/doc/internal-design/SYCLInstrumentationUsingXPTI.md rename to sycl/doc/design/SYCLInstrumentationUsingXPTI.md diff --git a/sycl/doc/internal-design/SYCLPipesLoweringToSPIRV.rst b/sycl/doc/design/SYCLPipesLoweringToSPIRV.rst similarity index 100% rename from sycl/doc/internal-design/SYCLPipesLoweringToSPIRV.rst rename to sycl/doc/design/SYCLPipesLoweringToSPIRV.rst diff --git a/sycl/doc/internal-design/SharedLibraries.md b/sycl/doc/design/SharedLibraries.md similarity index 100% rename from sycl/doc/internal-design/SharedLibraries.md rename to sycl/doc/design/SharedLibraries.md diff --git a/sycl/doc/internal-design/SpecializationConstants.md b/sycl/doc/design/SpecializationConstants.md similarity index 100% rename from sycl/doc/internal-design/SpecializationConstants.md rename to sycl/doc/design/SpecializationConstants.md diff --git a/sycl/doc/internal-design/fpga_io_pipes_design.rst b/sycl/doc/design/fpga_io_pipes_design.rst similarity index 100% rename from sycl/doc/internal-design/fpga_io_pipes_design.rst rename to sycl/doc/design/fpga_io_pipes_design.rst diff --git a/sycl/doc/internal-design/images/Compiler-HLD.svg b/sycl/doc/design/images/Compiler-HLD.svg similarity index 100% rename from sycl/doc/internal-design/images/Compiler-HLD.svg rename to sycl/doc/design/images/Compiler-HLD.svg diff --git a/sycl/doc/internal-design/images/DeviceCodeSplit.svg b/sycl/doc/design/images/DeviceCodeSplit.svg similarity index 100% rename from sycl/doc/internal-design/images/DeviceCodeSplit.svg rename to sycl/doc/design/images/DeviceCodeSplit.svg diff --git a/sycl/doc/internal-design/images/DeviceLinkAOTAndWrap.svg b/sycl/doc/design/images/DeviceLinkAOTAndWrap.svg similarity index 100% rename from sycl/doc/internal-design/images/DeviceLinkAOTAndWrap.svg rename to sycl/doc/design/images/DeviceLinkAOTAndWrap.svg diff --git a/sycl/doc/internal-design/images/DeviceLinkAndWrap.svg b/sycl/doc/design/images/DeviceLinkAndWrap.svg similarity index 100% rename from sycl/doc/internal-design/images/DeviceLinkAndWrap.svg rename to sycl/doc/design/images/DeviceLinkAndWrap.svg diff --git a/sycl/doc/internal-design/images/DevicePTXProcessing.svg b/sycl/doc/design/images/DevicePTXProcessing.svg similarity index 100% rename from sycl/doc/internal-design/images/DevicePTXProcessing.svg rename to sycl/doc/design/images/DevicePTXProcessing.svg diff --git a/sycl/doc/internal-design/images/LD-preload-shared-libraries.svg b/sycl/doc/design/images/LD-preload-shared-libraries.svg similarity index 100% rename from sycl/doc/internal-design/images/LD-preload-shared-libraries.svg rename to sycl/doc/design/images/LD-preload-shared-libraries.svg diff --git a/sycl/doc/internal-design/images/ODR-shared-libraries.svg b/sycl/doc/design/images/ODR-shared-libraries.svg similarity index 100% rename from sycl/doc/internal-design/images/ODR-shared-libraries.svg rename to sycl/doc/design/images/ODR-shared-libraries.svg diff --git a/sycl/doc/internal-design/images/PluginDiscovery.svg b/sycl/doc/design/images/PluginDiscovery.svg similarity index 100% rename from sycl/doc/internal-design/images/PluginDiscovery.svg rename to sycl/doc/design/images/PluginDiscovery.svg diff --git a/sycl/doc/internal-design/images/RuntimeArchitecture.svg b/sycl/doc/design/images/RuntimeArchitecture.svg similarity index 100% rename from sycl/doc/internal-design/images/RuntimeArchitecture.svg rename to sycl/doc/design/images/RuntimeArchitecture.svg diff --git a/sycl/doc/internal-design/images/SplitCompileAndLink.svg b/sycl/doc/design/images/SplitCompileAndLink.svg similarity index 100% rename from sycl/doc/internal-design/images/SplitCompileAndLink.svg rename to sycl/doc/design/images/SplitCompileAndLink.svg diff --git a/sycl/doc/internal-design/images/assert-fallback-graph.svg b/sycl/doc/design/images/assert-fallback-graph.svg similarity index 100% rename from sycl/doc/internal-design/images/assert-fallback-graph.svg rename to sycl/doc/design/images/assert-fallback-graph.svg diff --git a/sycl/doc/internal-design/images/plugin-lifetime.jpg b/sycl/doc/design/images/plugin-lifetime.jpg similarity index 100% rename from sycl/doc/internal-design/images/plugin-lifetime.jpg rename to sycl/doc/design/images/plugin-lifetime.jpg diff --git a/sycl/doc/development-bkms/ABIPolicyGuide.md b/sycl/doc/developer/ABIPolicyGuide.md similarity index 100% rename from sycl/doc/development-bkms/ABIPolicyGuide.md rename to sycl/doc/developer/ABIPolicyGuide.md diff --git a/sycl/doc/development-bkms/DockerBKMs.md b/sycl/doc/developer/DockerBKMs.md similarity index 100% rename from sycl/doc/development-bkms/DockerBKMs.md rename to sycl/doc/developer/DockerBKMs.md diff --git a/sycl/doc/extensions/experimental/SYCL_EXT_INTEL_ESIMD/README.md b/sycl/doc/extensions/experimental/SYCL_EXT_INTEL_ESIMD/README.md index f6a5e46367e25..20704107f9e07 100644 --- a/sycl/doc/extensions/experimental/SYCL_EXT_INTEL_ESIMD/README.md +++ b/sycl/doc/extensions/experimental/SYCL_EXT_INTEL_ESIMD/README.md @@ -81,7 +81,7 @@ extension. ##### Features not supported with ESIMD extension: - The [C and C++ Standard libraries support](../supported/C-CXX-StandardLibrary.rst) -- The [Device library extensions](../../../internal-design/DeviceLibExtensions.rst) +- The [Device library extensions](../../../design/DeviceLibExtensions.rst) - Host device ##### Unsupported standard SYCL APIs: diff --git a/sycl/doc/extensions/supported/C-CXX-StandardLibrary.rst b/sycl/doc/extensions/supported/C-CXX-StandardLibrary.rst index 6666eb6bc536b..92dc61b785117 100644 --- a/sycl/doc/extensions/supported/C-CXX-StandardLibrary.rst +++ b/sycl/doc/extensions/supported/C-CXX-StandardLibrary.rst @@ -238,7 +238,7 @@ Device compiler Device compiler is free to implement these `__devicelib_*` functions. In order to indicate support for a particular set of functions, underlying runtime have to support the corresponding OpenCL (PI) -extension. See ``../../internal-design/DeviceLibExtensions.rst`` for +extension. See ``../../design/DeviceLibExtensions.rst`` for a list of supported functions and corresponding extensions. Fallback implementation diff --git a/sycl/doc/index.rst b/sycl/doc/index.rst index 12a60c82307c1..e8a707adbac11 100644 --- a/sycl/doc/index.rst +++ b/sycl/doc/index.rst @@ -27,20 +27,20 @@ Developing oneAPI DPC++ Compiler API Reference Clang Documentation Clang API Reference - internal-design/CompilerAndRuntimeDesign - internal-design/KernelParameterPassing - internal-design/PluginInterface - internal-design/SpecializationConstants - internal-design/KernelProgramCache - internal-design/GlobalObjectsInRuntime - internal-design/LinkedAllocations - internal-design/Assert - internal-design/SharedLibraries - internal-design/OptionalDeviceFeatures - internal-design/SYCLInstrumentationUsingXPTI - internal-design/ITTAnnotations - internal-design/DeviceGlobal - internal-design/CompileTimeProperties + design/CompilerAndRuntimeDesign + design/KernelParameterPassing + design/PluginInterface + design/SpecializationConstants + design/KernelProgramCache + design/GlobalObjectsInRuntime + design/LinkedAllocations + design/Assert + design/SharedLibraries + design/OptionalDeviceFeatures + design/SYCLInstrumentationUsingXPTI + design/ITTAnnotations + design/DeviceGlobal + design/CompileTimeProperties Development BKMs ~~~~~~~~~~~~~~~~ @@ -48,5 +48,5 @@ Development BKMs .. toctree:: :maxdepth: 1 - development-bkms/DockerBKMs - development-bkms/ABIPolicyGuide + developer/DockerBKMs + developer/ABIPolicyGuide diff --git a/sycl/source/detail/context_impl.hpp b/sycl/source/detail/context_impl.hpp index abbbaa37c13fc..d1a52181e9d33 100644 --- a/sycl/source/detail/context_impl.hpp +++ b/sycl/source/detail/context_impl.hpp @@ -148,7 +148,7 @@ class context_impl { /// cl_intel_devicelib_complex -> # /// etc. /// - /// See `doc/internal-design/DeviceLibExtensions.rst' for + /// See `doc/design/DeviceLibExtensions.rst' for /// more details. /// /// \returns a map with device library programs. diff --git a/sycl/source/detail/program_manager/program_manager.hpp b/sycl/source/detail/program_manager/program_manager.hpp index df2c0ff994575..d4aeea252bef2 100644 --- a/sycl/source/detail/program_manager/program_manager.hpp +++ b/sycl/source/detail/program_manager/program_manager.hpp @@ -46,7 +46,7 @@ class context; namespace detail { // This value must be the same as in libdevice/device_itt.h. -// See sycl/doc/internal-design/ITTAnnotations.md for more info. +// See sycl/doc/design/ITTAnnotations.md for more info. static constexpr uint32_t inline ITTSpecConstId = 0xFF747469; class context_impl; diff --git a/sycl/test/abi/pi_level_zero_symbol_check.dump b/sycl/test/abi/pi_level_zero_symbol_check.dump index a499c00d3e8cb..491eb9d87f155 100644 --- a/sycl/test/abi/pi_level_zero_symbol_check.dump +++ b/sycl/test/abi/pi_level_zero_symbol_check.dump @@ -1,6 +1,6 @@ ################################################################################ # This file is automatically generated by abi_check.py tool. -# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for more info. +# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/developer/ABIPolicyGuide.md for more info. ################################################################################ # RUN: env LLVM_BIN_PATH=%llvm_build_bin_dir python %sycl_tools_src_dir/abi_check.py --mode check_symbols --reference %s %sycl_libs_dir/libpi_level_zero.so diff --git a/sycl/test/abi/pi_opencl_symbol_check.dump b/sycl/test/abi/pi_opencl_symbol_check.dump index a2ce0c9d571f6..0e6aaa9dfa7a5 100644 --- a/sycl/test/abi/pi_opencl_symbol_check.dump +++ b/sycl/test/abi/pi_opencl_symbol_check.dump @@ -1,6 +1,6 @@ ################################################################################ # This file is automatically generated by abi_check.py tool. -# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for more info. +# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/developer/ABIPolicyGuide.md for more info. ################################################################################ # RUN: env LLVM_BIN_PATH=%llvm_build_bin_dir python %sycl_tools_src_dir/abi_check.py --mode check_symbols --reference %s %sycl_libs_dir/libpi_opencl.so diff --git a/sycl/test/abi/sycl_symbols_linux.dump b/sycl/test/abi/sycl_symbols_linux.dump index 0e3f73450f091..79d58722b4f4f 100644 --- a/sycl/test/abi/sycl_symbols_linux.dump +++ b/sycl/test/abi/sycl_symbols_linux.dump @@ -1,6 +1,6 @@ ################################################################################ # This file is automatically generated by abi_check.py tool. -# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for more info. +# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/developer/ABIPolicyGuide.md for more info. ################################################################################ # RUN: env LLVM_BIN_PATH=%llvm_build_bin_dir python %sycl_tools_src_dir/abi_check.py --mode check_symbols --reference %s %sycl_libs_dir/libsycl.so diff --git a/sycl/test/abi/sycl_symbols_windows.dump b/sycl/test/abi/sycl_symbols_windows.dump index 1367ba000281d..e6bb784eca0d8 100644 --- a/sycl/test/abi/sycl_symbols_windows.dump +++ b/sycl/test/abi/sycl_symbols_windows.dump @@ -1,6 +1,6 @@ ################################################################################ # This file is automatically generated by abi_check.py tool. -# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for more info. +# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/developer/ABIPolicyGuide.md for more info. ################################################################################ # RUN: env LLVM_BIN_PATH=%llvm_build_bin_dir python %sycl_tools_src_dir/abi_check.py --mode check_symbols --reference %s %llvm_build_bin_dir/sycl.dll diff --git a/sycl/tools/abi_check.py b/sycl/tools/abi_check.py index d473af84baf0b..960d7340bebee 100644 --- a/sycl/tools/abi_check.py +++ b/sycl/tools/abi_check.py @@ -58,7 +58,7 @@ def dump_symbols(target_path, output): with open(output, "w") as out: out.write("################################################################################") out.write("\n# This file is automatically generated by abi_check.py tool.") - out.write("\n# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for more info.") + out.write("\n# DO NOT EDIT IT MANUALLY. Refer to sycl/doc/developer/ABIPolicyGuide.md for more info.") out.write("\n################################################################################") out.write("\n\n# RUN: env LLVM_BIN_PATH=%llvm_build_bin_dir python") out.write(" %sycl_tools_src_dir/abi_check.py --mode check_symbols") @@ -109,7 +109,7 @@ def check_symbols(ref_path, target_path): if missing_symbols: correct_return = False print(("There are missing symbols in the new library. It is a breaking " - "change. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for further instructions. " + "change. Refer to sycl/doc/developer/ABIPolicyGuide.md for further instructions. " "Do not forget to update ABI version according to the policy.")) print('The following symbols are missing from the new object file:\n') print("\n".join(missing_symbols)) @@ -117,7 +117,7 @@ def check_symbols(ref_path, target_path): if new_symbols: correct_return = False print(("There are new symbols in the new library. It is a non-breaking " - "change. Refer to sycl/doc/development-bkms/ABIPolicyGuide.md for further instructions.")) + "change. Refer to sycl/doc/developer/ABIPolicyGuide.md for further instructions.")) print('The following symbols are new to the object file:\n') print("\n".join(new_symbols)) From 429f2daa7341fb73367f4b1778ad14e7a35d57eb Mon Sep 17 00:00:00 2001 From: Greg Lueck Date: Tue, 15 Feb 2022 09:37:57 -0500 Subject: [PATCH 3/3] Update titles in Sphinx documentation --- sycl/doc/index.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sycl/doc/index.rst b/sycl/doc/index.rst index e8a707adbac11..e38281e1e9f18 100644 --- a/sycl/doc/index.rst +++ b/sycl/doc/index.rst @@ -18,8 +18,8 @@ Using oneAPI DPC++ for Application Development EnvironmentVariables MultiTileCardWithLevelZero -Developing oneAPI DPC++ Compiler --------------------------------- +Design Documents for the oneAPI DPC++ Compiler +---------------------------------------------- .. toctree:: :maxdepth: 1 @@ -42,8 +42,8 @@ Developing oneAPI DPC++ Compiler design/DeviceGlobal design/CompileTimeProperties -Development BKMs -~~~~~~~~~~~~~~~~ +Developer Documentation +~~~~~~~~~~~~~~~~~~~~~~~ .. toctree:: :maxdepth: 1