[SYCL][CUDA][PI] Improve performance of piQueueFinish #6201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could your improvement be migrated directly to the HIP plugin interface ? |
|
This could be migrated to HIP plugin once it also uses multiple streams. |
|
@smaslov-intel - Would you like to have a look or should we merge this? |
steffenlarsen
pushed a commit
that referenced
this pull request
Jun 21, 2022
Fixed off-by-one error introduced in #6201 that would cause queue synchronization to synchronize all streams when no stream has been used. The code worked correctly, but this can in some cases impact performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance of
piQueueFinishand therefore ofqueue::wait()on CUDA backend by reducing the number ofcuStreamSynchronize()calls invoked. This in most use cases fixes the slowdown toqueue::wait()introduced in #6102.This does not change any interface so there are no changes to the test suite.