[SYCL][L0] Optimize barrier for in-order queue #9446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@againull , @jandres742 : please review |
jandres742
reviewed
May 15, 2023
jandres742
reviewed
May 15, 2023
jandres742
approved these changes
May 16, 2023
againull
reviewed
May 16, 2023
againull
reviewed
May 19, 2023
againull
approved these changes
May 19, 2023
Comment on lines
+5855
to
+5787
| ZE_CALL( | ||
| zeCommandListAppendWaitOnEvents, | ||
| (CmdList->first, EventWaitList.Length, EventWaitList.ZeEventList)); | ||
| } | ||
| ZE_CALL(zeCommandListAppendSignalEvent, (CmdList->first, Event->ZeEvent)); |
There was a problem hiding this comment.
Looks good to me but it would be nice to get confirmation from @jandres742 here that it's going to work as expected - i.e. Event->ZeEvent is signaled only after we waited for all events in EventWaitList.ZeEventList.
There was a problem hiding this comment.
Event->ZeEvent is signaled only after we waited for all events in EventWaitList.ZeEventList.
correct. if it doesnt work, then that would be a bug, but currently this works and is stable.
There was a problem hiding this comment.
@jandres742 Thanks a lot for confirming!
jandres742
approved these changes
May 19, 2023
Signed-off-by: smaslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
smaslov-intel
force-pushed
the
inorder_barrier
branch
from
e265061 to
a845355
Compare
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 23, 2023
intel#9446 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 26, 2023
intel#9446 Signed-off-by: Jaime Arteaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.