Skip to content

Commit 7f392ff

Browse files
committed
Change webhook settings to match the changes from kubernetes-sigs/controller-runtime#2422
1 parent 6ba8a67 commit 7f392ff

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

api/v1alpha1/webhook_suite_test.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import (
3232
"k8s.io/apimachinery/pkg/types"
3333
"k8s.io/client-go/kubernetes/scheme"
3434
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
35+
"sigs.k8s.io/controller-runtime/pkg/webhook"
3536

3637
// +kubebuilder:scaffold:imports
3738

@@ -95,13 +96,15 @@ var _ = BeforeSuite(func() {
9596
// start webhook server using Manager
9697
webhookInstallOptions := &testEnv.WebhookInstallOptions
9798
mgr, err := ctrl.NewManager(cfg, ctrl.Options{
98-
Scheme: scheme.Scheme,
99-
Host: webhookInstallOptions.LocalServingHost,
100-
Port: webhookInstallOptions.LocalServingPort,
101-
CertDir: webhookInstallOptions.LocalServingCertDir,
99+
Scheme: scheme.Scheme,
100+
WebhookServer: webhook.NewServer(webhook.Options{
101+
Port: webhookInstallOptions.LocalServingPort,
102+
Host: webhookInstallOptions.LocalServingHost,
103+
CertDir: webhookInstallOptions.LocalServingCertDir,
104+
}),
102105
LeaderElection: false,
103106
Metrics: metricsserver.Options{
104-
BindAddress: 0,
107+
BindAddress: "0",
105108
},
106109
})
107110
Expect(err).NotTo(HaveOccurred())

main.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import (
3030
ctrl "sigs.k8s.io/controller-runtime"
3131
"sigs.k8s.io/controller-runtime/pkg/healthz"
3232
"sigs.k8s.io/controller-runtime/pkg/log/zap"
33+
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
3334

3435
ipamv1alpha1 "github.com/onmetal/ipam/api/v1alpha1"
3536
"github.com/onmetal/ipam/controllers"
@@ -66,9 +67,10 @@ func main() {
6667
ctrl.SetLogger(zap.New(zap.UseFlagOptions(&opts)))
6768

6869
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
69-
Scheme: scheme,
70-
MetricsBindAddress: metricsAddr,
71-
Port: 9443,
70+
Scheme: scheme,
71+
Metrics: metricsserver.Options{
72+
BindAddress: metricsAddr,
73+
},
7274
HealthProbeBindAddress: probeAddr,
7375
LeaderElection: enableLeaderElection,
7476
LeaderElectionID: "f42c18d5.onmetal.de",

0 commit comments

Comments
 (0)