Remove redundant extern keywords from function declarations/definitions. (#1495)

Extern keywords on function declarations/definitions provide no additional value since function declarations/definitions default to external linkage in C99, e.g. removing them won't change the semantics of the program.

The extern keywords were essentially a legacy from the early days of the project. This commit cleans this up across the whole codebase in one go to minimize history disruption.

The bulk of the changes in this commit were produced by a custom clang-tidy checker.

Note that variables declarations carrying the extern keyword are untouched by this commit since there the presence of the keyword actually has an impact on the semantics of the program.

JerryScript-DCO-1.0-Signed-off-by: Tilmann Scheller [email protected]

Author: Tilmann Scheller

jerry-core/ecma/base/ecma-alloc.h

@@ -30,108 +30,108 @@
  *
  * @return pointer to allocated memory
  */
-extern ecma_object_t *ecma_alloc_object (void);
+ecma_object_t *ecma_alloc_object (void);
 
 /**
  * Dealloc memory from an ecma-object
  */
-extern void ecma_dealloc_object (ecma_object_t *);
+void ecma_dealloc_object (ecma_object_t *);
 
 /**
  * Allocate memory for ecma-number
  *
  * @return pointer to allocated memory
  */
-extern ecma_number_t *ecma_alloc_number (void);
+ecma_number_t *ecma_alloc_number (void);
 
 /**
  * Dealloc memory from an ecma-number
  */
-extern void ecma_dealloc_number (ecma_number_t *);
+void ecma_dealloc_number (ecma_number_t *);
 
 /**
  * Allocate memory for header of a collection
  *
  * @return pointer to allocated memory
  */
-extern ecma_collection_header_t *ecma_alloc_collection_header (void);
+ecma_collection_header_t *ecma_alloc_collection_header (void);
 
 /**
  * Dealloc memory from the collection's header
  */
-extern void ecma_dealloc_collection_header (ecma_collection_header_t *);
+void ecma_dealloc_collection_header (ecma_collection_header_t *);
 
 /**
  * Allocate memory for non-first chunk of a collection
  *
  * @return pointer to allocated memory
  */
-extern ecma_collection_chunk_t *ecma_alloc_collection_chunk (void);
+ecma_collection_chunk_t *ecma_alloc_collection_chunk (void);
 
 /**
  * Dealloc memory from non-first chunk of a collection
  */
-extern void ecma_dealloc_collection_chunk (ecma_collection_chunk_t *);
+void ecma_dealloc_collection_chunk (ecma_collection_chunk_t *);
 
 /**
  * Allocate memory for ecma-string descriptor
  *
  * @return pointer to allocated memory
  */
-extern ecma_string_t *ecma_alloc_string (void);
+ecma_string_t *ecma_alloc_string (void);
 
 /**
  * Dealloc memory from ecma-string descriptor
  */
-extern void ecma_dealloc_string (ecma_string_t *);
+void ecma_dealloc_string (ecma_string_t *);
 
 /**
  * Allocate memory for getter-setter pointer pair
  *
  * @return pointer to allocated memory
  */
-extern ecma_getter_setter_pointers_t *ecma_alloc_getter_setter_pointers (void);
+ecma_getter_setter_pointers_t *ecma_alloc_getter_setter_pointers (void);
 
 /**
  * Dealloc memory from getter-setter pointer pair
  */
-extern void ecma_dealloc_getter_setter_pointers (ecma_getter_setter_pointers_t *);
+void ecma_dealloc_getter_setter_pointers (ecma_getter_setter_pointers_t *);
 
 /**
 * Allocate memory for external pointer
 *
 * @return pointer to allocated memory
 */
-extern ecma_external_pointer_t *ecma_alloc_external_pointer (void);
+ecma_external_pointer_t *ecma_alloc_external_pointer (void);
 
 /**
 * Dealloc memory from external pointer
 */
-extern void ecma_dealloc_external_pointer (ecma_external_pointer_t *);
+void ecma_dealloc_external_pointer (ecma_external_pointer_t *);
 
 /*
  * Allocate memory for extended object
  *
  * @return pointer to allocated memory
  */
-extern ecma_extended_object_t *ecma_alloc_extended_object (size_t);
+ecma_extended_object_t *ecma_alloc_extended_object (size_t);
 
 /**
  * Dealloc memory of an extended object
  */
-extern void ecma_dealloc_extended_object (ecma_extended_object_t *, size_t);
+void ecma_dealloc_extended_object (ecma_extended_object_t *, size_t);
 
 /**
  * Allocate memory for ecma-property pair
  *
  * @return pointer to allocated memory
  */
-extern ecma_property_pair_t *ecma_alloc_property_pair (void);
+ecma_property_pair_t *ecma_alloc_property_pair (void);
 
 /**
  * Dealloc memory from an ecma-property pair
  */
-extern void ecma_dealloc_property_pair (ecma_property_pair_t *);
+void ecma_dealloc_property_pair (ecma_property_pair_t *);
 
 /**
  * @}

jerry-core/ecma/base/ecma-gc.h

@@ -26,11 +26,11 @@
  * @{
  */
 
-extern void ecma_init_gc_info (ecma_object_t *);
-extern void ecma_ref_object (ecma_object_t *);
-extern void ecma_deref_object (ecma_object_t *);
-extern void ecma_gc_run (jmem_free_unused_memory_severity_t);
-extern void ecma_free_unused_memory (jmem_free_unused_memory_severity_t);
+void ecma_init_gc_info (ecma_object_t *);
+void ecma_ref_object (ecma_object_t *);
+void ecma_deref_object (ecma_object_t *);
+void ecma_gc_run (jmem_free_unused_memory_severity_t);
+void ecma_free_unused_memory (jmem_free_unused_memory_severity_t);
 
 /**
  * @}