Skip to content

Commit 393d693

Browse files
ruben-ayrapetyanegavrin
authored andcommitted
Introduce 'USE_COMPILER_DEFAULT_LIBC' for switching from jerry-libc to a libc, provided by compiler.
JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
1 parent 6d86c4b commit 393d693

File tree

2 files changed

+29
-13
lines changed

2 files changed

+29
-13
lines changed

CMakeLists.txt

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,13 @@ project (Jerry CXX C ASM)
9292
set(MCU_SCRIPT_GENERATED_HEADER ${CMAKE_BINARY_DIR}/generated.h)
9393

9494
# Should we use external libc?
95-
if(NOT DEFINED EXTERNAL_LIBC_INTERFACE OR EXTERNAL_LIBC_INTERFACE STREQUAL "UNDEFINED")
95+
if(DEFINED USE_COMPILER_DEFAULT_LIBC AND USE_COMPILER_DEFAULT_LIBC STREQUAL "YES")
96+
if(NOT EXTERNAL_LIBC_INTERFACE STREQUAL "" AND NOT EXTERNAL_LIBC_INTERFACE STREQUAL "UNDEFINED")
97+
message(FATAL_ERROR "EXTERNAL_LIBC_INTERFACE='${EXTERNAL_LIBC_INTERFACE}' should not be set in case compiler's default libc is used (USE_COMPILER_DEFAULT_LIBC=YES)")
98+
endif()
99+
100+
set(USE_JERRY_LIBC FALSE)
101+
elseif(NOT DEFINED EXTERNAL_LIBC_INTERFACE OR EXTERNAL_LIBC_INTERFACE STREQUAL "UNDEFINED")
96102
set(USE_JERRY_LIBC TRUE)
97103
else()
98104
set(USE_JERRY_LIBC FALSE)
@@ -180,6 +186,11 @@ project (Jerry CXX C ASM)
180186
set(COMPILE_FLAGS_JERRY "-fno-builtin")
181187
set(LINKER_FLAGS_COMMON "-Wl,-z,noexecstack")
182188

189+
# Turn off linking to compiler's default libc, in case jerry-libc is used
190+
if(${USE_JERRY_LIBC})
191+
set(LINKER_FLAGS_COMMON "${LINKER_FLAGS_COMMON} -nostdlib")
192+
endif()
193+
183194
# LTO
184195
if("${ENABLE_LTO}" STREQUAL "ON")
185196
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -flto -fno-fat-lto-objects")
@@ -219,13 +230,13 @@ project (Jerry CXX C ASM)
219230
set(LINKER_FLAGS_COMMON_MCU_STM32F4 "-T${CMAKE_SOURCE_DIR}/third-party/STM32F4-Discovery_FW_V1.1.0/Project/Peripheral_Examples/FLASH_Program/TrueSTUDIO/FLASH_Program/stm32_flash.ld")
220231

221232
# Debug
222-
set(FLAGS_COMMON_DEBUG "-nostdlib")
233+
set(FLAGS_COMMON_DEBUG "")
223234

224235
# Release
225-
set(FLAGS_COMMON_RELEASE "-Os -nostdlib")
236+
set(FLAGS_COMMON_RELEASE "-Os")
226237

227238
# Unit tests
228-
set(FLAGS_COMMON_UNITTESTS "-O3 -nostdlib")
239+
set(FLAGS_COMMON_UNITTESTS "-O3")
229240

230241
# Include directories
231242
# Core interface
@@ -249,13 +260,6 @@ project (Jerry CXX C ASM)
249260
file(GLOB SOURCE_UNIT_TEST_MAIN_MODULES tests/unit/*.cpp)
250261

251262
# Imported libraries
252-
# libc
253-
add_library(${PREFIX_IMPORTED_LIB}libc SHARED IMPORTED)
254-
execute_process(COMMAND ${CMAKE_C_COMPILER} ${FLAGS_COMMON_ARCH} -print-file-name=libc.so
255-
OUTPUT_VARIABLE IMPORTED_LIBC_LOCATION
256-
OUTPUT_STRIP_TRAILING_WHITESPACE)
257-
set_property(TARGET ${PREFIX_IMPORTED_LIB}libc
258-
PROPERTY IMPORTED_LOCATION ${IMPORTED_LIBC_LOCATION})
259263
# libgcc
260264
add_library(${PREFIX_IMPORTED_LIB}libgcc STATIC IMPORTED)
261265
execute_process(COMMAND ${CMAKE_C_COMPILER} ${FLAGS_COMMON_ARCH} -print-file-name=libgcc.a
@@ -299,7 +303,9 @@ project (Jerry CXX C ASM)
299303

300304
function(declare_targets_for_build_mode BUILD_MODE)
301305
set(TARGET_NAME ${BUILD_MODE_PREFIX_${BUILD_MODE}}.${PLATFORM_L})
302-
set(LIBC_TARGET_NAME ${BUILD_MODE_PREFIX_${BUILD_MODE}}.jerry-libc.${PLATFORM_L}.lib)
306+
if (${USE_JERRY_LIBC})
307+
set(LIBC_TARGET_NAME ${BUILD_MODE_PREFIX_${BUILD_MODE}}.jerry-libc.${PLATFORM_L}.lib)
308+
endif()
303309

304310
function(declare_target_with_modifiers ) # modifiers are passed in ARGN implicit argument
305311
set(CORE_TARGET_NAME ${BUILD_MODE_PREFIX_${BUILD_MODE}})
@@ -408,7 +414,9 @@ project (Jerry CXX C ASM)
408414
set(TARGET_NAME unit-${TARGET_NAME})
409415

410416
set(CORE_TARGET_NAME unittests.jerry-core)
411-
set(LIBC_TARGET_NAME unittests.jerry-libc.${PLATFORM_L}.lib)
417+
if (${USE_JERRY_LIBC})
418+
set(LIBC_TARGET_NAME unittests.jerry-libc.${PLATFORM_L}.lib)
419+
endif ()
412420
set(FDLIBM_TARGET_NAME unittests.jerry-fdlibm${SUFFIX_THIRD_PARTY_LIB})
413421

414422
add_executable(${TARGET_NAME} ${SOURCE_UNIT_TEST_MAIN})

Makefile

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,16 @@
6969
endif
7070

7171
# External build configuration
72+
# Flag, indicating whether to use compiler's default libc (YES / NO)
73+
USE_COMPILER_DEFAULT_LIBC ?= NO
7274
# List of include paths for external libraries (semicolon-separated)
7375
EXTERNAL_LIBS_INTERFACE ?=
76+
# External libc interface
77+
ifeq ($(USE_COMPILER_DEFAULT_LIBC),YES)
78+
ifneq ($(EXTERNAL_LIBC_INTERFACE),)
79+
$(error EXTERNAL_LIBC_INTERFACE should not be specified in case compiler's default libc is used)
80+
endif
81+
endif
7482
# Compiler to use for external build
7583
EXTERNAL_C_COMPILER ?= arm-none-eabi-gcc
7684
EXTERNAL_CXX_COMPILER ?= arm-none-eabi-g++

0 commit comments

Comments
 (0)