Skip to content

Commit 41e8151

Browse files
committed
Optimize 'lit_get_magic_string_size' calls
Calculate magic string length sizes in compile time. JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]
1 parent 85365da commit 41e8151

File tree

3 files changed

+10
-33
lines changed

3 files changed

+10
-33
lines changed

jerry-core/lit/lit-literal.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ lit_init (void)
3131

3232
rcs_chunked_list_init (&rcs_lit_storage);
3333

34-
lit_magic_strings_init ();
3534
lit_magic_strings_ex_init ();
3635
} /* lit_init */
3736

jerry-core/lit/lit-magic-strings.c

Lines changed: 10 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717

1818
#include "lit-strings.h"
1919

20-
/**
21-
* Lengths of magic strings
22-
*/
23-
static lit_magic_size_t lit_magic_string_sizes[LIT_MAGIC_STRING__COUNT];
24-
2520
/**
2621
* External magic strings data array, count and lengths
2722
*/
@@ -36,32 +31,6 @@ static const lit_utf8_size_t *lit_magic_string_ex_sizes = NULL;
3631
static ecma_length_t ecma_magic_string_max_length;
3732
#endif /* JERRY_NDEBUG */
3833

39-
/**
40-
* Initialize data for string helpers
41-
*/
42-
void
43-
lit_magic_strings_init (void)
44-
{
45-
/* Initializing magic strings information */
46-
47-
#ifndef JERRY_NDEBUG
48-
ecma_magic_string_max_length = 0;
49-
#endif /* !JERRY_NDEBUG */
50-
51-
for (lit_magic_string_id_t id = (lit_magic_string_id_t) 0;
52-
id < LIT_MAGIC_STRING__COUNT;
53-
id = (lit_magic_string_id_t) (id + 1))
54-
{
55-
lit_magic_string_sizes[id] = (lit_magic_size_t) lit_zt_utf8_string_size (lit_get_magic_string_utf8 (id));
56-
57-
#ifndef JERRY_NDEBUG
58-
ecma_magic_string_max_length = JERRY_MAX (ecma_magic_string_max_length, lit_magic_string_sizes[id]);
59-
60-
JERRY_ASSERT (ecma_magic_string_max_length <= LIT_MAGIC_STRING_LENGTH_LIMIT);
61-
#endif /* !JERRY_NDEBUG */
62-
}
63-
} /* lit_magic_strings_init */
64-
6534
/**
6635
* Initialize external magic strings
6736
*/
@@ -114,6 +83,16 @@ lit_get_magic_string_utf8 (lit_magic_string_id_t id) /**< magic string id */
11483
lit_utf8_size_t
11584
lit_get_magic_string_size (lit_magic_string_id_t id) /**< magic string id */
11685
{
86+
static const lit_magic_size_t lit_magic_string_sizes[] =
87+
{
88+
#define LIT_MAGIC_STRING_DEF(id, utf8_string) \
89+
sizeof(utf8_string) - 1,
90+
#include "lit-magic-strings.inc.h"
91+
#undef LIT_MAGIC_STRING_DEF
92+
};
93+
94+
JERRY_ASSERT (id < LIT_MAGIC_STRING__COUNT);
95+
11796
return lit_magic_string_sizes[id];
11897
} /* lit_get_magic_string_size */
11998

jerry-core/lit/lit-magic-strings.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ typedef enum
4141
*/
4242
typedef uint32_t lit_magic_string_ex_id_t;
4343

44-
extern void lit_magic_strings_init (void);
4544
extern void lit_magic_strings_ex_init (void);
4645

4746
extern uint32_t lit_get_magic_string_ex_count (void);

0 commit comments

Comments
 (0)