Array.prototype.reduceRight() tests and fixes.

JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs [email protected]

Author: lvidacs

jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp

@@ -1476,14 +1476,14 @@ ecma_builtin_array_prototype_object_reduce_right (ecma_value_t this_arg, /**< th
   }
   else
   {
-    ecma_completion_value_t accumulator = ecma_make_empty_completion_value ();
     ecma_number_t *num_p = ecma_alloc_number ();
     ecma_object_t *func_object_p;
     ecma_value_t current_index;
 
     ecma_completion_value_t to_object_comp = ecma_op_to_object (arg1);
     JERRY_ASSERT (ecma_is_completion_value_normal (to_object_comp));
     func_object_p = ecma_get_object_from_completion_value (to_object_comp);
+    ecma_completion_value_t accumulator = ecma_make_empty_completion_value ();
 
     /* 5 */
     if (len_number == ECMA_NUMBER_ZERO && ecma_is_value_undefined (arg1))
@@ -1543,13 +1543,17 @@ ecma_builtin_array_prototype_object_reduce_right (ecma_value_t this_arg, /**< th
         current_index = ecma_make_number_value (num_p);
         ecma_value_t prev_value = ecma_get_completion_value_value (accumulator);
         ecma_value_t call_args[] = {prev_value, current_value, current_index, obj_this};
+        ecma_value_t undefined_value = ecma_make_simple_value (ECMA_SIMPLE_VALUE_UNDEFINED);
 
         ECMA_TRY_CATCH (call_value,
-                        ecma_op_function_call (func_object_p, ECMA_SIMPLE_VALUE_UNDEFINED, call_args, 4),
+                        ecma_op_function_call (func_object_p, undefined_value, call_args, 4),
                         ret_value);
+
+        ecma_free_completion_value (accumulator);
         accumulator = ecma_copy_completion_value (call_value);
 
         ECMA_FINALIZE (call_value);
+        ecma_free_value (undefined_value, false);
         ECMA_FINALIZE (current_value);
       }
       ecma_deref_ecma_string (index_str_p);

tests/jerry/array_prototype_reduce_right.js

@@ -0,0 +1,55 @@
+// Copyright 2015 Samsung Electronics Co., Ltd.
+// Copyright 2015 University of Szeged.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+var func = function(a, b) {
+  return a + b;
+}
+
+// check function type
+try {
+  [0].reduceRight(new Object());
+  assert(false);
+} catch(e) {
+  assert(e instanceof TypeError);
+}
+
+// check for init value
+try {
+  [].reduceRight(func);
+}
+catch(e) {
+  assert(e instanceof TypeError);
+}
+
+// various checks
+assert([].reduceRight(func, 1) === 1);
+
+assert([0].reduceRight(func) === 0);
+
+assert([0, 1].reduceRight(func) === 1);
+
+assert([0, 1].reduceRight(func, 1) === 2);
+
+assert([0, 1, 2, 3].reduceRight(func, 1) === 7);
+
+assert (["A","B"].reduceRight(func) === "BA");
+
+assert (["A","B"].reduceRight(func, "Init:") === "Init:BA");
+
+assert ([0, 1].reduceRight(func, 3.2) === 4.2);
+
+assert ([0, "x", 1].reduceRight(func) === "1x0");
+
+assert ([0, "x", 1].reduceRight(func, 3.2) === "4.2x0");