Temporarily disable class Array/%TypedArray%.prototype.{slice, map, concat, filter, splice} related tests

This patch temporarily fixes #2587.
The reason of disabling these tests is that the current implementation slightly differs from the related part of the standard (ECMA-262 v6, 9.4.2.3.6.d.1).
This part requires the hidden Symbol.@@species property, hence this functionality has not been implemented yet in the project.
Also add the related test case to prevent further errors.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

Author: rerobika

jerry-core/config.h

@@ -43,6 +43,7 @@
 # define CONFIG_DISABLE_ES2015_MAP_BUILTIN
 # define CONFIG_DISABLE_ES2015_OBJECT_INITIALIZER
 # define CONFIG_DISABLE_ES2015_PROMISE_BUILTIN
+# define CONFIG_DISABLE_ES2015_SYMBOL
 # define CONFIG_DISABLE_ES2015_TEMPLATE_STRINGS
 # define CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN
 #endif /* CONFIG_DISABLE_ES2015 */

jerry-core/ecma/operations/ecma-array-object.c

@@ -154,6 +154,7 @@ ecma_op_create_array_object_by_constructor (const ecma_value_t *arguments_list_p
                                             ecma_object_t *object_p) /**< The object from whom the new array object
                                                                       *   is being created */
 {
+#ifndef CONFIG_DISABLE_ES2015_SYMBOL
   ecma_value_t constructor_value = ecma_op_object_get_by_magic_id (object_p, LIT_MAGIC_STRING_CONSTRUCTOR);
 
   if (ECMA_IS_VALUE_ERROR (constructor_value)
@@ -165,6 +166,8 @@ ecma_op_create_array_object_by_constructor (const ecma_value_t *arguments_list_p
   }
 
   ecma_object_t *constructor_object_p = ecma_get_object_from_value (constructor_value);
+
+  /* TODO: Use @@species after Symbol has been implemented */
   ecma_value_t constructor_prototype = ecma_op_object_get_by_magic_id (constructor_object_p,
                                                                        LIT_MAGIC_STRING_PROTOTYPE);
 
@@ -175,10 +178,15 @@ ecma_op_create_array_object_by_constructor (const ecma_value_t *arguments_list_p
     return constructor_prototype;
   }
 
+#else /* CONFIG_DISABLE_ES2015_SYMBOL*/
+  JERRY_UNUSED (object_p);
+#endif /* !CONFIG_DISABLE_ES2015_SYMBOL */
+
   ecma_value_t result = ecma_op_create_array_object (arguments_list_p,
                                                      arguments_list_len,
                                                      is_treat_single_arg_as_length);
 
+#ifndef CONFIG_DISABLE_ES2015_SYMBOLS
   if (ecma_is_value_object (constructor_prototype))
   {
     ecma_object_t *result_object_p = ecma_get_object_from_value (result);
@@ -187,6 +195,7 @@ ecma_op_create_array_object_by_constructor (const ecma_value_t *arguments_list_p
   }
 
   ecma_free_value (constructor_prototype);
+#endif /* !CONFIG_DISABLE_ES2015_SYMBOL */
 
   return result;
 } /* ecma_op_create_array_object_by_constructor */

jerry-core/profiles/README.md

@@ -36,6 +36,7 @@ CONFIG_DISABLE_ES2015_FUNCTION_PARAMETER_INITIALIZER
 CONFIG_DISABLE_ES2015_MAP_BUILTIN
 CONFIG_DISABLE_ES2015_OBJECT_INITIALIZER
 CONFIG_DISABLE_ES2015_PROMISE_BUILTIN
+CONFIG_DISABLE_ES2015_SYMBOL
 CONFIG_DISABLE_ES2015_TEMPLATE_STRINGS
 CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN
 ```
@@ -98,11 +99,13 @@ In JerryScript all of the features are enabled by default, so an empty profile f
   Disable the [enhanced object initializer](http://www.ecma-international.org/ecma-262/6.0/#sec-object-initializer) language element.
 * `CONFIG_DISABLE_ES2015_PROMISE_BUILTIN`:
   Disable the [Promise](http://www.ecma-international.org/ecma-262/6.0/#sec-promise-objects) built-in.
+* `CONFIG_DISABLE_ES2015_SYMBOL`:
+  Disable the [Symbol](http://www.ecma-international.org/ecma-262/6.0/#sec-symbol-constructor) language element.
 * `CONFIG_DISABLE_ES2015_TEMPLATE_STRINGS`:
   Disable the [template strings](http://www.ecma-international.org/ecma-262/6.0/#sec-static-semantics-templatestrings).
 * `CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN`:
   Disable the [ArrayBuffer](http://www.ecma-international.org/ecma-262/6.0/#sec-arraybuffer-objects) and [TypedArray](http://www.ecma-international.org/ecma-262/6.0/#sec-typedarray-objects) built-ins.
 * `CONFIG_DISABLE_ES2015`: Disable all of the implemented [ECMAScript2015 features](http://www.ecma-international.org/ecma-262/6.0/).
   (equivalent to `CONFIG_DISABLE_ES2015_ARROW_FUNCTION`, `CONFIG_DISABLE_ES2015_BUILTIN`, `CONFIG_DISABLE_ES2015_CLASS`,
   `CONFIG_DISABLE_ES2015_FUNCTION_PARAMETER_INITIALIZER`, `CONFIG_DISABLE_ES2015_MAP_BUILTIN`, `CONFIG_DISABLE_ES2015_OBJECT_INITIALIZER`,
-  `CONFIG_DISABLE_ES2015_PROMISE_BUILTIN`, `CONFIG_DISABLE_ES2015_TEMPLATE_STRINGS`, and `CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN`).
+  `CONFIG_DISABLE_ES2015_PROMISE_BUILTIN`, `CONFIG_DISABLE_ES2015_TEMPLATE_STRINGS`, `CONFIG_DISABLE_ES2015_TEMPLATE_STRINGS`, and `CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN`).

tests/jerry/es2015/class-inheritance-builtin-array.js

@@ -47,6 +47,7 @@
  assert (c.g () === 5);
  assert (c.h () === 5);
 
+/* TODO: Enable these tests after Symbol has been implemented
  // Test built-in Array prototype methods
  var mapped = c.map ((x) => x * 2);
  isInstanceofArray (mapped);
@@ -114,3 +115,4 @@
  } catch (e) {
    assert (e instanceof TypeError);
  }
+*/

tests/jerry/es2015/class-inheritance-builtin-typedarray.js

@@ -46,6 +46,7 @@
  assert (c.g () === 5)
  assert (c.h () === 5)
 
+/* TODO: Enable these tests after Symbol has been implemented
  var mapped = c.map ((x) => x * 2);
  isInstanceofTypedArray (mapped);
 
@@ -72,3 +73,4 @@
  } catch (e) {
    assert (e instanceof TypeError)
  }
+*/

tests/jerry/es2015/regression-test-issue-2587.js

@@ -0,0 +1,19 @@
+// Copyright JS Foundation and other contributors, http://js.foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+function f(a,b,c) {
+  var args = Array.prototype.slice.call(arguments, 3);
+  assert (typeof args.splice === "function");
+}
+f();