Skip to content

Commit 8d54c92

Browse files
committed
Use -Werror=xxx instead of -Werror
List all warnings explicitly that should be treated as errors instead of covering all warnings with the `-Werror` flag. But do keep in mind to add `-Werror=xxx` whenever we use `-Wxxx` (if xxx stands for a type of warning). This way we can avoid build failures caused by warning attributes that would be turned into errors by `-Werror` (which cannot be suppressed by any `-Wno-error=xxx` flag, unfortunately). JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
1 parent 5bc2703 commit 8d54c92

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

CMakeLists.txt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ project (Jerry CXX C ASM)
230230
if(NOT ("${PLATFORM}" STREQUAL "DARWIN"))
231231
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -fno-fat-lto-objects")
232232
endif()
233-
set(LINKER_FLAGS_COMMON "${LINKER_FLAGS_COMMON} -flto -Wno-error")
233+
set(LINKER_FLAGS_COMMON "${LINKER_FLAGS_COMMON} -flto")
234234
endif()
235235

236236
# Turn off stack protector
@@ -246,7 +246,12 @@ project (Jerry CXX C ASM)
246246
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Wmissing-declarations -Wno-attributes")
247247
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Wfatal-errors")
248248
if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX)
249-
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Werror -Wlogical-op")
249+
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Wlogical-op")
250+
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Werror=logical-op")
251+
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Werror=all -Werror=extra")
252+
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Werror=format-nonliteral -Werror=init-self")
253+
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Werror=conversion -Werror=sign-conversion -Werror=format-security")
254+
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Werror=missing-declarations")
250255
else()
251256
set(COMPILE_FLAGS_JERRY "${COMPILE_FLAGS_JERRY} -Wno-nested-anon-types")
252257
endif()

0 commit comments

Comments
 (0)