Skip to content

Commit 9366d38

Browse files
AnthonyCalandraAnthonyCalandra
committed
Support for shorthand object literal notation.
JerryScript-DCO-1.0-Signed-off-by: Anthony Calandra [email protected]
1 parent 29f6ffc commit 9366d38

File tree

8 files changed

+300
-31
lines changed

8 files changed

+300
-31
lines changed

‎jerry-core/config.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,10 @@
3737
*/
3838
#ifdef CONFIG_DISABLE_ES2015
3939
# define CONFIG_DISABLE_ES2015_ARROW_FUNCTION
40-
# define CONFIG_DISABLE_ES2015_CLASS
4140
# define CONFIG_DISABLE_ES2015_BUILTIN
41+
# define CONFIG_DISABLE_ES2015_CLASS
4242
# define CONFIG_DISABLE_ES2015_PROMISE_BUILTIN
43+
# define CONFIG_DISABLE_ES2015_OBJ_LITERAL
4344
# define CONFIG_DISABLE_ES2015_TEMPLATE_STRINGS
4445
# define CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN
4546
#endif /* CONFIG_DISABLE_ES2015 */

‎jerry-core/parser/js/js-lexer.c

Lines changed: 70 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -448,6 +448,45 @@ static const keyword_string_t * const keyword_string_list[9] =
448448
#undef LEXER_KEYWORD
449449
#undef LEXER_KEYWORD_END
450450

451+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
452+
/**
453+
* Checks if current identifier is a keyword or reserved word.
454+
*
455+
* @return true - if the current identifier is a keyword or reserved word
456+
* false - otherwise
457+
*/
458+
bool
459+
lexer_is_identifier_keyword (parser_context_t *context_p) /**< context */
460+
{
461+
lexer_lit_location_t *literal_p = &context_p->token.lit_location;
462+
463+
JERRY_ASSERT (literal_p->type == LEXER_IDENT_LITERAL);
464+
JERRY_ASSERT (literal_p->length <= PARSER_MAXIMUM_IDENT_LENGTH);
465+
466+
if (literal_p->has_escape || literal_p->length < 2 || literal_p->length > 10)
467+
{
468+
return false;
469+
}
470+
471+
const keyword_string_t *keyword_p = keyword_string_list[literal_p->length - 2];
472+
473+
do
474+
{
475+
if (literal_p->char_p[0] == keyword_p->keyword_p[0]
476+
&& literal_p->char_p[1] == keyword_p->keyword_p[1]
477+
&& memcmp (literal_p->char_p, keyword_p->keyword_p, literal_p->length) == 0)
478+
{
479+
return true;
480+
}
481+
482+
keyword_p++;
483+
}
484+
while (keyword_p->type != LEXER_EOS);
485+
486+
return false;
487+
} /* lexer_is_identifier_keyword */
488+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
489+
451490
/**
452491
* Parse identifier.
453492
*/
@@ -1326,7 +1365,7 @@ lexer_check_colon (parser_context_t *context_p) /**< context */
13261365
&& context_p->source_p[0] == (uint8_t) LIT_CHAR_COLON);
13271366
} /* lexer_check_colon */
13281367

1329-
#ifndef CONFIG_DISABLE_ES2015_CLASS
1368+
#if !defined (CONFIG_DISABLE_ES2015_CLASS) || !defined (CONFIG_DISABLE_ES2015_OBJ_LITERAL)
13301369
/**
13311370
* Checks whether the next token is a left parenthesis.
13321371
*
@@ -1343,7 +1382,7 @@ lexer_check_left_paren (parser_context_t *context_p) /**< context */
13431382
return (context_p->source_p < context_p->source_end_p
13441383
&& context_p->source_p[0] == (uint8_t) LIT_CHAR_LEFT_PAREN);
13451384
} /* lexer_check_left_paren */
1346-
#endif /* !CONFIG_DISABLE_ES2015_CLASS */
1385+
#endif /* !CONFIG_DISABLE_ES2015_CLASS || !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
13471386

13481387
#ifndef CONFIG_DISABLE_ES2015_ARROW_FUNCTION
13491388

@@ -2271,6 +2310,7 @@ lexer_expect_object_literal_id (parser_context_t *context_p, /**< context */
22712310
#ifndef CONFIG_DISABLE_ES2015_CLASS
22722311
int is_class_method = ((ident_opts & LEXER_OBJ_IDENT_CLASS_METHOD)
22732312
&& !(ident_opts & LEXER_OBJ_IDENT_ONLY_IDENTIFIERS)
2313+
&& !(ident_opts & LEXER_OBJ_IDENT_OBJ_METHOD)
22742314
&& (context_p->token.type != LEXER_KEYW_STATIC));
22752315
#endif /* !CONFIG_DISABLE_ES2015_CLASS */
22762316

@@ -2290,8 +2330,18 @@ lexer_expect_object_literal_id (parser_context_t *context_p, /**< context */
22902330
{
22912331
lexer_skip_spaces (context_p);
22922332

2293-
if (context_p->source_p < context_p->source_end_p
2294-
&& context_p->source_p[0] != LIT_CHAR_COLON)
2333+
bool not_end_of_literal = (context_p->source_p < context_p->source_end_p
2334+
&& context_p->source_p[0] != LIT_CHAR_COLON);
2335+
2336+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
2337+
not_end_of_literal = (not_end_of_literal
2338+
&& context_p->source_p[0] != LIT_CHAR_RIGHT_BRACE
2339+
&& context_p->source_p[0] != LIT_CHAR_COMMA
2340+
/* Shorthand notation allows methods named `get` and allows getters. */
2341+
&& !lexer_check_left_paren (context_p));
2342+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
2343+
2344+
if (not_end_of_literal)
22952345
{
22962346
if (lexer_compare_raw_identifier_to_current (context_p, "get", 3))
22972347
{
@@ -2330,6 +2380,12 @@ lexer_expect_object_literal_id (parser_context_t *context_p, /**< context */
23302380
context_p->column++;
23312381
return;
23322382
}
2383+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
2384+
else if (context_p->source_p[0] == LIT_CHAR_LEFT_PAREN)
2385+
{
2386+
create_literal_object = true;
2387+
}
2388+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
23332389
else
23342390
{
23352391
const uint8_t *char_p = context_p->source_p;
@@ -2349,6 +2405,16 @@ lexer_expect_object_literal_id (parser_context_t *context_p, /**< context */
23492405
}
23502406
}
23512407

2408+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
2409+
if (!(ident_opts & LEXER_OBJ_IDENT_ONLY_IDENTIFIERS)
2410+
&& (ident_opts & LEXER_OBJ_IDENT_OBJ_METHOD)
2411+
&& context_p->source_p[0] == LIT_CHAR_LEFT_PAREN)
2412+
{
2413+
context_p->token.type = LEXER_PROPERTY_METHOD;
2414+
return;
2415+
}
2416+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
2417+
23522418
#ifndef CONFIG_DISABLE_ES2015_CLASS
23532419
if (is_class_method
23542420
&& lexer_compare_raw_identifier_to_current (context_p, "constructor", 11))

‎jerry-core/parser/js/js-lexer.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ typedef enum
147147
LEXER_EXPRESSION_START, /**< expression start */
148148
LEXER_PROPERTY_GETTER, /**< property getter function */
149149
LEXER_PROPERTY_SETTER, /**< property setter function */
150+
LEXER_PROPERTY_METHOD, /**< property method (ES6+) */
150151
LEXER_COMMA_SEP_LIST, /**< comma separated bracketed expression list */
151152
LEXER_SCAN_SWITCH, /**< special value for switch pre-scan */
152153
LEXER_CLASS_CONSTRUCTOR, /**< special value for class constructor method */
@@ -216,6 +217,7 @@ typedef enum
216217
LEXER_OBJ_IDENT_NO_OPTS = (1u << 0), /**< no options */
217218
LEXER_OBJ_IDENT_ONLY_IDENTIFIERS = (1u << 1), /**< only identifiers are accepted */
218219
LEXER_OBJ_IDENT_CLASS_METHOD = (1u << 2), /**< expect identifier inside a class body */
220+
LEXER_OBJ_IDENT_OBJ_METHOD = (1u << 3), /**< expect method identifier inside object */
219221
} lexer_obj_ident_opts_t;
220222

221223
/**

‎jerry-core/parser/js/js-parser-expr.c

Lines changed: 72 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -610,49 +610,85 @@ parser_parse_object_literal (parser_context_t *context_p) /**< context */
610610

611611
while (true)
612612
{
613+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
614+
lexer_expect_object_literal_id (context_p, LEXER_OBJ_IDENT_OBJ_METHOD);
615+
#else /* CONFIG_DISABLE_ES2015_OBJ_LITERAL */
613616
lexer_expect_object_literal_id (context_p, LEXER_OBJ_IDENT_NO_OPTS);
617+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
614618

615619
if (context_p->token.type == LEXER_RIGHT_BRACE)
616620
{
617621
break;
618622
}
619623

620-
if (context_p->token.type == LEXER_PROPERTY_GETTER
621-
|| context_p->token.type == LEXER_PROPERTY_SETTER)
624+
bool token_type_is_method = (context_p->token.type == LEXER_PROPERTY_GETTER
625+
|| context_p->token.type == LEXER_PROPERTY_SETTER);
626+
627+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
628+
token_type_is_method = token_type_is_method || context_p->token.type == LEXER_PROPERTY_METHOD;
629+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
630+
631+
if (token_type_is_method)
622632
{
623633
uint32_t status_flags;
624-
cbc_ext_opcode_t opcode;
634+
uint16_t opcode;
625635
uint16_t literal_index, function_literal_index;
626636
parser_object_literal_item_types_t item_type;
637+
lexer_token_type_t token_type = context_p->token.type;
627638

628-
if (context_p->token.type == LEXER_PROPERTY_GETTER)
639+
if (token_type == LEXER_PROPERTY_GETTER)
629640
{
630641
status_flags = PARSER_IS_FUNCTION | PARSER_IS_CLOSURE | PARSER_IS_PROPERTY_GETTER;
631-
opcode = CBC_EXT_SET_GETTER;
642+
opcode = PARSER_TO_EXT_OPCODE (CBC_EXT_SET_GETTER);
632643
item_type = PARSER_OBJECT_PROPERTY_GETTER;
633644
}
634-
else
645+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
646+
else if (token_type == LEXER_PROPERTY_METHOD)
647+
{
648+
status_flags = PARSER_IS_FUNCTION | PARSER_IS_CLOSURE | PARSER_IS_FUNC_EXPRESSION;
649+
opcode = CBC_SET_LITERAL_PROPERTY;
650+
item_type = PARSER_OBJECT_PROPERTY_VALUE;
651+
}
652+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
653+
else /* token_type == LEXER_PROPERTY_SETTER */
635654
{
636655
status_flags = PARSER_IS_FUNCTION | PARSER_IS_CLOSURE | PARSER_IS_PROPERTY_SETTER;
637-
opcode = CBC_EXT_SET_SETTER;
656+
opcode = PARSER_TO_EXT_OPCODE (CBC_EXT_SET_SETTER);
638657
item_type = PARSER_OBJECT_PROPERTY_SETTER;
639658
}
640659

660+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
661+
lexer_expect_object_literal_id (context_p, LEXER_OBJ_IDENT_ONLY_IDENTIFIERS | LEXER_OBJ_IDENT_OBJ_METHOD);
662+
#else /* CONFIG_DISABLE_ES2015_OBJ_LITERAL */
641663
lexer_expect_object_literal_id (context_p, LEXER_OBJ_IDENT_ONLY_IDENTIFIERS);
664+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
665+
642666
literal_index = context_p->lit_object.index;
643667

644668
parser_append_object_literal_item (context_p, literal_index, item_type);
645669

646670
parser_flush_cbc (context_p);
647671
function_literal_index = lexer_construct_function_object (context_p, status_flags);
648672

673+
uint16_t push_literal_index = literal_index;
674+
uint16_t literal_property_index = function_literal_index;
675+
676+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
677+
/* Property methods aren't extended opcodes, so swap the values here. */
678+
if (token_type == LEXER_PROPERTY_METHOD)
679+
{
680+
push_literal_index = function_literal_index;
681+
literal_property_index = literal_index;
682+
}
683+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
684+
649685
parser_emit_cbc_literal (context_p,
650686
CBC_PUSH_LITERAL,
651-
literal_index);
687+
push_literal_index);
652688

653689
JERRY_ASSERT (context_p->last_cbc_opcode == CBC_PUSH_LITERAL);
654-
context_p->last_cbc_opcode = PARSER_TO_EXT_OPCODE (opcode);
655-
context_p->last_cbc.value = function_literal_index;
690+
context_p->last_cbc_opcode = opcode;
691+
context_p->last_cbc.value = literal_property_index;
656692

657693
lexer_next_token (context_p);
658694
}
@@ -665,13 +701,35 @@ parser_parse_object_literal (parser_context_t *context_p) /**< context */
665701
PARSER_OBJECT_PROPERTY_VALUE);
666702

667703
lexer_next_token (context_p);
668-
if (context_p->token.type != LEXER_COLON)
704+
705+
if (context_p->token.type == LEXER_COLON)
669706
{
670-
parser_raise_error (context_p, PARSER_ERR_COLON_EXPECTED);
707+
lexer_next_token (context_p);
708+
parser_parse_expression (context_p, PARSE_EXPR_NO_COMMA);
671709
}
710+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
711+
else if (context_p->token.type == LEXER_COMMA
712+
|| context_p->token.type == LEXER_RIGHT_BRACE)
713+
{
714+
// TODO somehow clean this up -- is it possible to parse and check for keywords by this step?
715+
lexer_lit_location_t prop_name_literal = context_p->token.lit_location;
672716

673-
lexer_next_token (context_p);
674-
parser_parse_expression (context_p, PARSE_EXPR_NO_COMMA);
717+
if (prop_name_literal.type != LEXER_IDENT_LITERAL || lexer_is_identifier_keyword (context_p))
718+
{
719+
parser_raise_error (context_p, PARSER_ERR_COLON_EXPECTED);
720+
}
721+
722+
lexer_construct_literal_object (context_p,
723+
&context_p->token.lit_location,
724+
context_p->token.lit_location.type);
725+
parser_emit_cbc_literal_from_token (context_p, CBC_PUSH_LITERAL);
726+
JERRY_ASSERT (context_p->last_cbc_opcode == CBC_PUSH_LITERAL);
727+
}
728+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
729+
else
730+
{
731+
parser_raise_error (context_p, PARSER_ERR_COLON_EXPECTED);
732+
}
675733

676734
if (context_p->last_cbc_opcode == CBC_PUSH_LITERAL)
677735
{

‎jerry-core/parser/js/js-parser-internal.h

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,10 +433,15 @@ void parser_set_continues_to_current_position (parser_context_t *context_p, pars
433433

434434
/* Lexer functions */
435435

436+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
437+
bool lexer_is_identifier_keyword (parser_context_t *context_p);
438+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
436439
void lexer_next_token (parser_context_t *context_p);
437440
bool lexer_check_colon (parser_context_t *context_p);
438-
#ifndef CONFIG_DISABLE_ES2015_CLASS
441+
#if !defined (CONFIG_DISABLE_ES2015_CLASS) || !defined (CONFIG_DISABLE_ES2015_OBJ_LITERAL)
439442
bool lexer_check_left_paren (parser_context_t *context_p);
443+
#endif /* !CONFIG_DISABLE_ES2015_CLASS || !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
444+
#ifndef CONFIG_DISABLE_ES2015_CLASS
440445
void lexer_skip_empty_statements (parser_context_t *context_p);
441446
#endif /* !CONFIG_DISABLE_ES2015_CLASS */
442447
#ifndef CONFIG_DISABLE_ES2015_ARROW_FUNCTION

‎jerry-core/parser/js/js-parser-scanner.c

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -762,16 +762,16 @@ parser_scan_until (parser_context_t *context_p, /**< context */
762762
}
763763
case SCAN_MODE_FUNCTION_ARGUMENTS:
764764
{
765+
const bool correct_stack_top = (stack_top == SCAN_STACK_BLOCK_STATEMENT
766+
|| stack_top == SCAN_STACK_BLOCK_EXPRESSION
765767
#ifndef CONFIG_DISABLE_ES2015_CLASS
766-
JERRY_ASSERT (stack_top == SCAN_STACK_BLOCK_STATEMENT
767-
|| stack_top == SCAN_STACK_BLOCK_EXPRESSION
768-
|| stack_top == SCAN_STACK_CLASS
769-
|| stack_top == SCAN_STACK_BLOCK_PROPERTY);
770-
#else /* CONFIG_DISABLE_ES2015_CLASS */
771-
JERRY_ASSERT (stack_top == SCAN_STACK_BLOCK_STATEMENT
772-
|| stack_top == SCAN_STACK_BLOCK_EXPRESSION
773-
|| stack_top == SCAN_STACK_BLOCK_PROPERTY);
768+
|| stack_top == SCAN_STACK_CLASS
774769
#endif /* !CONFIG_DISABLE_ES2015_CLASS */
770+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERALS
771+
|| stack_top == SCAN_STACK_OBJECT_LITERAL
772+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERALS */
773+
|| stack_top == SCAN_STACK_BLOCK_PROPERTY);
774+
JERRY_ASSERT (correct_stack_top);
775775

776776
if (context_p->token.type == LEXER_LITERAL
777777
&& (context_p->token.lit_location.type == LEXER_IDENT_LITERAL
@@ -833,15 +833,25 @@ parser_scan_until (parser_context_t *context_p, /**< context */
833833
}
834834

835835
if (context_p->token.type == LEXER_PROPERTY_GETTER
836-
|| context_p->token.type == LEXER_PROPERTY_SETTER)
836+
|| context_p->token.type == LEXER_PROPERTY_SETTER
837+
|| context_p->token.type == LEXER_PROPERTY_METHOD)
837838
{
838839
parser_stack_push_uint8 (context_p, SCAN_STACK_BLOCK_PROPERTY);
839840
mode = SCAN_MODE_FUNCTION_ARGUMENTS;
840841
break;
841842
}
842843

843844
lexer_next_token (context_p);
844-
if (context_p->token.type != LEXER_COLON)
845+
846+
bool not_end_of_property_name = context_p->token.type != LEXER_COLON;
847+
848+
#ifndef CONFIG_DISABLE_ES2015_OBJ_LITERAL
849+
not_end_of_property_name = (not_end_of_property_name
850+
&& context_p->token.type != LEXER_RIGHT_BRACE
851+
&& context_p->token.type != LEXER_COMMA);
852+
#endif /* !CONFIG_DISABLE_ES2015_OBJ_LITERAL */
853+
854+
if (not_end_of_property_name)
845855
{
846856
parser_raise_error (context_p, PARSER_ERR_COLON_EXPECTED);
847857
}

‎jerry-core/profiles/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,5 +93,7 @@ In JerryScript all of the features are enabled by default, so an empty profile f
9393
Disable the [template strings](http://www.ecma-international.org/ecma-262/6.0/#sec-static-semantics-templatestrings).
9494
* `CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN`:
9595
Disable the [ArrayBuffer](http://www.ecma-international.org/ecma-262/6.0/#sec-arraybuffer-objects) and [TypedArray](http://www.ecma-international.org/ecma-262/6.0/#sec-typedarray-objects) built-ins.
96+
* `CONFIG_DISABLE_ES2015_OBJ_LITERAL`:
97+
Disable the [object literal shorthand notation](https://www.ecma-international.org/ecma-262/6.0/#sec-object-initializer).
9698
* `CONFIG_DISABLE_ES2015`: Disable all of the implemented [ECMAScript2015 features](http://www.ecma-international.org/ecma-262/6.0/).
97-
(equivalent to `CONFIG_DISABLE_ES2015_ARROW_FUNCTION`, `CONFIG_DISABLE_ES2015_BUILTIN`, `CONFIG_DISABLE_ES2015_CLASS`, `CONFIG_DISABLE_ES2015_PROMISE_BUILTIN`, `CONFIG_DISABLE_ES2015_TEMPLATE_STRINGS`, and `CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN`).
99+
(equivalent to `CONFIG_DISABLE_ES2015_ARROW_FUNCTION`, `CONFIG_DISABLE_ES2015_BUILTIN`, `CONFIG_DISABLE_ES2015_CLASS`, `CONFIG_DISABLE_ES2015_PROMISE_BUILTIN`, `CONFIG_DISABLE_ES2015_TEMPLATE_STRINGS`, `CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN`, and `CONFIG_DISABLE_ES2015_OBJ_LITERAL`).

0 commit comments

Comments
 (0)