Fix for null pointer dereference in jmem_heap_free_block

Fixes #2435.

JerryScript-DCO-1.0-Signed-off-by: Daniel Balla [email protected]

Author: Daniel Balla

jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c

@@ -553,6 +553,11 @@ ecma_builtin_typedarray_prototype_filter (ecma_value_t this_arg, /**< this argum
   ecma_object_t *func_object_p = ecma_get_object_from_value (cb_func_val);
   ecma_value_t ret_value = ECMA_VALUE_EMPTY;
 
+  if (len == 0)
+  {
+    return ret_value;
+  }
+
   JMEM_DEFINE_LOCAL_ARRAY (pass_value_list_p, len * element_size, lit_utf8_byte_t);
 
   lit_utf8_byte_t *pass_value_p = pass_value_list_p;

jerry-core/jmem/jmem.h

@@ -195,16 +195,11 @@ void jmem_run_free_unused_memory_callbacks (jmem_free_unused_memory_severity_t s
  * if it was allocated (i.e. if the array's size was non-zero).
  */
 #define JMEM_FINALIZE_LOCAL_ARRAY(var_name) \
-  if (var_name != NULL) \
+  if (JERRY_LIKELY (var_name ## ___size != 0)) \
   { \
-    JERRY_ASSERT (var_name ## ___size != 0); \
-    \
+    JERRY_ASSERT (var_name != NULL); \
     jmem_heap_free_block (var_name, var_name ## ___size); \
   } \
-  else \
-  { \
-    JERRY_ASSERT (var_name ## ___size == 0); \
-  } \
 }
 
 /**

tests/jerry/regression-test-issue-2435.js

@@ -0,0 +1,15 @@
+// Copyright JS Foundation and other contributors, http://js.foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+(new Int8Array(0)).filter(parseInt)