Disable date object related system calls by default

Also fix some minor issues.
Related issue: #923

JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]

Author: LaszloLango

jerry-core/config.h

@@ -180,4 +180,12 @@
  */
 #define CONFIG_PARSER_ENABLE_PARSE_TIME_BYTE_CODE_OPTIMIZER
 
+/**
+  * Enable timezone and daylightsaving system calls for date object
+  *
+  * Note:
+  *      Experimental. Works on Ubuntu 14.04.
+  */
+// #define ECMA_ENABLE_DATE_SYS_CALLS
+
 #endif /* !CONFIG_H */

jerry-core/ecma/builtin-objects/ecma-builtin-date.c

@@ -33,7 +33,9 @@
 #define BUILTIN_UNDERSCORED_ID date
 #include "ecma-builtin-internal-routines-template.inc.h"
 
+#ifdef ECMA_ENABLE_DATE_SYS_CALLS
 #include <sys/time.h>
+#endif /* ECMA_ENABLE_DATE_SYS_CALLS */
 
 /** \addtogroup ecma ECMA
  * @{
@@ -451,16 +453,19 @@ ecma_builtin_date_utc (ecma_value_t this_arg __attr_unused___, /**< this argumen
 static ecma_value_t
 ecma_builtin_date_now (ecma_value_t this_arg __attr_unused___) /**< this argument */
 {
-  struct timeval tv;
   ecma_number_t *now_num_p = ecma_alloc_number ();
   *now_num_p = ECMA_NUMBER_ZERO;
 
+#ifdef ECMA_ENABLE_DATE_SYS_CALLS
+  struct timeval tv = { 0, 0 };
+
   if (gettimeofday (&tv, NULL) != 0)
   {
     return ecma_raise_type_error ("gettimeofday failed");
   }
 
   *now_num_p = ((ecma_number_t) tv.tv_sec) * 1000.0 + ((ecma_number_t) (tv.tv_usec / 1000));
+#endif /* ECMA_ENABLE_DATE_SYS_CALLS */
 
   return ecma_make_number_value (now_num_p);
 } /* ecma_builtin_date_now */

jerry-core/ecma/builtin-objects/ecma-builtin-helpers-date.c

@@ -26,16 +26,10 @@
 
 #ifndef CONFIG_ECMA_COMPACT_PROFILE_DISABLE_DATE_BUILTIN
 
+#ifdef ECMA_ENABLE_DATE_SYS_CALLS
 #include <sys/time.h>
 
-/**
- * Timezone structure
- */
-struct timezone
-{
-  int tz_minuteswest;     /**< minutes west of Greenwich */
-  int tz_dsttime;         /**< type of DST correction */
-};
+#endif /* ECMA_ENABLE_DATE_SYS_CALLS */
 
 /** \addtogroup ecma ECMA
  * @{
@@ -456,15 +450,19 @@ ecma_date_week_day (ecma_number_t time) /**< time value */
 ecma_number_t __attr_always_inline___
 ecma_date_local_tza ()
 {
-  struct timeval tv;
-  struct timezone tz;
+#ifdef ECMA_ENABLE_DATE_SYS_CALLS
+  struct timeval tv = { 0, 0 }; /* gettimeofday may not fill tv, so zero-initializing */
+  struct timezone tz = { 0, 0 }; /* gettimeofday may not fill tz, so zero-initializing */
 
   if (gettimeofday (&tv, &tz) != 0)
   {
-    return ecma_raise_type_error ("gettimeofday failed");
+    return ecma_number_make_nan ();
   }
 
   return tz.tz_minuteswest * -ECMA_DATE_MS_PER_MINUTE;
+#else /* !ECMA_ENABLE_DATE_SYS_CALLS */
+  return ECMA_NUMBER_ZERO;
+#endif /* ECMA_ENABLE_DATE_SYS_CALLS */
 } /* ecma_date_local_tza */
 
 /**
@@ -483,15 +481,19 @@ ecma_date_daylight_saving_ta (ecma_number_t time) /**< time value */
     return time; /* time is NaN */
   }
 
-  struct timeval tv;
-  struct timezone tz;
+#ifdef ECMA_ENABLE_DATE_SYS_CALLS
+  struct timeval tv = { 0, 0 }; /* gettimeofday may not fill tv, so zero-initializing */
+  struct timezone tz = { 0, 0 }; /* gettimeofday may not fill tz, so zero-initializing */
 
   if (gettimeofday (&tv, &tz) != 0)
   {
-    return ecma_raise_type_error ("gettimeofday failed");
+    return ecma_number_make_nan ();
   }
 
   return tz.tz_dsttime;
+#else /* !ECMA_ENABLE_DATE_SYS_CALLS */
+  return ECMA_NUMBER_ZERO;
+#endif /* ECMA_ENABLE_DATE_SYS_CALLS */
 } /* ecma_date_daylight_saving_ta */
 
 /**

jerry-libc/include/sys/time.h

@@ -31,6 +31,15 @@ struct timeval
   unsigned long tv_usec;  /**< microseconds */
 };
 
+/**
+ * Timezone structure
+ */
+struct timezone
+{
+  int tz_minuteswest;     /**< minutes west of Greenwich */
+  int tz_dsttime;         /**< type of DST correction */
+};
+
 int gettimeofday (void *tp, void *tzp);
 
 #ifdef __cplusplus