Optimising the ToString operation #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| res_p = ecma_new_ecma_string_from_uint32 ((uint32_t) (ecma_get_integer_from_value (value))); | ||
| } | ||
| } | ||
| else if (ecma_is_value_float_number (value)) |
There was a problem hiding this comment.
I would call ecma_get_integer_from_value (value) first, then check the sign, and that makes ecma_get_number_from_value call unnecessary.
There was a problem hiding this comment.
Yes, indeed, thanks! I've updated this patch.
| else if (ecma_is_value_integer_number (value)) | ||
| { | ||
| ecma_integer_value_t num = ecma_get_integer_from_value (value); | ||
| if (num < 0) |
There was a problem hiding this comment.
I would add a newline before this. After that LGTM.
| @@ -352,10 +352,23 @@ ecma_op_to_string (ecma_value_t value) /**< ecma value */ | |||
|
|
|||
| if (ecma_is_value_string (value)) | |||
| { | |||
| res_p = ecma_get_string_from_value (value); | |||
| res_p = ecma_get_string_from_value (value);ecma-array-object.c | |||
|
LGTM |
1 similar comment
|
LGTM |
Create new ecma-string from positive integers without cast it to ecma_number JerryScript-DCO-1.0-Signed-off-by: Robert Sipka [email protected]
|
rebased with master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new ecma-string from positive integers without cast it to ecma_number
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka [email protected]