Re-thinking the build system to bring it more into line with the conv… #1192

robertsipka · 2016-07-08T09:59:59Z

…entions.

We removed that implementation where the build directory isn't set up to build with exactly one
configuration of the project but potentially several variants: the same build directory
can/must be used for debug and release builds, for full or compact profile versions, etc.
So we reworked the CMakeLists, and now one build dir deal with exactly one configuration
of the project's libraries and tools.

JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka [email protected]

robertsipka · 2016-07-08T10:05:05Z

This patch is not a final version, the python scripts have to be developed and update is needed for the Makefiles of the external targets after these changes.

zherczeg · 2016-07-08T10:07:19Z

But people can give their feedback earlier.

dbatyai · 2016-07-08T13:54:11Z

CMakeLists.txt

+# Compile/link flags
+# build mode specific compile/link flags
+
+if(CMAKE_BUILD_TYPE STREQUAL "Release")


No need for the if.
CMAKE_C_FLAGS_RELEASE will only be used when the build type is Release.

LaszloLango · 2016-07-14T08:58:50Z

docs/01.GETTING-STARTED.md should be updated after this patch

robertsipka · 2016-07-18T14:17:28Z

We updated this patch based on the comments and we finished the missing tool scripts.
Makefiles of the external targets will be updated in the follow-up patches.

zherczeg · 2016-07-19T07:40:05Z

jerry-core/CMakeLists.txt

+set(DEFINES_JERRY
+    ${DEFINES_JERRY}
+    JERRY_ENABLE_SNAPSHOT_SAVE
+    JERRY_ENABLE_SNAPSHOT_EXEC


Does snapshot always set?

Yes, it does. This behaviour is similiar to the current one.
But this is unnecessary, so we made this defines optionally.
If both of them are disabled, then the size of Thumb-2 binary on RPi2 is reduced by ~3.5Kbyte.

zherczeg · 2016-07-19T09:09:23Z

I like this python based master script far more than the make based.

LaszloLango · 2016-07-20T11:58:08Z

@robertsipka, the PR has conflicts. Please rebase to the current master.

robertsipka · 2016-07-20T12:33:15Z

I've rebased this patch with master and updated it based on your comments.

LaszloLango · 2016-07-20T14:57:48Z

Is this still a WIP patch?

LaszloLango · 2016-07-21T08:15:04Z

CMakeLists.txt

+
+# Setup directories
+# Project binary dir
+set(PROJECT_BINARY_DIR ${CMAKE_BINARY_DIR})


CMake variables should be quoted. See also: #472
"${CMAKE_BINARY_DIR}"

LaszloLango · 2016-07-21T08:15:31Z

CMakeLists.txt

+set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/lib/)
+
+# Executable output directory
+set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/bin/)


LaszloLango · 2016-07-21T08:20:16Z

Please check the CMake variables and use quote chars, if they can contain space character (like storing path).

zherczeg · 2016-07-27T09:40:13Z

Thank you for the hard work. LGTM

tilmannOSG · 2016-07-27T14:54:15Z

Wow nice, I really like this patch. I just gave this a try and did a "python tools/build.py" and a couple seconds later I have my JerryScript binary. That's exactly the "works out of the box" experience we want to have :)

tilmannOSG · 2016-07-27T15:46:18Z

.travis.yml

@@ -11,20 +11,20 @@ before_install:

 install:

-script: "make -j VERBOSE=1 NINJA=1 $TARGET"
+script: "python tools/run-tests.py $OPTS"



Not sure whether it makes much of a difference given our small project size but it would be great if Travis CI could still use Ninja for the build :)

tilmannOSG · 2016-07-27T16:23:58Z

Great patch! LGTM from my side.
The only larger thing I noticed is that this patch effectively drops support for the STM32F3/4 MCU targets. We should definitely add that back in with instructions on downloading the respective files from the ST page or alternatively we put our own headers/startup code in the repository to support those boards. I don't think this is a blocker preventing this patch from going in though. Support for the STM32F3/4 can be added in a separate patch.

zherczeg · 2016-07-28T06:42:15Z

The difficulty with STM32 is the board support package cannot be downloaded without human intervention (accepting license) anymore, and it is unnecessary for those who does not target those systems. So we will add it back as a port, and those who wish to use it requires to perform some steps. I think this is a balanced approach.

tilmannOSG · 2016-07-28T07:01:04Z

Yes, expecting the users to download the files manually is perfectly fine.
An even better approach would be to not rely on the ST firmware package in the first place (I'm sure we're only using very few of the files anyway) and allow the JerryScript binary to be built and flashed to the device solely with open source tools like OpenOCD. E.g. the same way RIOT is doing it: https://github.com/RIOT-OS/RIOT/wiki/Board%3A-STM32F4discovery

dbatyai · 2016-07-28T09:08:20Z

Nice Patch! LGTM

…entions. We removed that implementation where the build directory isn't set up to build with exactly one configuration of the project but potentially several variants: the same build directory can/must be used for debug and release builds, for full or compact profile versions, etc. So we reworked the CMakeLists, and now one build dir deal with exactly one configuration of the project's libraries and tools. JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected] JerryScript-DCO-1.0-Signed-off-by: Robert Sipka [email protected]

robertsipka · 2016-07-28T10:44:56Z

Thanks, I've updated this patch based on your comments.

tilmannOSG · 2016-07-28T11:11:03Z

@robertsipka Thanks! I think the patch is now ready to go in :)

robertsipka force-pushed the rethinking_buildsystem branch from 6c2c267 to b1c6e02 Compare July 8, 2016 10:08

LaszloLango added enhancement An improvement tools Related to the tooling scripts labels Jul 8, 2016

LaszloLango added this to the Release v1.0 milestone Jul 8, 2016

dbatyai reviewed Jul 8, 2016
View reviewed changes

This was referenced Jul 12, 2016

Prepare the engine for release 1.0 #1125

Closed

I can't download the stm32f3discovery_fw.zip #1180

Closed

Missing "make install" on linux-x64 target #883

Closed

robertsipka force-pushed the rethinking_buildsystem branch from b1c6e02 to dc2aeaf Compare July 18, 2016 14:13

zherczeg reviewed Jul 19, 2016
View reviewed changes

robertsipka force-pushed the rethinking_buildsystem branch from dc2aeaf to 77378b7 Compare July 20, 2016 12:31

zherczeg mentioned this pull request Jul 20, 2016

Nominating Dániel Bátyai (dbatyai) for JerryScript Maintainer status #1220

Closed

robertsipka changed the title ~~WIP: Re-thinking the build system to bring it more into line with the conv…~~ Re-thinking the build system to bring it more into line with the conv… Jul 21, 2016

LaszloLango reviewed Jul 21, 2016
View reviewed changes

robertsipka force-pushed the rethinking_buildsystem branch from 77378b7 to cf27a0f Compare July 27, 2016 07:51

tilmannOSG mentioned this pull request Jul 27, 2016

Build Jerryscript for LLVM #1027

Closed

tilmannOSG reviewed Jul 27, 2016
View reviewed changes

robertsipka force-pushed the rethinking_buildsystem branch from cf27a0f to ddab1d8 Compare July 28, 2016 10:31

zherczeg merged commit ddab1d8 into jerryscript-project:master Jul 28, 2016

zherczeg mentioned this pull request Sep 5, 2016

Nominating Robert Sipka (@robertsipka) to become a JerryScript committer #1321

Closed

robertsipka deleted the rethinking_buildsystem branch November 24, 2016 08:49

Re-thinking the build system to bring it more into line with the conv… #1192

Re-thinking the build system to bring it more into line with the conv… #1192

Uh oh!

Conversation

robertsipka commented Jul 8, 2016

Uh oh!

robertsipka commented Jul 8, 2016

Uh oh!

zherczeg commented Jul 8, 2016

Uh oh!

dbatyai Jul 8, 2016

Choose a reason for hiding this comment

Uh oh!

LaszloLango commented Jul 14, 2016

Uh oh!

robertsipka commented Jul 18, 2016

Uh oh!

zherczeg Jul 19, 2016

Choose a reason for hiding this comment

Uh oh!

bzsolt Jul 20, 2016

Choose a reason for hiding this comment

Uh oh!

zherczeg commented Jul 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LaszloLango commented Jul 20, 2016

Uh oh!

robertsipka commented Jul 20, 2016

Uh oh!

LaszloLango commented Jul 20, 2016

Uh oh!

LaszloLango Jul 21, 2016

Choose a reason for hiding this comment

Uh oh!

LaszloLango Jul 21, 2016

Choose a reason for hiding this comment

Uh oh!

LaszloLango commented Jul 21, 2016

Uh oh!

zherczeg commented Jul 27, 2016

Uh oh!

tilmannOSG commented Jul 27, 2016

Uh oh!

tilmannOSG Jul 27, 2016

Choose a reason for hiding this comment

Uh oh!

tilmannOSG commented Jul 27, 2016

Uh oh!

zherczeg commented Jul 28, 2016

Uh oh!

tilmannOSG commented Jul 28, 2016

Uh oh!

dbatyai commented Jul 28, 2016

Uh oh!

robertsipka commented Jul 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tilmannOSG commented Jul 28, 2016

Uh oh!

Uh oh!

zherczeg commented Jul 19, 2016 •

edited

Loading

robertsipka commented Jul 28, 2016 •

edited

Loading