Reduce Math object binary size. #1491
Conversation
zherczeg
force-pushed
the
math_builtin_opt
branch
from
343d375 to
a66c2cc
Compare
| { | ||
| JERRY_UNUSED (this_arg); | ||
| ecma_value_t ret_value = ecma_make_simple_value (ECMA_SIMPLE_VALUE_EMPTY); | ||
| /* both numbers are zeroes */ |
There was a problem hiding this comment.
Comment should start with uppercase letter and end with full stop. Though honestly I think you can just drop the comment :)
| * | ||
| * @return ecma value | ||
| * Returned value must be freed with ecma_free_value. | ||
| */ | ||
| static ecma_value_t | ||
| ecma_builtin_math_object_exp (ecma_value_t this_arg, /**< 'this' argument */ | ||
| ecma_value_t arg) /**< routine's argument */ | ||
| ecma_builtin_math_object_random () /**< 'this' argument */ |
There was a problem hiding this comment.
Should have a void between the parentheses and the comment removed. Or alternatively a this parameter added :)
| * | ||
| * See also: | ||
| * ECMA-262 v5, 15.8.2.9 | ||
| * Dispatcher of the built-in's routines |
There was a problem hiding this comment.
of -> for
Please add a full stop as well.
zherczeg
force-pushed
the
math_builtin_opt
branch
from
a66c2cc to
5be7bb2
Compare
|
Fixed all requests. |
|
|
||
| /** | ||
| * The Math object's 'atan' routine | ||
| * The Math object's 'max' 'min' routines |
|
|
||
| /** | ||
| * The Math object's 'exp' routine | ||
| * The Math object's 'random' routine |
There was a problem hiding this comment.
Full stop at the end of the sentence please.
| * | ||
| * @return ecma value | ||
| * Returned value must be freed with ecma_free_value. | ||
| */ | ||
| static ecma_value_t | ||
| ecma_builtin_math_object_exp (ecma_value_t this_arg, /**< 'this' argument */ | ||
| ecma_value_t arg) /**< routine's argument */ | ||
| ecma_builtin_math_object_random () |
There was a problem hiding this comment.
Please replace ecma_builtin_math_object_random() with ecma_builtin_math_object_random(void). In C there's quite a difference between the two, right now you can call ecma_builtin_math_object_random() with an arbitrary number of arguments and the compiler won't complain :)
| * | ||
| * See also: | ||
| * ECMA-262 v5, 15.8.2.9 | ||
| * Dispatcher for the built-in's routines |
There was a problem hiding this comment.
Full stop at the end of the sentence please.
zherczeg
force-pushed
the
math_builtin_opt
branch
from
5be7bb2 to
c70613c
Compare
|
Thank you for the review. Issues were fixed. |
Although many Math built-in functions have a similar structure these code paths were implemented as separate C functions. After this patch only one common dispatcher remains which shares the common code paths of different built-in functions. This reduces the binary size by 1 Kbyte. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
math_builtin_opt
branch
from
c70613c to
d63bb4e
Compare
Roughly one KByte saving: 141024 -> 140256