Skip to content

target: mbedos5: Update generate_pins.py #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2016

Conversation

janjongboom
Copy link
Contributor

@janjongboom janjongboom commented Dec 15, 2016

to use the new Python API for querying targets, and use the new location of target PinNames.h file. Previously make source/pins.cpp just failed silently, and returned an empty file. Therefore using pin names from JS (LED1) would silently fail when building JerryScript against mbed OS 5.2.3. We missed this because it does not happen when you upgrade an existing mbed OS 5.1 project.

JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom [email protected]

@matthewelse @thegecko

Fix for #1493

@thegecko
Copy link
Contributor

LGTM

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "Fixes #1493" to the commit message too. LGTM after that.

…r querying targets, and use the new location of target PinNames.h file. Previously `make source/pins.cpp` just failed silently, and returned an empty file. Therefore using pin names from JS (`LED1`) would silently fail when building JerryScript against mbed OS 5.2.3. We missed this because it does not happen when you upgrade an existing mbed OS 5.1 project. Fixes jerryscript-project#1493.

JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom [email protected]
@janjongboom
Copy link
Contributor Author

@LaszloLango Done ^

@LaszloLango LaszloLango added bug Undesired behaviour jerry-port Related to the port API or the default port implementation labels Dec 16, 2016
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour jerry-port Related to the port API or the default port implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants