Skip to content

Rename jerry-port.h to jerryscript-port.h #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

akosthekiss
Copy link
Member

All public headers should follow the pattern jerryscript[-*].h.
The jerry-api.h to jerryscript.h renaming has already happened
a while ago, now it's time for the port API header to follow.

This patch

  • renames the public header file,
  • updates all includes to use the new file name (in jerry-main,
    in all the targets, and in the docs), and
  • keeps jerry-port.h as a deprecated forwarding header to leave
    some time for external users to follow up with this change.

As a related change, the header of the default port implementation
is also changed to jerryscript-port-default.h.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]

All public headers should follow the pattern `jerryscript[-*].h`.
The `jerry-api.h` to `jerryscript.h` renaming has already happened
a while ago, now it's time for the port API header to follow.

This patch
* renames the public header file,
* updates all includes to use the new file name (in `jerry-main`,
  in all the targets, and in the docs), and
* keeps `jerry-port.h` as a deprecated forwarding header to leave
  some time for external users to follow up with this change.

As a related change, the header of the default port implementation
is also changed to `jerryscript-port-default.h`.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
@akosthekiss akosthekiss added api Related to the public API jerry-port Related to the port API or the default port implementation labels Apr 21, 2017
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi
Copy link
Contributor

yichoi commented Apr 22, 2017

LGTM

@yichoi yichoi merged commit 6c3a6e7 into jerryscript-project:master Apr 22, 2017
@akosthekiss akosthekiss deleted the port-jerry-jerryscript branch April 22, 2017 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the public API jerry-port Related to the port API or the default port implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants