Remove trivial ecma_number arithmetic functions #2123
Conversation
|
I don't see any improvement here. This is just a noise. I think these inlining are done by compiler automatically, because the binary size did not increase. |
|
@LaszloLango I've updated the result with the run time standard deviation and highlighted the tests and results where the gain is magnitude greater then the std deviation. That's why I think it's more then noise. |
|
Also I've compared the two binaries (with patch and without patch) and there is difference between them. It's means inlining these functions has real effect. |
| @@ -687,7 +687,7 @@ ecma_number_calc_remainder (ecma_number_t left_num, /**< left operand */ | |||
| * | |||
| * @return number - result of addition. | |||
| */ | |||
| ecma_number_t | |||
| inline ecma_number_t __attr_always_inline___ | |||
There was a problem hiding this comment.
Please just remove these functions.
rerobika
force-pushed
the
inline_ecma_operations
branch
from
e8153f2 to
b4bcc77
Compare
rerobika
changed the title
|
@zherczeg Your suggestion have been applied! |
rerobika
force-pushed
the
inline_ecma_operations
branch
from
b4bcc77 to
4d3bbef
Compare
jerry-core/vm/vm.c
Outdated
| ecma_number_t new_value = ecma_number_add (ecma_get_float_from_value (left_value), | ||
| ecma_get_number_from_value (right_value)); | ||
| ecma_number_t new_value = ecma_get_float_from_value (left_value) + | ||
| ecma_get_number_from_value (right_value); |
There was a problem hiding this comment.
This is not nice alignment. What is the difference between float value and number value?
There was a problem hiding this comment.
Number value not specifies that the stored value is float or integer. Unfortunately it is not a nice alignment, but this is what vera++ requires.
There was a problem hiding this comment.
I think you can use () brackets to help aligning
There was a problem hiding this comment.
It worked! Thanks for your advice!
The affected function calls have been replaced with the appropriate arithmetic operands. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
rerobika
force-pushed
the
inline_ecma_operations
branch
from
4d3bbef to
f1fcbf8
Compare
The affected function calls have been replaced with the appropriate arithmetic operands.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]