-
Notifications
You must be signed in to change notification settings - Fork 684
Support methods for object initializers. #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support methods for object initializers. #2567
Conversation
b94e537
to
6794c5d
Compare
@@ -633,6 +633,28 @@ parser_parse_class (parser_context_t *context_p, /**< context */ | |||
} /* parser_parse_class */ | |||
#endif /* !CONFIG_DISABLE_ES2015_CLASS */ | |||
|
|||
#ifndef CONFIG_DISABLE_ES2015_OBJECT_INITIALIZER | |||
/** | |||
* Parse object method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add more description, add the related section number as a note to the description.
@@ -633,6 +633,28 @@ parser_parse_class (parser_context_t *context_p, /**< context */ | |||
} /* parser_parse_class */ | |||
#endif /* !CONFIG_DISABLE_ES2015_CLASS */ | |||
|
|||
#ifndef CONFIG_DISABLE_ES2015_OBJECT_INITIALIZER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this feature turned on by default in ES5.1 profile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It is the opposite. I think the guard is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description about the new feature to the profile documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CONFIG_DISABLE_ES2015_OBJECT_INITIALIZER is not a new macro, just a new feature is included into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Thanks for the clarification.
MethodDefinition in ES-2015 12.2.6. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
6794c5d
to
1e36e4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great patch, only a minor request.
@@ -633,6 +633,28 @@ parser_parse_class (parser_context_t *context_p, /**< context */ | |||
} /* parser_parse_class */ | |||
#endif /* !CONFIG_DISABLE_ES2015_CLASS */ | |||
|
|||
#ifndef CONFIG_DISABLE_ES2015_OBJECT_INITIALIZER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description about the new feature to the profile documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (informal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MethodDefinition in ES-2015 12.2.6.