-
Notifications
You must be signed in to change notification settings - Fork 684
Fix type conversion errors in case of TizenRT. #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type conversion errors in case of TizenRT. #2572
Conversation
JerryScript-DCO-1.0-Signed-off-by: Roland Takacs [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (informal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't an explicit type cast to bool
be a better approach in these cases? almost_bool ? true : false
seem strange to me.
A related question: Travis CI is green. Where does the error manifest itself?
@akosthekiss There are other |
http://port70.net/~nsz/c/c11/n1570.html#6.3.1.2 |
The referred section of the standard only mandates how a value must be converted to bool, not when. I.e., the standard does not require the compiler to allow implicit conversion from int to bool. |
There are some conversion errors when building JerryScript for TizenRT. This patch fixes that.
E.g.