Skip to content

Temporarily disable class Array/%TypedArray%.prototype.{slice, map, concat, filter, splice} related tests #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 5 additions & 34 deletions jerry-core/ecma/operations/ecma-array-object.c
Original file line number Diff line number Diff line change
Expand Up @@ -154,41 +154,12 @@ ecma_op_create_array_object_by_constructor (const ecma_value_t *arguments_list_p
ecma_object_t *object_p) /**< The object from whom the new array object
* is being created */
{
ecma_value_t constructor_value = ecma_op_object_get_by_magic_id (object_p, LIT_MAGIC_STRING_CONSTRUCTOR);
/* TODO: Use @@species after Symbol has been implemented */
JERRY_UNUSED (object_p);

if (ECMA_IS_VALUE_ERROR (constructor_value)
|| !ecma_is_value_object (constructor_value)
|| !ecma_is_constructor (constructor_value))
{
ecma_free_value (constructor_value);
return ecma_raise_type_error (ECMA_ERR_MSG ("object.constructor is not a constructor."));
}

ecma_object_t *constructor_object_p = ecma_get_object_from_value (constructor_value);
ecma_value_t constructor_prototype = ecma_op_object_get_by_magic_id (constructor_object_p,
LIT_MAGIC_STRING_PROTOTYPE);

ecma_deref_object (constructor_object_p);

if (ECMA_IS_VALUE_ERROR (constructor_prototype))
{
return constructor_prototype;
}

ecma_value_t result = ecma_op_create_array_object (arguments_list_p,
arguments_list_len,
is_treat_single_arg_as_length);

if (ecma_is_value_object (constructor_prototype))
{
ecma_object_t *result_object_p = ecma_get_object_from_value (result);
ecma_object_t *constructor_prototpye_object_p = ecma_get_object_from_value (constructor_prototype);
ECMA_SET_POINTER (result_object_p->prototype_or_outer_reference_cp, constructor_prototpye_object_p);
}

ecma_free_value (constructor_prototype);

return result;
return ecma_op_create_array_object (arguments_list_p,
arguments_list_len,
is_treat_single_arg_as_length);
} /* ecma_op_create_array_object_by_constructor */
#endif /* !CONFIG_DISABLE_ES2015_CLASS */

Expand Down
2 changes: 2 additions & 0 deletions tests/jerry/es2015/class-inheritance-builtin-array.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
assert (c.g () === 5);
assert (c.h () === 5);

/* TODO: Enable these tests after Symbol has been implemented
// Test built-in Array prototype methods
var mapped = c.map ((x) => x * 2);
isInstanceofArray (mapped);
Expand Down Expand Up @@ -114,3 +115,4 @@
} catch (e) {
assert (e instanceof TypeError);
}
*/
2 changes: 2 additions & 0 deletions tests/jerry/es2015/class-inheritance-builtin-typedarray.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
assert (c.g () === 5)
assert (c.h () === 5)

/* TODO: Enable these tests after Symbol has been implemented
var mapped = c.map ((x) => x * 2);
isInstanceofTypedArray (mapped);

Expand All @@ -72,3 +73,4 @@
} catch (e) {
assert (e instanceof TypeError)
}
*/
19 changes: 19 additions & 0 deletions tests/jerry/es2015/regression-test-issue-2587.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

function f(a,b,c) {
var args = Array.prototype.slice.call(arguments, 3);
assert (typeof args.splice === "function");
}
f();