Added the _restore function to "unpop" the argument stack. #2592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-harvey
force-pushed
the
add_restore_function_to_jerry_ext_helpers
branch
6 times, most recently
from
ad36072 to
147d9e2
Compare
|
For me this ok, although I haven't reviewed the original code. Perhaps @akosthekiss could help. |
LaszloLango
requested changes
Nov 15, 2018
|
Please add some test into the |
t-harvey
force-pushed
the
add_restore_function_to_jerry_ext_helpers
branch
4 times, most recently
from
506f13c to
f26716b
Compare
|
I think another round of review could be done here. |
|
Sorry for the late response. I am not sure this is right way to do this, but I am not against this PR. Please add the new API function to the related documentation ( |
t-harvey
force-pushed
the
add_restore_function_to_jerry_ext_helpers
branch
4 times, most recently
from
6a516ea to
a9d05e3
Compare
LaszloLango
approved these changes
Dec 6, 2018
t-harvey
force-pushed
the
add_restore_function_to_jerry_ext_helpers
branch
from
a9d05e3 to
b4a87c8
Compare
zherczeg
requested changes
Dec 14, 2018
t-harvey
force-pushed
the
add_restore_function_to_jerry_ext_helpers
branch
from
b4a87c8 to
67b49ae
Compare
Added a unit test for the jerryx_arg_js_iterator_restore function. Added the specification to the documentation. JerryScript-DCO-1.0-Signed-off-by: Timothy Harvey [email protected]
t-harvey
force-pushed
the
add_restore_function_to_jerry_ext_helpers
branch
from
67b49ae to
31d2156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request based on the discussion #2581.
Thanks!