Skip to content

Fix out-of-bounds writes (buffer overflows) in unit tests #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

Fix out-of-bounds writes (buffer overflows) in unit tests #2714

merged 1 commit into from
Jan 21, 2019

Conversation

akosthekiss
Copy link
Member

Fixes #2711
Fixes #2712

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]

@akosthekiss akosthekiss added bug Undesired behaviour test Related to testing labels Jan 18, 2019
rerobika
rerobika approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

LaszloLango
LaszloLango approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

robertsipka
robertsipka approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsipka robertsipka merged commit 2365b4e into jerryscript-project:master Jan 21, 2019
@akosthekiss akosthekiss deleted the fix-test-oob branch January 21, 2019 12:11
@zherczeg zherczeg mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsipka robertsipka robertsipka approved these changes

@LaszloLango LaszloLango LaszloLango approved these changes

@rerobika rerobika rerobika approved these changes

Assignees
No one assigned
Labels
bug Undesired behaviour test Related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akosthekiss @robertsipka @LaszloLango @rerobika