Skip to content

Optimize LCache entrys keys #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Conversation

rerobika
Copy link
Member

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

@rerobika
Copy link
Member Author

Perf results:

Benchmark Perf (sec)
3d-cube.js 0.798 -> 0.786 : +1.491%
3d-raytrace.js 0.965 -> 0.954 : +1.192%
access-binary-trees.js 0.528 -> 0.519 : +1.703%
access-fannkuch.js 1.920 -> 1.874 : +2.365%
access-nbody.js 1.013 -> 1.015 : -0.254%
bitops-3bit-bits-in-byte.js 0.470 -> 0.470 : +0.022%
bitops-bits-in-byte.js 0.644 -> 0.644 : -0.002%
bitops-bitwise-and.js 0.891 -> 0.867 : +2.648%
bitops-nsieve-bits.js 1.126 -> 1.090 : +3.257%
controlflow-recursive.js 0.342 -> 0.333 : +2.531%
crypto-aes.js 0.808 -> 0.786 : +2.794%
crypto-md5.js 0.538 -> 0.533 : +0.961%
crypto-sha1.js 0.539 -> 0.537 : +0.413%
date-format-tofte.js 0.725 -> 0.718 : +0.978%
date-format-xparb.js 0.502 -> 0.506 : -0.776%
math-cordic.js 1.122 -> 1.107 : +1.371%
math-partial-sums.js 0.695 -> 0.698 : -0.456%
math-spectral-norm.js 0.472 -> 0.474 : -0.514%
string-base64.js 1.338 -> 1.335 : +0.220%
string-fasta.js 1.290 -> 1.268 : +1.696%
Geometric mean: +1.089%
Binary (bytes) master(a1fdcf0) patch(ceb0ab2) Diff
size 132664 132664 0 bytes
.rodata 11255 11255 0 bytes
.dynstr 262 262 0 bytes
.rel.plt 176 176 0 bytes
.interp 25 25 0 bytes
.dynsym 384 384 0 bytes
.gnu.hash 188 188 0 bytes
.text 114404 114260 -144 bytes
.comment 59 59 0 bytes
.shstrtab 250 250 0 bytes
.data 8 8 0 bytes
.ARM.exidx 8 8 0 bytes
.rel.dyn 16 16 0 bytes
.init 12 12 0 bytes
.got 104 104 0 bytes
.plt 288 288 0 bytes
.note.gnu.build-id 36 36 0 bytes
.note.ABI-tag 32 32 0 bytes
.gnu.version_r 64 64 0 bytes
.bss 1575168 1575168 0 bytes
.fini 8 8 0 bytes
.gnu.version 48 48 0 bytes
.fini_array 4 4 0 bytes
.init_array 4 4 0 bytes
.dynamic 232 232 0 bytes
.eh_frame 4 4 0 bytes
.ARM.attributes 51 51 0 bytes
.jcr 4 4 0 bytes

@rerobika rerobika added enhancement An improvement performance Affects performance labels Feb 21, 2019
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dbatyai dbatyai merged commit 90f37a5 into jerryscript-project:master Mar 8, 2019
@rerobika rerobika deleted the opt_lcache branch March 18, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement performance Affects performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants