Implement DataView builtin #2804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
force-pushed
the
data_view
branch
2 times, most recently
from
9d05318 to
717c0e9
Compare
rerobika
force-pushed
the
data_view
branch
2 times, most recently
from
b1b42dd to
7b3e4d8
Compare
LaszloLango
requested changes
Apr 2, 2019
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-helpers.c
Outdated
Show resolved
Hide resolved
galpeter
reviewed
Apr 5, 2019
|
@galpeter @LaszloLango Thanks for the reviews I've updated the patch according to them. |
|
Rebased after #2793 has landed. |
New API functions: - jerry_create_dataview - jerry_value_is_dataview - jerry_get_dataview_buffer JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API functions:
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]