Skip to content

Properly handle CBC_PUSH_THIS_LITERAL for unary lvalue operations #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

rerobika
Copy link
Member

@rerobika rerobika commented Sep 4, 2019

This patch fixes #3048.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

@rerobika rerobika added bug Undesired behaviour parser Related to the JavaScript parser labels Sep 4, 2019
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the commit message, otherwise LGTM.

Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rerobika rerobika changed the title Property handle CBC_PUSH_THIS_LITERAL for unary lvalue operations Properly handle CBC_PUSH_THIS_LITERAL for unary lvalue operations Sep 5, 2019
@rerobika rerobika merged commit 142f79c into jerryscript-project:master Sep 5, 2019
@rerobika rerobika deleted the fix_issue_3048 branch June 16, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour parser Related to the JavaScript parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion PARSER_ARGS_EQ (opcode, CBC_HAS_LITERAL_ARG) in parser_emit_cbc_literal
3 participants