Skip to content

Commit 1903c93

Browse files
authored
Convert interfaces (introduced in after 11.0.0) from docblock to method (#54348)
For backward compatibility, we typically add new method to Interface using docblock on minor/patch releases. This should be a good time to declare them as actual method. Signed-off-by: Mior Muhammad Zaki <[email protected]>
1 parent f107d93 commit 1903c93

File tree

2 files changed

+19
-6
lines changed

2 files changed

+19
-6
lines changed

src/Illuminate/Contracts/Routing/UrlGenerator.php

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
namespace Illuminate\Contracts\Routing;
44

5-
/**
6-
* @method string query(string $path, array $query = [], mixed $extra = [], bool|null $secure = null)
7-
*/
85
interface UrlGenerator
96
{
107
/**
@@ -86,6 +83,17 @@ public function signedRoute($name, $parameters = [], $expiration = null, $absolu
8683
*/
8784
public function temporarySignedRoute($name, $expiration, $parameters = [], $absolute = true);
8885

86+
/**
87+
* Generate an absolute URL with the given query parameters.
88+
*
89+
* @param string $path
90+
* @param array $query
91+
* @param mixed $extra
92+
* @param bool|null $secure
93+
* @return string
94+
*/
95+
public function query($path, $query = [], $extra = [], $secure = null);
96+
8997
/**
9098
* Get the URL to a controller action.
9199
*

src/Illuminate/Queue/Failed/FailedJobProviderInterface.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
namespace Illuminate\Queue\Failed;
44

5-
/**
6-
* @method array ids(string $queue = null)
7-
*/
85
interface FailedJobProviderInterface
96
{
107
/**
@@ -18,6 +15,14 @@ interface FailedJobProviderInterface
1815
*/
1916
public function log($connection, $queue, $payload, $exception);
2017

18+
/**
19+
* Get the IDs of all of the failed jobs.
20+
*
21+
* @param string|null $queue
22+
* @return array
23+
*/
24+
public function ids($queue = null);
25+
2126
/**
2227
* Get a list of all of the failed jobs.
2328
*

0 commit comments

Comments
 (0)