Reverse routing with Route::controller()

[jasonlewis]

This may be intentional but I thought I'd bring it up just to double check.

If you use Route::controller() you can't use reverse routing for any of the actions on the controller. I believe this is because UrlGenerator::action() simply compares the _uses option of the route against the action provided. The requirements for a route aren't actually expanded.

A solution would be to convert the requirements into their regular expression equivalents and then compare the actions.

[taylorotwell]

I have a note to look at this actually. I just need to have it use a conventional route setup when this happens. I don't really like route::controller :)

On Jan 11, 2013, at 6:49 PM, Jason Lewis notifications@github.com wrote:

This may be intentional but I thought I'd bring it up just to double check.

If you use Route::controller() you can't use reverse routing for any of the actions on the controller. I believe this is because UrlGenerator::action() simply compares the _uses option of the route against the action provided. The requirements for a route aren't actually expanded.

A solution would be to convert the requirements into their regular expression equivalents and then compare the actions.

—
Reply to this email directly or view it on GitHub.

[jasonlewis]

I agree, but a lot of people do. I'm only asking because it was being talked about on IRC. I think a lot of people will be jumping at Route::controller() though because of how easy it is.

Cheers Taylor! :)

[taylorotwell]

Yeah, I'm going to look at a solution this weekend as I have time.

[taylorotwell]

I'm about halfway there on this one... :) put some stuff in last night that gets us closer, now I just need to modify how Route::controller works inside.

[johnnncodes]

Hi guys. I don't know if this is referring to the problem when using the the url to action helper. I already sent a tweet to @taylorotwell about the helper problem. When using Route::controller() , I can't use the helper action() to generate a url that points to the controller action in L4. In L3 it works. I hope it can be fixed since I really use that helper a lot (and many others I think).

[taylorotwell]

This is done.