Skip to content

better handing of Ctrl-C (and IDEs stop buttons) #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2022
Merged

better handing of Ctrl-C (and IDEs stop buttons) #237

merged 2 commits into from
Sep 23, 2022

Conversation

gdementen
Copy link
Collaborator

see #231

@gdementen
Copy link
Collaborator Author

@alixdamman could you review just the changelog?

@gdementen
Copy link
Collaborator Author

@alixdamman Well, I am merging this as-is and will let you review the whole changelog before the release, that will be more efficient this way.

@gdementen
FEAT: only catch Exception in except hooks (closes larray-project#231)
a15966e 
ie we shouldn't catch BaseException (KeyboardInterrupt, ...)

* run_editor_on_exception was very annoyingly opening the editor to "debug" KeyboardInterrupt exceptions
* we could not kill any editor launched by a program (explicitly or via run_editor_on_exception) using the "stop" button in PyCharm (which sends a KeyboardInterrupt exception to the program)
@gdementen gdementen merged commit 9ce042b into larray-project:master Sep 23, 2022
@gdementen gdementen deleted the better_except_hook branch September 23, 2022 10:06
@alixdamman
Copy link
Contributor

@gdementen changelog is fine to me

@gdementen gdementen mentioned this pull request Sep 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixdamman alixdamman Awaiting requested review from alixdamman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdementen @alixdamman