Skip to content

Commit 97262af

Browse files
authored
Allow specifying libcxx builder image. (#110303)
This change attempts to shift the libc++ builders over to new backend infrastructure that allows running an arbitrary container for the libc++ job. This has been a long time in the making, and support from github and gke is finally at the point where it's possible (hopefully). This change should also demonstrate another important property: No Downtime Upgrades. If this goes well, we'll be able to test the upgrade as a part of the PR process, and then commiting it to main should (ideally) not break anything.
1 parent b8ac87f commit 97262af

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

.github/workflows/libcxx-build-and-test.yaml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ env:
4949
jobs:
5050
stage1:
5151
if: github.repository_owner == 'llvm'
52-
runs-on: libcxx-runners-8-set
52+
runs-on: libcxx-runners-set
53+
container: ghcr.io/libcxx/actions-builder:testing-2024-09-21
5354
continue-on-error: false
5455
strategy:
5556
fail-fast: false
@@ -85,7 +86,8 @@ jobs:
8586
**/crash_diagnostics/*
8687
stage2:
8788
if: github.repository_owner == 'llvm'
88-
runs-on: libcxx-runners-8-set
89+
runs-on: libcxx-runners-set
90+
container: ghcr.io/libcxx/actions-builder:testing-2024-09-21
8991
needs: [ stage1 ]
9092
continue-on-error: false
9193
strategy:
@@ -162,20 +164,21 @@ jobs:
162164
'benchmarks',
163165
'bootstrapping-build'
164166
]
165-
machine: [ 'libcxx-runners-8-set' ]
167+
machine: [ 'libcxx-runners-set' ]
166168
include:
167169
- config: 'generic-cxx26'
168-
machine: libcxx-runners-8-set
170+
machine: libcxx-runners-set
169171
- config: 'generic-asan'
170-
machine: libcxx-runners-8-set
172+
machine: libcxx-runners-set
171173
- config: 'generic-tsan'
172-
machine: libcxx-runners-8-set
174+
machine: libcxx-runners-set
173175
- config: 'generic-ubsan'
174-
machine: libcxx-runners-8-set
176+
machine: libcxx-runners-set
175177
# Use a larger machine for MSAN to avoid timeout and memory allocation issues.
176178
- config: 'generic-msan'
177-
machine: libcxx-runners-8-set
179+
machine: libcxx-runners-set
178180
runs-on: ${{ matrix.machine }}
181+
container: ghcr.io/libcxx/actions-builder:testing-2024-09-21
179182
steps:
180183
- uses: actions/checkout@v4
181184
- name: ${{ matrix.config }}

0 commit comments

Comments
 (0)