[Clang][CodeGen] Address review comments.

dtcxzyw · dtcxzyw · commit aa4acdec652c · 2025-05-07T14:25:35.000+08:00
diff --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr.cpp
@@ -2248,7 +2248,8 @@ bool BinaryOperator::isNullPointerArithmeticExtension(ASTContext &Ctx,
   }
 
   // Workaround for old glibc's __PTR_ALIGN macro
-  if (auto *Select = dyn_cast<ConditionalOperator>(PExp->IgnoreParenCasts())) {
+  if (auto *Select =
+          dyn_cast<ConditionalOperator>(PExp->IgnoreParenNoopCasts(Ctx))) {
     // If the condition can be constant evaluated, we check the selected arm.
     bool EvalResult;
     if (!Select->getCond()->EvaluateAsBooleanCondition(EvalResult, Ctx))

Original file line number	Diff line number	Diff line change
`@@ -2248,7 +2248,8 @@ bool BinaryOperator::isNullPointerArithmeticExtension(ASTContext &Ctx,`
`2248`	`2248`	`}`
`2249`	`2249`
`2250`	`2250`	`// Workaround for old glibc's __PTR_ALIGN macro`
`2251`		`- if (auto *Select = dyn_cast<ConditionalOperator>(PExp->IgnoreParenCasts())) {`
	`2251`	`+ if (auto *Select =`
	`2252`	`+ dyn_cast<ConditionalOperator>(PExp->IgnoreParenNoopCasts(Ctx))) {`
`2252`	`2253`	`// If the condition can be constant evaluated, we check the selected arm.`
`2253`	`2254`	`bool EvalResult;`
`2254`	`2255`	`if (!Select->getCond()->EvaluateAsBooleanCondition(EvalResult, Ctx))`