Fix the false positive for make_optional(nullptr);

We should also consider isNullPtrType as the pointer type.

Author: hokein

clang/lib/Sema/CheckExprLifetime.cpp

@@ -277,7 +277,8 @@ static bool isContainerOfPointer(const RecordDecl *Container) {
     const auto &TAs = CTSD->getTemplateArgs();
     return TAs.size() > 0 && TAs[0].getKind() == TemplateArgument::Type &&
            (isRecordWithAttr<PointerAttr>(TAs[0].getAsType()) ||
-            TAs[0].getAsType()->isPointerType());
+            TAs[0].getAsType()->isPointerType() ||
+            TAs[0].getAsType()->isNullPtrType());
   }
   return false;
 }

clang/test/Sema/warn-lifetime-analysis-nocfg.cpp

@@ -629,4 +629,9 @@ std::optional<std::string_view> test3(int i) {
   return sv; // fine
 }
 
+std::optional<int*> test4(int a) {
+  if (a)
+   return std::make_optional(nullptr); // fine
+}
+
 } // namespace GH100526