Skip to content

Different formatting around type annotations with JS #107401

@kadircet

Description

@kadircet

a.js:

ctrl.onCopy(/** @type {!WizEvent}*/ (
    {event, targetElement: {el: () => selectedElement}}));

formatting after this change with clang-format -style='{AlignAfterOpenBracket: AlwaysBreak}' a.js

ctrl.onCopy(
    /** @type {!WizEvent}*/ (
        {event, targetElement : {el : () => selectedElement}}));

I can't really say this change looks like intended from the bug fix and code changes. Moreover, these kind of type annotations seems to be pretty common so unless the change deliberately changing behavior here can we restore the old behavior ?

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions