[clang-format] Formatting regression in 17.0.0 introduces spacing around arrow operator in macros

[sfc-gh-mheimel]

It seems that there is a formatting regression in 17.0.0 that affects the spacing of the arrow operator in macros containing assignments. Here's a minimal example (with an empty clang format config) to reproduce the issue:

$ cat test.cpp
#define P(ptr) auto p = (ptr)->p

In version 16, this is correctly formatted:

$ clang-format-16 test.cpp
#define P(ptr) auto p = (ptr)->p
$ clang-format-16 --version
clang-format version 16.0.0

With version 17, clang-format (incorrectly) wants to add spacing around the arrow operator:

$ clang-format-17 test.cpp
#define P(ptr) auto p = (ptr) -> p
$ clang-format-17 --version
clang-format version 17.0.0

Interestingly, the behavior is switched when the macro is removed:

$ cat test.cpp
auto p = (ptr)->p;
$ clang-format-17 test.cpp
auto p = (ptr)->p;
$ clang-format-16 test.cpp
auto p = (ptr) -> p;

[rymiel]

This was regressed by c70e360 (I take the blame, this could have been avoided)
This looks a lot like #61469 (fixed by fd86789), except inside of macros
I guess fixing both this issue and #47664 at the same time will take a more sophisticated heuristic than just the current

llvm-project/clang/lib/Format/TokenAnnotator.cpp

Line 2017 in ebed469

(Line.MightBeFunctionDecl || Line.InPPDirective) &&

[rymiel]

@owenca should I revert c70e360 for the 17 release branch?

[owenca]

@rymiel I wasn't sure if we should revert it, but it doesn't matter now. :)

[rymiel]

Thank you for doing what I couldn't!