From 9b945599ab6ea0b7380887b9bcba432a48c63fb2 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 20 Oct 2024 18:20:51 -0700 Subject: [PATCH] [tools] Don't call StringRef::str() when calling StringMap::find (NFC) StringMap::find takes StringRef. We don't need to create an instance of std::string from StringRef only to convert it right back to StringRef. --- llvm/tools/llvm-profdata/llvm-profdata.cpp | 4 ++-- llvm/tools/llvm-readtapi/llvm-readtapi.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/llvm/tools/llvm-profdata/llvm-profdata.cpp b/llvm/tools/llvm-profdata/llvm-profdata.cpp index c235c3f2b105e..59f0f1f1fae89 100644 --- a/llvm/tools/llvm-profdata/llvm-profdata.cpp +++ b/llvm/tools/llvm-profdata/llvm-profdata.cpp @@ -1297,7 +1297,7 @@ adjustInstrProfile(std::unique_ptr &WC, } else { auto NewName = StaticFuncMap.find(Name); if (NewName != StaticFuncMap.end()) { - It = InstrProfileMap.find(NewName->second.str()); + It = InstrProfileMap.find(NewName->second); if (NewName->second != DuplicateNameStr) { NewRootName = &NewName->second; } @@ -1382,7 +1382,7 @@ adjustInstrProfile(std::unique_ptr &WC, if (It == InstrProfileMap.end()) { auto NewName = StaticFuncMap.find(Name); if (NewName != StaticFuncMap.end()) { - It = InstrProfileMap.find(NewName->second.str()); + It = InstrProfileMap.find(NewName->second); if (NewName->second == DuplicateNameStr) { WithColor::warning() << "Static function " << Name diff --git a/llvm/tools/llvm-readtapi/llvm-readtapi.cpp b/llvm/tools/llvm-readtapi/llvm-readtapi.cpp index 1d740109d5b67..7390d0ec4b79a 100644 --- a/llvm/tools/llvm-readtapi/llvm-readtapi.cpp +++ b/llvm/tools/llvm-readtapi/llvm-readtapi.cpp @@ -382,7 +382,7 @@ static void stubifyDirectory(const StringRef InputPath, Context &Ctx) { // libraries to stubify. StringRef LibToCheck = Found->second; for (int i = 0; i < 20; ++i) { - auto LinkIt = SymLinks.find(LibToCheck.str()); + auto LinkIt = SymLinks.find(LibToCheck); if (LinkIt != SymLinks.end()) { for (auto &SymInfo : LinkIt->second) { SmallString LinkSrc(SymInfo.SrcPath);