diff --git a/mlir/lib/Dialect/Vector/IR/VectorOps.cpp b/mlir/lib/Dialect/Vector/IR/VectorOps.cpp index ad709813c6216..491b5f44b722b 100644 --- a/mlir/lib/Dialect/Vector/IR/VectorOps.cpp +++ b/mlir/lib/Dialect/Vector/IR/VectorOps.cpp @@ -327,8 +327,8 @@ SmallVector vector::getAsIntegers(ArrayRef foldResults) { SmallVector ints; llvm::transform( foldResults, std::back_inserter(ints), [](OpFoldResult foldResult) { - assert(foldResult.is() && "Unexpected non-constant index"); - return cast(foldResult.get()).getInt(); + assert(isa(foldResult) && "Unexpected non-constant index"); + return cast(cast(foldResult)).getInt(); }); return ints; } @@ -346,7 +346,7 @@ SmallVector vector::getAsValues(OpBuilder &builder, Location loc, loc, cast(attr).getInt()) .getResult(); - return foldResult.get(); + return cast(foldResult); }); return values; } @@ -1353,8 +1353,8 @@ LogicalResult vector::ExtractOp::verify() { return emitOpError( "expected position attribute of rank no greater than vector rank"); for (auto [idx, pos] : llvm::enumerate(position)) { - if (pos.is()) { - int64_t constIdx = cast(pos.get()).getInt(); + if (auto attr = dyn_cast(pos)) { + int64_t constIdx = cast(attr).getInt(); if (constIdx < 0 || constIdx >= getSourceVectorType().getDimSize(idx)) { return emitOpError("expected position attribute #") << (idx + 1) diff --git a/mlir/lib/Dialect/Vector/Transforms/VectorTransferOpTransforms.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorTransferOpTransforms.cpp index bd5f06a3b46d4..b0892d16969d2 100644 --- a/mlir/lib/Dialect/Vector/Transforms/VectorTransferOpTransforms.cpp +++ b/mlir/lib/Dialect/Vector/Transforms/VectorTransferOpTransforms.cpp @@ -251,7 +251,7 @@ static SmallVector getReducedShape(ArrayRef mixedSizes) { continue; } - auto value = cast(size.get()).getValue(); + auto value = cast(cast(size)).getValue(); if (value == 1) continue; reducedShape.push_back(value.getSExtValue()); @@ -570,8 +570,8 @@ static SmallVector getCollapsedIndices(RewriterBase &rewriter, collapsedOffset = affine::makeComposedFoldedAffineApply( rewriter, loc, collapsedExpr, collapsedVals); - if (collapsedOffset.is()) { - indicesAfterCollapsing.push_back(collapsedOffset.get()); + if (auto value = dyn_cast(collapsedOffset)) { + indicesAfterCollapsing.push_back(value); } else { indicesAfterCollapsing.push_back(rewriter.create( loc, *getConstantIntValue(collapsedOffset))); @@ -841,8 +841,8 @@ class RewriteScalarExtractElementOfTransferRead OpFoldResult ofr = affine::makeComposedFoldedAffineApply( rewriter, loc, sym0 + sym1, {newIndices[newIndices.size() - 1], extractOp.getPosition()}); - if (ofr.is()) { - newIndices[newIndices.size() - 1] = ofr.get(); + if (auto value = dyn_cast(ofr)) { + newIndices[newIndices.size() - 1] = value; } else { newIndices[newIndices.size() - 1] = rewriter.create(loc, @@ -879,14 +879,14 @@ class RewriteScalarExtractOfTransferRead SmallVector newIndices(xferOp.getIndices().begin(), xferOp.getIndices().end()); for (auto [i, pos] : llvm::enumerate(extractOp.getMixedPosition())) { - assert(pos.is() && "Unexpected non-constant index"); - int64_t offset = cast(pos.get()).getInt(); + assert(isa(pos) && "Unexpected non-constant index"); + int64_t offset = cast(cast(pos)).getInt(); int64_t idx = newIndices.size() - extractOp.getNumIndices() + i; OpFoldResult ofr = affine::makeComposedFoldedAffineApply( rewriter, extractOp.getLoc(), rewriter.getAffineSymbolExpr(0) + offset, {newIndices[idx]}); - if (ofr.is()) { - newIndices[idx] = ofr.get(); + if (auto value = dyn_cast(ofr)) { + newIndices[idx] = value; } else { newIndices[idx] = rewriter.create( extractOp.getLoc(), *getConstantIntValue(ofr)); diff --git a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp index 20cd9cba6909a..21ec718efd6a7 100644 --- a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp +++ b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp @@ -598,9 +598,9 @@ struct BubbleDownVectorBitCastForExtract // Get the first element of the mixed position as integer. auto mixedPos = extractOp.getMixedPosition(); - if (mixedPos.size() > 0 && !mixedPos[0].is()) + if (mixedPos.size() > 0 && !isa(mixedPos[0])) return failure(); - uint64_t index = cast(mixedPos[0].get()).getInt(); + uint64_t index = cast(cast(mixedPos[0])).getInt(); // Get the single scalar (as a vector) in the source value that packs the // desired scalar. E.g. extract vector<1xf32> from vector<4xf32>