From 6ce620bf0932f58e9f394c75bf91445bfa8cf7fb Mon Sep 17 00:00:00 2001 From: Jan Voung Date: Fri, 20 Dec 2024 14:30:06 +0000 Subject: [PATCH 1/2] Fix a missing break from a switch case -Wimplicit-fallthrough --- .../lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp b/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp index 546f128531df3..c9eb5f1b961b3 100644 --- a/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp +++ b/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp @@ -71,7 +71,8 @@ bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool &HasGet, ->getCanonicalTypeUnqualified(); } } - } + } + break; default: break; } From 8de3a1ffb9b3306b2f6d807e8d28db71d03aae48 Mon Sep 17 00:00:00 2001 From: Jan Voung Date: Fri, 20 Dec 2024 14:35:09 +0000 Subject: [PATCH 2/2] fix clang-format --- .../lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp b/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp index c9eb5f1b961b3..a0c81aa933da8 100644 --- a/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp +++ b/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp @@ -71,8 +71,7 @@ bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool &HasGet, ->getCanonicalTypeUnqualified(); } } - } - break; + } break; default: break; }