Skip to content

[compiler-rt][asan] Re-enable ManyThreadsTest on AArch64 #127795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

c-rhodes
Copy link
Collaborator

Disabled in 2ab51bf, doesn't hang for me on AArch64 (Graviton 3, tested 1000 iterations). May still be an issue, but hard to know unless we enable it again to find out.

n.b. test was also disabled on PowerPC in
467afc5 for same reason and it has also been observed on x86:
https://lists.llvm.org/pipermail/llvm-dev/2016-January/094607.html

Fixes: #24763

Disabled in 2ab51bf, doesn't hang for
me on AArch64 (Graviton 3, tested 1000 iterations). May still be an
issue, but hard to know unless we enable it again to find out.

n.b. test was also disabled on PowerPC in
467afc5 for same reason and it has also
been observed on x86:
https://lists.llvm.org/pipermail/llvm-dev/2016-January/094607.html

Fixes: llvm#24763
@llvmbot
Copy link
Member

llvmbot commented Feb 19, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Cullen Rhodes (c-rhodes)

Changes

Disabled in 2ab51bf, doesn't hang for me on AArch64 (Graviton 3, tested 1000 iterations). May still be an issue, but hard to know unless we enable it again to find out.

n.b. test was also disabled on PowerPC in
467afc5 for same reason and it has also been observed on x86:
https://lists.llvm.org/pipermail/llvm-dev/2016-January/094607.html

Fixes: #24763


Full diff: https://github.com/llvm/llvm-project/pull/127795.diff

1 Files Affected:

  • (modified) compiler-rt/lib/asan/tests/asan_test.cpp (+1-2)
diff --git a/compiler-rt/lib/asan/tests/asan_test.cpp b/compiler-rt/lib/asan/tests/asan_test.cpp
index 56377bde1c8de..0d98b1498a821 100644
--- a/compiler-rt/lib/asan/tests/asan_test.cpp
+++ b/compiler-rt/lib/asan/tests/asan_test.cpp
@@ -369,8 +369,7 @@ void *ManyThreadsWorker(void *a) {
   return 0;
 }
 
-#if !defined(__aarch64__) && !defined(__powerpc64__)
-// FIXME: Infinite loop in AArch64 (PR24389).
+#if !defined(__powerpc64__)
 // FIXME: Also occasional hang on powerpc.  Maybe same problem as on AArch64?
 TEST(AddressSanitizer, ManyThreadsTest) {
   const size_t kNumThreads =

@vitalybuka
Copy link
Collaborator

cc @rengolin

@c-rhodes c-rhodes merged commit 6d5ba79 into llvm:main Feb 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ASAN / AArch64] ManyThreadsTest fails on AArch64
3 participants