[lldb-dap] Test: disable children return test for all arm architectures #129409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: None (Da-Viper) Changesamd64 and aarch64 are treated differently Follows up #106907 Full diff: https://github.com/llvm/llvm-project/pull/129409.diff 1 Files Affected:
diff --git a/lldb/test/API/tools/lldb-dap/variables/children/TestDAP_variables_children.py b/lldb/test/API/tools/lldb-dap/variables/children/TestDAP_variables_children.py
index f0e1e51365d9b..a9371e5c5fe68 100644
--- a/lldb/test/API/tools/lldb-dap/variables/children/TestDAP_variables_children.py
+++ b/lldb/test/API/tools/lldb-dap/variables/children/TestDAP_variables_children.py
@@ -41,7 +41,7 @@ def test_get_num_children(self):
)["body"]["result"],
)
- @skipIf(archs=["arm64"])
+ @skipIf(archs=["arm", "arm64", "aarch64"])
def test_return_variable_with_children(self):
"""
Test the stepping out of a function with return value show the children correctly
|
vogelsgesang
approved these changes
Mar 2, 2025
vogelsgesang
reviewed
Mar 2, 2025
| @@ -41,7 +41,7 @@ def test_get_num_children(self): | |||
| )["body"]["result"], | |||
| ) | |||
|
|
|||
| @skipIf(archs=["arm64"]) | |||
| @skipIf(archs=["arm", "arm64", "aarch64"]) | |||
There was a problem hiding this comment.
what about arm64e? Does this test pass on arm64e?
omjavaid
approved these changes
Mar 4, 2025
|
@da-viper I am sorry but this PR was required to make LLDB Windows buildbot green so I have taken the liberty to merge it on your behalf. |
jph-13
pushed a commit
to jph-13/llvm-project
that referenced
this pull request
Mar 21, 2025
…es (llvm#129409) amd64 and aarch64 are treated differently Follows up llvm#106907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amd64 and aarch64 are treated differently
Follows up #106907