From 782113658cf4c5c2869ff0167b6aecc597eb260c Mon Sep 17 00:00:00 2001 From: Garvit Gupta Date: Wed, 18 Jun 2025 01:57:27 -0700 Subject: [PATCH] Fix tests failing on fuchsia clang x86_64 builders Fuchsia sets CLANG_DEFAULT_UNWINDLIB to libunwind. As a result, when rtlib is set to libgcc and unwindlib is not explicitly specified, tests using Fuchsia as the default platform will fail. To address this, the affected tests are xfailed. This change fixes the following tests introduced in 45ea46c: clang/test/Driver/aarch64-toolchain-extra.c clang/test/Driver/arm-toolchain-extra.c clang/test/Driver/aarch64-toolchain.c clang/test/Driver/arm-toolchain.c Change-Id: I16c979c3b3412417ff412ad82a32a5ad33f91ffc --- clang/test/Driver/aarch64-toolchain-extra.c | 1 + clang/test/Driver/aarch64-toolchain.c | 1 + clang/test/Driver/arm-toolchain-extra.c | 1 + clang/test/Driver/arm-toolchain.c | 1 + 4 files changed, 4 insertions(+) diff --git a/clang/test/Driver/aarch64-toolchain-extra.c b/clang/test/Driver/aarch64-toolchain-extra.c index 2610e962bd690..eb8c741ae1ad8 100644 --- a/clang/test/Driver/aarch64-toolchain-extra.c +++ b/clang/test/Driver/aarch64-toolchain-extra.c @@ -3,6 +3,7 @@ // The tests here are similar to those in aarch64-toolchain.c, however // these tests need to create symlinks to test directory trees in order to // set up the environment and therefore shell support is required. +// XFAIL: target={{.*}}-fuchsia{{.*}} // REQUIRES: shell // UNSUPPORTED: system-windows diff --git a/clang/test/Driver/aarch64-toolchain.c b/clang/test/Driver/aarch64-toolchain.c index 7f2c01d928e43..74841eec598b8 100644 --- a/clang/test/Driver/aarch64-toolchain.c +++ b/clang/test/Driver/aarch64-toolchain.c @@ -1,3 +1,4 @@ +// XFAIL: target={{.*}}-fuchsia{{.*}} // UNSUPPORTED: system-windows // RUN: %clang -### %s -fuse-ld= \ diff --git a/clang/test/Driver/arm-toolchain-extra.c b/clang/test/Driver/arm-toolchain-extra.c index 114de0a8154ab..67206818f2111 100644 --- a/clang/test/Driver/arm-toolchain-extra.c +++ b/clang/test/Driver/arm-toolchain-extra.c @@ -3,6 +3,7 @@ // The tests here are similar to those in arm-toolchain.c, however // these tests need to create symlinks to test directory trees in order to // set up the environment and therefore shell support is required. +// XFAIL: target={{.*}}-fuchsia{{.*}} // REQUIRES: shell // UNSUPPORTED: system-windows diff --git a/clang/test/Driver/arm-toolchain.c b/clang/test/Driver/arm-toolchain.c index 2e38461fb7a3e..56a0e0de7ba74 100644 --- a/clang/test/Driver/arm-toolchain.c +++ b/clang/test/Driver/arm-toolchain.c @@ -1,3 +1,4 @@ +// XFAIL: target={{.*}}-fuchsia{{.*}} // UNSUPPORTED: system-windows // RUN: %clang -### %s -fuse-ld= \