Skip to content

github-automation.py: Fix mis-indented statement #149653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kleisauke
Copy link

Ensure all reviewers who approved the original PR are properly notified and added as reviewers on backport PRs.

Resolves: #109429.

Ensure all reviewers who approved the original PR are properly notified
and added as reviewers on backport PRs.

Resolves: llvm#109429.
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was last touched in f33e927 which introduced this code (without the indent) after the migration to phabricator. The original code had the behavior that this patch restores, so I think this makes sense.

Please make sure one of the release managers (Tobias/Tom) reviews this though given they are the ones this will actually be impacting.

@zwuis zwuis requested a review from tru July 20, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[infrastructure] github-automation: pings missing in backport PRs
2 participants